some cleanup in rustc_session by hkBst · Pull Request #159398 · rust-lang/rust

hkBst · 2026-07-16T15:42:48Z

No description provided.

rustbot · 2026-07-16T15:42:53Z

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

hkBst · 2026-07-16T15:44:58Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();


The new code does not reset the slot to an empty Vec for a None argument. I'm curious to see if that matters.
View changes since the review

That would cause -Zoffload= to no longer override -Zoffload=a,b,c and instead silently get igbored, right? That is inconsistent with other cli flags where the last occurence does win.

That is true, but at the same time, the empty value is the only one that overrides in this way: -Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b', so it seems to already be inconsistent.
Anyway, no change was intended, so I'll revert. Thanks for explaining the significance to me!

-Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b'
Huh, that is inconsistent with other args that use parse_comma_list.

Yes, the reset only happens for an empty argument.

The function just before doesn't do a reset ever. Should it?
pub(crate)fnparse_dump_mono_stats(slot:&mutDumpMonoStatsFormat,v:Option<&str>) -> bool{match v {None => true,// hkBst: empty arg, no reset <-----Some("json") => {*slot = DumpMonoStatsFormat::Json;true}Some("markdown") => {*slot = DumpMonoStatsFormat::Markdown;true}Some(_) => false,}}

bjorn3 · 2026-07-17T15:50:25Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();
-for &val in v.iter() {
+ v.iter().all(|val| {


I don't think using side-effects inside of an iterator method is an improvement.
View changes since the review

I agree that that is not ideal, but I think that disadvantage is outweighed by the advantage of showing this is an all combinator instead of some random for loop that just happens to be a manual implementation of the all combinator.

rust-bors · 2026-08-13T10:24:59Z

☔ The latest upstream changes (presumably #161014) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

hkBst · 2026-07-16T15:42:48Z

No description provided.

rustbot · 2026-07-16T15:42:53Z

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

hkBst · 2026-07-16T15:44:58Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();


The new code does not reset the slot to an empty Vec for a None argument. I'm curious to see if that matters.
View changes since the review

That would cause -Zoffload= to no longer override -Zoffload=a,b,c and instead silently get igbored, right? That is inconsistent with other cli flags where the last occurence does win.

That is true, but at the same time, the empty value is the only one that overrides in this way: -Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b', so it seems to already be inconsistent.
Anyway, no change was intended, so I'll revert. Thanks for explaining the significance to me!

-Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b'
Huh, that is inconsistent with other args that use parse_comma_list.

Yes, the reset only happens for an empty argument.

The function just before doesn't do a reset ever. Should it?
pub(crate)fnparse_dump_mono_stats(slot:&mutDumpMonoStatsFormat,v:Option<&str>) -> bool{match v {None => true,// hkBst: empty arg, no reset <-----Some("json") => {*slot = DumpMonoStatsFormat::Json;true}Some("markdown") => {*slot = DumpMonoStatsFormat::Markdown;true}Some(_) => false,}}

bjorn3 · 2026-07-17T15:50:25Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();
-for &val in v.iter() {
+ v.iter().all(|val| {


I don't think using side-effects inside of an iterator method is an improvement.
View changes since the review

I agree that that is not ideal, but I think that disadvantage is outweighed by the advantage of showing this is an all combinator instead of some random for loop that just happens to be a manual implementation of the all combinator.

rust-bors · 2026-08-13T10:24:59Z

☔ The latest upstream changes (presumably #161014) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

hkBst · 2026-07-16T15:42:48Z

No description provided.

rustbot · 2026-07-16T15:42:53Z

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

hkBst · 2026-07-16T15:44:58Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();


The new code does not reset the slot to an empty Vec for a None argument. I'm curious to see if that matters.
View changes since the review

That would cause -Zoffload= to no longer override -Zoffload=a,b,c and instead silently get igbored, right? That is inconsistent with other cli flags where the last occurence does win.

That is true, but at the same time, the empty value is the only one that overrides in this way: -Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b', so it seems to already be inconsistent.
Anyway, no change was intended, so I'll revert. Thanks for explaining the significance to me!

-Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b'
Huh, that is inconsistent with other args that use parse_comma_list.

Yes, the reset only happens for an empty argument.

The function just before doesn't do a reset ever. Should it?
pub(crate)fnparse_dump_mono_stats(slot:&mutDumpMonoStatsFormat,v:Option<&str>) -> bool{match v {None => true,// hkBst: empty arg, no reset <-----Some("json") => {*slot = DumpMonoStatsFormat::Json;true}Some("markdown") => {*slot = DumpMonoStatsFormat::Markdown;true}Some(_) => false,}}

bjorn3 · 2026-07-17T15:50:25Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();
-for &val in v.iter() {
+ v.iter().all(|val| {


I don't think using side-effects inside of an iterator method is an improvement.
View changes since the review

I agree that that is not ideal, but I think that disadvantage is outweighed by the advantage of showing this is an all combinator instead of some random for loop that just happens to be a manual implementation of the all combinator.

rust-bors · 2026-08-13T10:24:59Z

☔ The latest upstream changes (presumably #161014) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

hkBst · 2026-07-16T15:42:48Z

No description provided.

rustbot · 2026-07-16T15:42:53Z

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

hkBst · 2026-07-16T15:44:58Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();


The new code does not reset the slot to an empty Vec for a None argument. I'm curious to see if that matters.
View changes since the review

That would cause -Zoffload= to no longer override -Zoffload=a,b,c and instead silently get igbored, right? That is inconsistent with other cli flags where the last occurence does win.

That is true, but at the same time, the empty value is the only one that overrides in this way: -Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b', so it seems to already be inconsistent.
Anyway, no change was intended, so I'll revert. Thanks for explaining the significance to me!

-Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b'
Huh, that is inconsistent with other args that use parse_comma_list.

Yes, the reset only happens for an empty argument.

The function just before doesn't do a reset ever. Should it?
pub(crate)fnparse_dump_mono_stats(slot:&mutDumpMonoStatsFormat,v:Option<&str>) -> bool{match v {None => true,// hkBst: empty arg, no reset <-----Some("json") => {*slot = DumpMonoStatsFormat::Json;true}Some("markdown") => {*slot = DumpMonoStatsFormat::Markdown;true}Some(_) => false,}}

bjorn3 · 2026-07-17T15:50:25Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();
-for &val in v.iter() {
+ v.iter().all(|val| {


I don't think using side-effects inside of an iterator method is an improvement.
View changes since the review

I agree that that is not ideal, but I think that disadvantage is outweighed by the advantage of showing this is an all combinator instead of some random for loop that just happens to be a manual implementation of the all combinator.

rust-bors · 2026-08-13T10:24:59Z

☔ The latest upstream changes (presumably #161014) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

hkBst · 2026-07-16T15:42:48Z

No description provided.

rustbot · 2026-07-16T15:42:53Z

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

hkBst · 2026-07-16T15:44:58Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();


The new code does not reset the slot to an empty Vec for a None argument. I'm curious to see if that matters.
View changes since the review

That would cause -Zoffload= to no longer override -Zoffload=a,b,c and instead silently get igbored, right? That is inconsistent with other cli flags where the last occurence does win.

That is true, but at the same time, the empty value is the only one that overrides in this way: -Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b', so it seems to already be inconsistent.
Anyway, no change was intended, so I'll revert. Thanks for explaining the significance to me!

-Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b'
Huh, that is inconsistent with other args that use parse_comma_list.

Yes, the reset only happens for an empty argument.

The function just before doesn't do a reset ever. Should it?
pub(crate)fnparse_dump_mono_stats(slot:&mutDumpMonoStatsFormat,v:Option<&str>) -> bool{match v {None => true,// hkBst: empty arg, no reset <-----Some("json") => {*slot = DumpMonoStatsFormat::Json;true}Some("markdown") => {*slot = DumpMonoStatsFormat::Markdown;true}Some(_) => false,}}

bjorn3 · 2026-07-17T15:50:25Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();
-for &val in v.iter() {
+ v.iter().all(|val| {


I don't think using side-effects inside of an iterator method is an improvement.
View changes since the review

I agree that that is not ideal, but I think that disadvantage is outweighed by the advantage of showing this is an all combinator instead of some random for loop that just happens to be a manual implementation of the all combinator.

rust-bors · 2026-08-13T10:24:59Z

☔ The latest upstream changes (presumably #161014) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

hkBst · 2026-07-16T15:42:48Z

No description provided.

rustbot · 2026-07-16T15:42:53Z

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

hkBst · 2026-07-16T15:44:58Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();


The new code does not reset the slot to an empty Vec for a None argument. I'm curious to see if that matters.
View changes since the review

That would cause -Zoffload= to no longer override -Zoffload=a,b,c and instead silently get igbored, right? That is inconsistent with other cli flags where the last occurence does win.

That is true, but at the same time, the empty value is the only one that overrides in this way: -Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b', so it seems to already be inconsistent.
Anyway, no change was intended, so I'll revert. Thanks for explaining the significance to me!

-Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b'
Huh, that is inconsistent with other args that use parse_comma_list.

Yes, the reset only happens for an empty argument.

The function just before doesn't do a reset ever. Should it?
pub(crate)fnparse_dump_mono_stats(slot:&mutDumpMonoStatsFormat,v:Option<&str>) -> bool{match v {None => true,// hkBst: empty arg, no reset <-----Some("json") => {*slot = DumpMonoStatsFormat::Json;true}Some("markdown") => {*slot = DumpMonoStatsFormat::Markdown;true}Some(_) => false,}}

bjorn3 · 2026-07-17T15:50:25Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();
-for &val in v.iter() {
+ v.iter().all(|val| {


I don't think using side-effects inside of an iterator method is an improvement.
View changes since the review

I agree that that is not ideal, but I think that disadvantage is outweighed by the advantage of showing this is an all combinator instead of some random for loop that just happens to be a manual implementation of the all combinator.

rust-bors · 2026-08-13T10:24:59Z

☔ The latest upstream changes (presumably #161014) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

hkBst · 2026-07-16T15:42:48Z

No description provided.

rustbot · 2026-07-16T15:42:53Z

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

hkBst · 2026-07-16T15:44:58Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();


The new code does not reset the slot to an empty Vec for a None argument. I'm curious to see if that matters.
View changes since the review

That would cause -Zoffload= to no longer override -Zoffload=a,b,c and instead silently get igbored, right? That is inconsistent with other cli flags where the last occurence does win.

That is true, but at the same time, the empty value is the only one that overrides in this way: -Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b', so it seems to already be inconsistent.
Anyway, no change was intended, so I'll revert. Thanks for explaining the significance to me!

-Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b'
Huh, that is inconsistent with other args that use parse_comma_list.

Yes, the reset only happens for an empty argument.

The function just before doesn't do a reset ever. Should it?
pub(crate)fnparse_dump_mono_stats(slot:&mutDumpMonoStatsFormat,v:Option<&str>) -> bool{match v {None => true,// hkBst: empty arg, no reset <-----Some("json") => {*slot = DumpMonoStatsFormat::Json;true}Some("markdown") => {*slot = DumpMonoStatsFormat::Markdown;true}Some(_) => false,}}

bjorn3 · 2026-07-17T15:50:25Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();
-for &val in v.iter() {
+ v.iter().all(|val| {


I don't think using side-effects inside of an iterator method is an improvement.
View changes since the review

I agree that that is not ideal, but I think that disadvantage is outweighed by the advantage of showing this is an all combinator instead of some random for loop that just happens to be a manual implementation of the all combinator.

rust-bors · 2026-08-13T10:24:59Z

☔ The latest upstream changes (presumably #161014) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

hkBst · 2026-07-16T15:42:48Z

No description provided.

rustbot · 2026-07-16T15:42:53Z

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

hkBst · 2026-07-16T15:44:58Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();


The new code does not reset the slot to an empty Vec for a None argument. I'm curious to see if that matters.
View changes since the review

That would cause -Zoffload= to no longer override -Zoffload=a,b,c and instead silently get igbored, right? That is inconsistent with other cli flags where the last occurence does win.

That is true, but at the same time, the empty value is the only one that overrides in this way: -Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b', so it seems to already be inconsistent.
Anyway, no change was intended, so I'll revert. Thanks for explaining the significance to me!

-Zoffload=a -Zoffload=b is the same as -Zoffload=a,b not as `-Zoffload=b'
Huh, that is inconsistent with other args that use parse_comma_list.

Yes, the reset only happens for an empty argument.

The function just before doesn't do a reset ever. Should it?
pub(crate)fnparse_dump_mono_stats(slot:&mutDumpMonoStatsFormat,v:Option<&str>) -> bool{match v {None => true,// hkBst: empty arg, no reset <-----Some("json") => {*slot = DumpMonoStatsFormat::Json;true}Some("markdown") => {*slot = DumpMonoStatsFormat::Markdown;true}Some(_) => false,}}

bjorn3 · 2026-07-17T15:50:25Z

+ let mut v: Vec<&str> = v.unwrap_or_default().split(",").collect();
 v.sort_unstable();
-for &val in v.iter() {
+ v.iter().all(|val| {


I don't think using side-effects inside of an iterator method is an improvement.
View changes since the review

I agree that that is not ideal, but I think that disadvantage is outweighed by the advantage of showing this is an all combinator instead of some random for loop that just happens to be a manual implementation of the all combinator.

rust-bors · 2026-08-13T10:24:59Z

☔ The latest upstream changes (presumably #161014) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

cleanup
1dd2be9

rustbot assigned eholk Jul 16, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 16, 2026