Uh oh!
There was an error while loading. Please reload this page.
Remove early_exit closures - #159647
Merged
rust-bors[bot] merged 2 commits intoJul 22, 2026
Merged
Conversation
There are two `early_exit` closures in `run_compiler` that ensure `abort_if_errors` is called on all the early exit paths. However, these early exit paths all occur in the closure passed to `interface::run_compiler`. And what does `interface::run_compiler` do after calling the passed-in closure? It calls `finish_diagnostic` (always) and then `abort_if_errors` (if the closure didn't panic). So we can drop the `early_exit` calls and get the same behaviour.
bjorn3
commented
Jul 21, 2026
Member
r=me with CI green |
nnethercote
commented
Jul 21, 2026
ContributorAuthor
Green. @bors r=bjorn3 |
Contributor
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 21, 2026
…, r=bjorn3 Remove `early_exit` closures Details in individual commits. r? @bjorn3
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 21, 2026
…, r=bjorn3 Remove `early_exit` closures Details in individual commits. r? @bjorn3
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 21, 2026
…, r=bjorn3 Remove `early_exit` closures Details in individual commits. r? @bjorn3
rust-borsBot
pushed a commit
that referenced
this pull request
Jul 21, 2026
Rollup of 12 pull requests Successful merges: - #159582 (Sync from portable simd 2026 07 20) - #158890 (Fix splat v0 mangling) - #159411 ([rustdoc] Correctly handle output options with --show-coverage) - #159647 (Remove `early_exit` closures) - #159656 (define a `Simd` type in `minicore`) - #156474 (Add paths for linked associated items) - #159211 (Fix debuginfo argument when invoking LLBC linker) - #159527 (Bring runtime symbols statics on par with foreign functions) - #159625 (Refactor is_opsem_inhabited) - #159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`) - #159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap ) - #159663 (Add layout cycle hang regression test)
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jul 22, 2026
…, r=bjorn3 Remove `early_exit` closures Details in individual commits. r? @bjorn3
This was referenced Jul 22, 2026
rust-borsBot
pushed a commit
that referenced
this pull request
Jul 22, 2026
Rollup of 13 pull requests Successful merges: - #159582 (Sync from portable simd 2026 07 20) - #158890 (Fix splat v0 mangling) - #159614 (debuginfo generation for unsafe binders) - #159647 (Remove `early_exit` closures) - #159656 (define a `Simd` type in `minicore`) - #156474 (Add paths for linked associated items) - #159211 (Fix debuginfo argument when invoking LLBC linker) - #159527 (Bring runtime symbols statics on par with foreign functions) - #159625 (Refactor is_opsem_inhabited) - #159629 (Add more splat rust-call regression tests) - #159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`) - #159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap ) - #159663 (Add layout cycle hang regression test)
rust-borsBot
pushed a commit
that referenced
this pull request
Jul 22, 2026
Rollup of 13 pull requests Successful merges: - #159582 (Sync from portable simd 2026 07 20) - #158890 (Fix splat v0 mangling) - #159614 (debuginfo generation for unsafe binders) - #159647 (Remove `early_exit` closures) - #159656 (define a `Simd` type in `minicore`) - #156474 (Add paths for linked associated items) - #159211 (Fix debuginfo argument when invoking LLBC linker) - #159527 (Bring runtime symbols statics on par with foreign functions) - #159625 (Refactor is_opsem_inhabited) - #159629 (Add more splat rust-call regression tests) - #159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`) - #159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap ) - #159663 (Add layout cycle hang regression test)
Uh oh!
There was an error while loading. Please reload this page.
pullBot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jul 22, 2026
Rollup of 13 pull requests Successful merges: - rust-lang/rust#159582 (Sync from portable simd 2026 07 20) - rust-lang/rust#158890 (Fix splat v0 mangling) - rust-lang/rust#159614 (debuginfo generation for unsafe binders) - rust-lang/rust#159647 (Remove `early_exit` closures) - rust-lang/rust#159656 (define a `Simd` type in `minicore`) - rust-lang/rust#156474 (Add paths for linked associated items) - rust-lang/rust#159211 (Fix debuginfo argument when invoking LLBC linker) - rust-lang/rust#159527 (Bring runtime symbols statics on par with foreign functions) - rust-lang/rust#159625 (Refactor is_opsem_inhabited) - rust-lang/rust#159629 (Add more splat rust-call regression tests) - rust-lang/rust#159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`) - rust-lang/rust#159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap ) - rust-lang/rust#159663 (Add layout cycle hang regression test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details in individual commits.
r? @bjorn3