Skip to content

Remove an outdated FIXME - #160210

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
ada4a:push-mnsnynmrtlyp
Aug 1, 2026
Merged

Remove an outdated FIXME#160210
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
ada4a:push-mnsnynmrtlyp

Conversation

@ada4a

@ada4aada4a commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

This FIXME was added in #78923, at which point there were 8 arguments. Now there are only 5, which is much more reasonable.

This commit was brought to you by https://oli-obk.github.io/fixmeh/.

@ada4a
Remove an outdated FIXME
aed6786
This FIXME was added in [1], at which point there were 8 arguments. Now
there are only 5, which is much more reasonable.
This commit was brought to you by https://oli-obk.github.io/fixmeh/.
[1]: rust-lang#78923
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 30, 2026
@rustbot

rustbot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustdoc
  • rustdoc expanded to 8 candidates
  • Random selection from GuillaumeGomez, lolbinarycat, notriddle

@notriddle

notriddle commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-borsBot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit aed6786 has been approved by notriddle

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 1, 2026
@jhpratt
Rollup merge ofrust-lang#160210- ada4a:push-mnsnynmrtlyp, r=notriddle
05bff60
Remove an outdated FIXME
This FIXME was added in rust-lang#78923, at which point there were 8 arguments. Now there are only 5, which is much more reasonable.
This commit was brought to you by https://oli-obk.github.io/fixmeh/.
@jhprattjhpratt mentioned this pull request Aug 1, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 1, 2026
@jhpratt
Rollup merge ofrust-lang#160210- ada4a:push-mnsnynmrtlyp, r=notriddle
5000500
Remove an outdated FIXME
This FIXME was added in rust-lang#78923, at which point there were 8 arguments. Now there are only 5, which is much more reasonable.
This commit was brought to you by https://oli-obk.github.io/fixmeh/.
This was referenced Aug 1, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Aug 1, 2026
@bors
Auto merge of#160310- jhpratt:rollup-0apoMmQ, r=jhpratt
b6a3d79
Rollup of 14 pull requests
Successful merges:
- #159245 (Emit retags in codegen to support BorrowSanitizer (part 5))
- #159864 (Report "capacity overflow" for oversized Rc<[T]>/Arc<[T]>)
- #160079 (make atomic operations const)
- #160124 (Structurally prevent zero-count `BackendRepr::SimdVector`s)
- #160162 (Make `#[fundamental]` only apply to the first argument of `Box`)
- #160210 (Remove an outdated FIXME)
- #160282 (Improve diagnostic for patterns in function pointer types)
- #157928 (Eagerly fetch typeck results when linting)
- #159672 (Improve suggestions when multiples tuples implement the same trait)
- #159861 (Add documentation for the `non_exhaustive` attribute)
- #159907 (Fix `hidden_glob_reexports` in `rustc_ast`)
- #159998 (Align expect messages with guidance)
- #160145 (Expand checks for register_tool)
- #160307 (Update `minifier` version to `0.4.0`)
@rust-bors
rust-borsBot merged commit c197c2a into rust-lang:mainAug 1, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Aug 1, 2026
rust-timer added a commit that referenced this pull request Aug 1, 2026
@rust-timer
Unrolled build for#160210
d5d52ab
Rollup merge of #160210 - ada4a:push-mnsnynmrtlyp, r=notriddle
Remove an outdated FIXME
This FIXME was added in #78923, at which point there were 8 arguments. Now there are only 5, which is much more reasonable.
This commit was brought to you by https://oli-obk.github.io/fixmeh/.
pullBot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Aug 2, 2026
@bors
Auto merge of #160310 - jhpratt:rollup-0apoMmQ, r=jhpratt
4a7cde8
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#159245 (Emit retags in codegen to support BorrowSanitizer (part 5))
- rust-lang/rust#159864 (Report "capacity overflow" for oversized Rc<[T]>/Arc<[T]>)
- rust-lang/rust#160079 (make atomic operations const)
- rust-lang/rust#160124 (Structurally prevent zero-count `BackendRepr::SimdVector`s)
- rust-lang/rust#160162 (Make `#[fundamental]` only apply to the first argument of `Box`)
- rust-lang/rust#160210 (Remove an outdated FIXME)
- rust-lang/rust#160282 (Improve diagnostic for patterns in function pointer types)
- rust-lang/rust#157928 (Eagerly fetch typeck results when linting)
- rust-lang/rust#159672 (Improve suggestions when multiples tuples implement the same trait)
- rust-lang/rust#159861 (Add documentation for the `non_exhaustive` attribute)
- rust-lang/rust#159907 (Fix `hidden_glob_reexports` in `rustc_ast`)
- rust-lang/rust#159998 (Align expect messages with guidance)
- rust-lang/rust#160145 (Expand checks for register_tool)
- rust-lang/rust#160307 (Update `minifier` version to `0.4.0`)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #160310 - jhpratt:rollup-0apoMmQ, r=jhpratt
5c68b3f
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#159245 (Emit retags in codegen to support BorrowSanitizer (part 5))
- rust-lang/rust#159864 (Report "capacity overflow" for oversized Rc<[T]>/Arc<[T]>)
- rust-lang/rust#160079 (make atomic operations const)
- rust-lang/rust#160124 (Structurally prevent zero-count `BackendRepr::SimdVector`s)
- rust-lang/rust#160162 (Make `#[fundamental]` only apply to the first argument of `Box`)
- rust-lang/rust#160210 (Remove an outdated FIXME)
- rust-lang/rust#160282 (Improve diagnostic for patterns in function pointer types)
- rust-lang/rust#157928 (Eagerly fetch typeck results when linting)
- rust-lang/rust#159672 (Improve suggestions when multiples tuples implement the same trait)
- rust-lang/rust#159861 (Add documentation for the `non_exhaustive` attribute)
- rust-lang/rust#159907 (Fix `hidden_glob_reexports` in `rustc_ast`)
- rust-lang/rust#159998 (Align expect messages with guidance)
- rust-lang/rust#160145 (Expand checks for register_tool)
- rust-lang/rust#160307 (Update `minifier` version to `0.4.0`)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@notriddlenotriddle

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ada4a@rustbot@notriddle