interpret: skip deref-projection validity checks when they are not needed by RalfJung · Pull Request #160399 · rust-lang/rust

RalfJung · 2026-08-02T19:35:50Z

Trying to claw back the perf regression from #160012.

We could also, like, skip the entire check in const-eval when we don't care about validity. But the slowdown will also affect Miri so I want to first try what we can do without doing less UB checking.

RalfJung · 2026-08-02T19:36:12Z

@bors try
@rust-timer queue

interpret: skip deref-projection validity checks when they are not needed

rust-bors · 2026-08-02T21:41:48Z

☀️ Try build successful (CI)
Build commit: fd82567 (fd825675c9cb0054bc1537dbd227fc750bc2fbaa)
Base parent: 28c66af (28c66af27578a28bc8cad1c5957be4b1e2e7fb8b)

rust-timer · 2026-08-02T22:23:28Z

Finished benchmarking commit (fd82567): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.2%, 0.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-9.2%	[-10.2%, -8.6%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.8%, secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Cycles

Results (primary -0.2%, secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	4
Regressions ❌ (secondary)	0.9%	[0.4%, 1.4%]	5
Improvements ✅ (primary)	-0.8%	[-1.0%, -0.5%]	5
Improvements ✅ (secondary)	-1.5%	[-3.4%, -0.4%]	6
All ❌✅ (primary)	-0.2%	[-1.0%, 0.6%]	9

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.376s -> 490.585s (0.04%)
Artifact size: 390.46 MiB -> 390.48 MiB (0.01%)

RalfJung · 2026-08-03T06:51:00Z

Looks like it helps, but we need to skip all the checks to regain the original performance. And I guess for Miri this just will be an actual ~5% slowdown...

@bors try
@rust-timer queue

interpret: skip deref-projection validity checks when they are not needed

…eded

rust-bors · 2026-08-03T08:57:33Z

☀️ Try build successful (CI)
Build commit: 857e16e (857e16ea6e812013b38eea7b5ecbc5162496574b)
Base parent: 65dd30f (65dd30fb9e882a7e8f0be10caca62936db2a98b8)

rust-timer · 2026-08-03T09:48:28Z

Finished benchmarking commit (857e16e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-13.1%	[-14.2%, -12.2%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.5%, secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.6%	[0.9%, 4.3%]	2
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-0.6%	[-0.9%, -0.4%]	15
All ❌✅ (primary)	1.5%	[-0.8%, 4.3%]	3

Cycles

Results (primary 0.6%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.5%, 3.1%]	6
Regressions ❌ (secondary)	1.7%	[0.5%, 3.9%]	7
Improvements ✅ (primary)	-0.5%	[-0.6%, -0.5%]	3
Improvements ✅ (secondary)	-2.3%	[-4.1%, -0.4%]	4
All ❌✅ (primary)	0.6%	[-0.6%, 3.1%]	9

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 491.898s -> 488.826s (-0.62%)
Artifact size: 391.08 MiB -> 390.47 MiB (-0.16%)

RalfJung · 2026-08-03T10:10:56Z

r? @oli-obk

rustbot · 2026-08-03T10:11:01Z

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @oli-obk, @lcnr

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

oli-obk

@bors r+

Sad about the early UB errors. Maybe some day we'll just rerun with all checks when the final value has an error?

View changes since this review

rust-bors · 2026-08-03T11:30:19Z

📌 Commit 75505d9 has been approved by oli-obk

It is now in the queue for this repository.

Kobzol · 2026-08-04T11:01:19Z

Marking as rollup=iffy, because this only affects one benchmark, and we have a lot of rollup=never PRs in the queue.

@bors rollup=iffy

…uwer Rollup of 10 perf-sensitive pull requests Successful merges: - #157281 (perf: skip irrelevant foreign impls when building the specialization graph) - #159403 (Next steps for FnDef binder changes (instantiate most FnDef binders)) - #159763 (Optimize crate resolution for large workspace) - #160033 (Speed up `EverInitializedPlaces`) - #160268 (perf: store the fulfillment engine inline in ObligationCtxt) - #160317 (perf: Cache already-checked types in the privacy visitor) - #160399 (interpret: skip deref-projection validity checks when they are not needed) - #160451 (Deduplicate target and host filesearch) - #160453 (Add fast path to `escape_string_symbol`) - #160454 (Add offload guard flags to typeck to prevent perf regressions)

Rollup merge of #160399 - RalfJung:interpret-deref-validity, r=oli-obk interpret: skip deref-projection validity checks when they are not needed Trying to claw back the perf regression from #160012. We could also, like, skip the entire check in const-eval when we don't care about validity. But the slowdown will also affect Miri so I want to first try what we can do without doing less UB checking.

JonathanBrouwer · 2026-08-05T06:40:54Z

Verifying that actual perf results after merge match expected results
@rust-timer build 6e167bd

…uwer Rollup of 10 perf-sensitive pull requests Successful merges: - rust-lang/rust#157281 (perf: skip irrelevant foreign impls when building the specialization graph) - rust-lang/rust#159403 (Next steps for FnDef binder changes (instantiate most FnDef binders)) - rust-lang/rust#159763 (Optimize crate resolution for large workspace) - rust-lang/rust#160033 (Speed up `EverInitializedPlaces`) - rust-lang/rust#160268 (perf: store the fulfillment engine inline in ObligationCtxt) - rust-lang/rust#160317 (perf: Cache already-checked types in the privacy visitor) - rust-lang/rust#160399 (interpret: skip deref-projection validity checks when they are not needed) - rust-lang/rust#160451 (Deduplicate target and host filesearch) - rust-lang/rust#160453 (Add fast path to `escape_string_symbol`) - rust-lang/rust#160454 (Add offload guard flags to typeck to prevent perf regressions)

rust-timer · 2026-08-05T12:28:34Z

Finished benchmarking commit (6e167bd): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-12.8%	[-13.9%, -11.9%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.2%, secondary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.5%, 0.8%]	7
Regressions ❌ (secondary)	0.5%	[0.4%, 0.7%]	5
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-6.0%	[-6.0%, -6.0%]	1
All ❌✅ (primary)	0.2%	[-2.3%, 0.8%]	8

Cycles

Results (primary -0.3%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.4%, 1.3%]	4
Regressions ❌ (secondary)	1.0%	[0.4%, 2.9%]	6
Improvements ✅ (primary)	-0.8%	[-1.6%, -0.5%]	7
Improvements ✅ (secondary)	-0.8%	[-1.6%, -0.4%]	8
All ❌✅ (primary)	-0.3%	[-1.6%, 1.3%]	11

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.577s -> 491.533s (0.40%)
Artifact size: 390.24 MiB -> 390.55 MiB (0.08%)

…uwer Rollup of 10 perf-sensitive pull requests Successful merges: - rust-lang/rust#157281 (perf: skip irrelevant foreign impls when building the specialization graph) - rust-lang/rust#159403 (Next steps for FnDef binder changes (instantiate most FnDef binders)) - rust-lang/rust#159763 (Optimize crate resolution for large workspace) - rust-lang/rust#160033 (Speed up `EverInitializedPlaces`) - rust-lang/rust#160268 (perf: store the fulfillment engine inline in ObligationCtxt) - rust-lang/rust#160317 (perf: Cache already-checked types in the privacy visitor) - rust-lang/rust#160399 (interpret: skip deref-projection validity checks when they are not needed) - rust-lang/rust#160451 (Deduplicate target and host filesearch) - rust-lang/rust#160453 (Add fast path to `escape_string_symbol`) - rust-lang/rust#160454 (Add offload guard flags to typeck to prevent perf regressions)

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 2, 2026

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 2, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Aug 2, 2026
Auto merge of#160399- RalfJung:interpret-deref-validity, r=<try>
fd82567
interpret: skip deref-projection validity checks when they are not needed

This comment has been minimized.
Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 2, 2026

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 3, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Aug 3, 2026
Auto merge of#160399- RalfJung:interpret-deref-validity, r=<try>
857e16e
interpret: skip deref-projection validity checks when they are not needed

This comment has been minimized.
Sign in to view

interpret: skip deref-projection validity checks when they are not ne…
e0ad63c
…eded

RalfJung force-pushed the interpret-deref-validity branch from 5023690 to b701093Compare August 3, 2026 08:17

This comment has been minimized.
Sign in to view

rustbot removed perf-regression Performance regression. S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 3, 2026

RalfJung marked this pull request as ready for review August 3, 2026 10:10

rustbot assigned oli-obk Aug 3, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 3, 2026

skip ptr-deref validity checks when validity checking is disabled
75505d9

RalfJung force-pushed the interpret-deref-validity branch from b701093 to 75505d9Compare August 3, 2026 10:11

oli-obk approved these changes Aug 3, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2026

JonathanBrouwer mentioned this pull request Aug 4, 2026
Rollup of 10 perf-sensitive pull requests #160506
Merged

rust-borsBot merged commit 015a989 into rust-lang:mainAug 4, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 4, 2026

RalfJung deleted the interpret-deref-validity branch August 5, 2026 06:28

This comment has been minimized.
Sign in to view

Uh oh!

Uh oh!

Conversation

RalfJung commented Aug 2, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RalfJung commented Aug 2, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-borsBot commented Aug 2, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Aug 2, 2026

Overall result: ❌✅ regressions and improvements - please read:

Uh oh!

RalfJung commented Aug 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-borsBot commented Aug 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-timer commented Aug 3, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

RalfJung commented Aug 3, 2026

Uh oh!

rustbot commented Aug 3, 2026

Uh oh!

oli-obk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-borsBot commented Aug 3, 2026

Uh oh!

Kobzol commented Aug 4, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Aug 5, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Aug 5, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

RalfJung commented Aug 2, 2026•
edited by rustbot
Loading

oli-obk left a comment •
edited by rustbot
Loading