Use attribute parser for deprecated attribute checking - #160459

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
obeis:check_deprecated
Aug 21, 2026
Merged

Use attribute parser for deprecated attribute checking#160459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
obeis:check_deprecated

Conversation

@obeis

@obeisobeis commented Aug 3, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

@rustbot

rustbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 3, 2026
@obeisobeis changed the title Use attribute parser for deprecated attribute checkingUse attribute parser for deprecated attribute checkingAug 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer requested changes Aug 7, 2026
View reviewed changes
Comment threadcompiler/rustc_hir/src/target.rs Outdated
Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2026
@rustbot

rustbot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 15, 2026
JonathanBrouwer
JonathanBrouwer reviewed Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer reviewed Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer reviewed Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer approved these changes Aug 20, 2026
View reviewed changes

@JonathanBrouwerJonathanBrouwer left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after that
@rustbot author

View changes since this review

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@obeis

obeis commented Aug 21, 2026

Copy link
Copy Markdown
ContributorAuthor

I have split into a separate commit.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 21, 2026
@JonathanBrouwer

JonathanBrouwer commented Aug 21, 2026•
edited
Loading

Copy link
Copy Markdown
Member

@bors r+ rollup
Thanks!

@rust-bors

rust-borsBot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

📌 Commit da0ecbb has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
6e3f459
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer mentioned this pull request Aug 21, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
9da5d16
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer mentioned this pull request Aug 21, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Auto merge of#161455- JonathanBrouwer:rollup-hQbbeP7, r=JonathanBro…
aeca481
…uwer
Rollup of 16 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@jhprattjhpratt mentioned this pull request Aug 21, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Auto merge of#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
a872286
Rollup of 20 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #161161 (proc_macro: add support for 16-bit targets)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- #160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- #160595 (Clarify `str::split_at` docs)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@rust-bors
rust-borsBot merged commit 7f9b824 into rust-lang:mainAug 21, 2026
13 checks passed
rust-borsBot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Unrolled build for#160459in rollup 161458
0ba17bc
Rollup merge of #160459 - obeis:check_deprecated, r=JonathanBrouwer
Use attribute parser for `deprecated` attribute checking
Updates #153101
r? @JonathanBrouwer
@rustbotrustbot added this to the 1.100.0 milestone Aug 21, 2026
@obeis
obeis deleted the check_deprecated branch August 21, 2026 18:44
pullBot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Aug 22, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
b4454c1
Rollup of 20 pull requests
Successful merges:
- rust-lang/rust#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang/rust#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang/rust#161161 (proc_macro: add support for 16-bit targets)
- rust-lang/rust#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang/rust#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang/rust#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang/rust#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang/rust#160595 (Clarify `str::split_at` docs)
- rust-lang/rust#160813 (Optimize linked list iterator performance)
- rust-lang/rust#161271 (doc: document safety requirements for core WTF-8)
- rust-lang/rust#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang/rust#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang/rust#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang/rust#161393 (Configure LLM policy URL for triagebot)
- rust-lang/rust#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang/rust#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang/rust#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang/rust#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang/rust#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang/rust#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
malezjaa pushed a commit to malezjaa/rust that referenced this pull request Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
b8b3ef3
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
malezjaa pushed a commit to malezjaa/rust that referenced this pull request Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
fa79d8f
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerAwaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

4 participants

@obeis@rustbot@rust-log-analyzer@JonathanBrouwer
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Use attribute parser for deprecated attribute checking - #160459
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Aug 21, 2026
Merged
Use attribute parser for deprecated attribute checking#160459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Conversation
@obeis
@obeisobeis
commented
Aug 3, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbot
rustbot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Aug 3, 2026
@obeisobeis
changed the title
Use attribute parser for deprecated attribute checkingUse attribute parser for deprecated attribute checkingAug 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer
requested changes
Aug 7, 2026
View reviewed changes
Comment threadcompiler/rustc_hir/src/target.rs
Outdated

Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 7, 2026
@rustbot
rustbot
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_ir
cc @jdonszelmann, @JonathanBrouwer
@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 15, 2026
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
approved these changes
Aug 20, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after that
@rustbot author
View changes since this review
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 20, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@obeis
obeis
commented
Aug 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I have split into a separate commit.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 21, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@bors r+ rollup

Thanks!
@rust-bors
rust-borsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit da0ecbb has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 21, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
6e3f459
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
9da5d16
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161455- JonathanBrouwer:rollup-hQbbeP7, r=JonathanBro…
aeca481
…uwer
Rollup of 16 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@jhprattjhpratt
mentioned this pull request
Aug 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
a872286
Rollup of 20 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #161161 (proc_macro: add support for 16-bit targets)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- #160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- #160595 (Clarify `str::split_at` docs)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@rust-bors
rust-borsBot
merged commit 7f9b824
into
rust-lang:mainAug 21, 2026

13 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Unrolled build for#160459in rollup 161458
0ba17bc
Rollup merge of #160459 - obeis:check_deprecated, r=JonathanBrouwer
Use attribute parser for `deprecated` attribute checking
Updates #153101
r? @JonathanBrouwer
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 21, 2026
@obeis
obeis
deleted the

check_deprecated

branch
August 21, 2026 18:44
pullBot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Aug 22, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
b4454c1
Rollup of 20 pull requests
Successful merges:
- rust-lang/rust#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang/rust#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang/rust#161161 (proc_macro: add support for 16-bit targets)
- rust-lang/rust#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang/rust#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang/rust#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang/rust#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang/rust#160595 (Clarify `str::split_at` docs)
- rust-lang/rust#160813 (Optimize linked list iterator performance)
- rust-lang/rust#161271 (doc: document safety requirements for core WTF-8)
- rust-lang/rust#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang/rust#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang/rust#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang/rust#161393 (Configure LLM policy URL for triagebot)
- rust-lang/rust#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang/rust#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang/rust#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang/rust#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang/rust#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang/rust#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
b8b3ef3
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
fa79d8f
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerAwaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

4 participants

@obeis@rustbot@rust-log-analyzer@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Use attribute parser for deprecated attribute checking - #160459
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Aug 21, 2026
Merged
Use attribute parser for deprecated attribute checking#160459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Conversation
@obeis
@obeisobeis
commented
Aug 3, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbot
rustbot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Aug 3, 2026
@obeisobeis
changed the title
Use attribute parser for deprecated attribute checkingUse attribute parser for deprecated attribute checkingAug 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer
requested changes
Aug 7, 2026
View reviewed changes
Comment threadcompiler/rustc_hir/src/target.rs
Outdated

Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 7, 2026
@rustbot
rustbot
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_ir
cc @jdonszelmann, @JonathanBrouwer
@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 15, 2026
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
approved these changes
Aug 20, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after that
@rustbot author
View changes since this review
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 20, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@obeis
obeis
commented
Aug 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I have split into a separate commit.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 21, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@bors r+ rollup

Thanks!
@rust-bors
rust-borsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit da0ecbb has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 21, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
6e3f459
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
9da5d16
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161455- JonathanBrouwer:rollup-hQbbeP7, r=JonathanBro…
aeca481
…uwer
Rollup of 16 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@jhprattjhpratt
mentioned this pull request
Aug 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
a872286
Rollup of 20 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #161161 (proc_macro: add support for 16-bit targets)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- #160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- #160595 (Clarify `str::split_at` docs)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@rust-bors
rust-borsBot
merged commit 7f9b824
into
rust-lang:mainAug 21, 2026

13 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Unrolled build for#160459in rollup 161458
0ba17bc
Rollup merge of #160459 - obeis:check_deprecated, r=JonathanBrouwer
Use attribute parser for `deprecated` attribute checking
Updates #153101
r? @JonathanBrouwer
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 21, 2026
@obeis
obeis
deleted the

check_deprecated

branch
August 21, 2026 18:44
pullBot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Aug 22, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
b4454c1
Rollup of 20 pull requests
Successful merges:
- rust-lang/rust#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang/rust#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang/rust#161161 (proc_macro: add support for 16-bit targets)
- rust-lang/rust#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang/rust#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang/rust#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang/rust#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang/rust#160595 (Clarify `str::split_at` docs)
- rust-lang/rust#160813 (Optimize linked list iterator performance)
- rust-lang/rust#161271 (doc: document safety requirements for core WTF-8)
- rust-lang/rust#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang/rust#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang/rust#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang/rust#161393 (Configure LLM policy URL for triagebot)
- rust-lang/rust#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang/rust#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang/rust#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang/rust#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang/rust#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang/rust#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
b8b3ef3
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
fa79d8f
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerAwaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

4 participants

@obeis@rustbot@rust-log-analyzer@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Use attribute parser for deprecated attribute checking - #160459
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Aug 21, 2026
Merged
Use attribute parser for deprecated attribute checking#160459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Conversation
@obeis
@obeisobeis
commented
Aug 3, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbot
rustbot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Aug 3, 2026
@obeisobeis
changed the title
Use attribute parser for deprecated attribute checkingUse attribute parser for deprecated attribute checkingAug 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer
requested changes
Aug 7, 2026
View reviewed changes
Comment threadcompiler/rustc_hir/src/target.rs
Outdated

Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 7, 2026
@rustbot
rustbot
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_ir
cc @jdonszelmann, @JonathanBrouwer
@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 15, 2026
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
approved these changes
Aug 20, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after that
@rustbot author
View changes since this review
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 20, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@obeis
obeis
commented
Aug 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I have split into a separate commit.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 21, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@bors r+ rollup

Thanks!
@rust-bors
rust-borsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit da0ecbb has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 21, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
6e3f459
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
9da5d16
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161455- JonathanBrouwer:rollup-hQbbeP7, r=JonathanBro…
aeca481
…uwer
Rollup of 16 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@jhprattjhpratt
mentioned this pull request
Aug 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
a872286
Rollup of 20 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #161161 (proc_macro: add support for 16-bit targets)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- #160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- #160595 (Clarify `str::split_at` docs)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@rust-bors
rust-borsBot
merged commit 7f9b824
into
rust-lang:mainAug 21, 2026

13 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Unrolled build for#160459in rollup 161458
0ba17bc
Rollup merge of #160459 - obeis:check_deprecated, r=JonathanBrouwer
Use attribute parser for `deprecated` attribute checking
Updates #153101
r? @JonathanBrouwer
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 21, 2026
@obeis
obeis
deleted the

check_deprecated

branch
August 21, 2026 18:44
pullBot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Aug 22, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
b4454c1
Rollup of 20 pull requests
Successful merges:
- rust-lang/rust#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang/rust#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang/rust#161161 (proc_macro: add support for 16-bit targets)
- rust-lang/rust#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang/rust#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang/rust#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang/rust#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang/rust#160595 (Clarify `str::split_at` docs)
- rust-lang/rust#160813 (Optimize linked list iterator performance)
- rust-lang/rust#161271 (doc: document safety requirements for core WTF-8)
- rust-lang/rust#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang/rust#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang/rust#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang/rust#161393 (Configure LLM policy URL for triagebot)
- rust-lang/rust#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang/rust#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang/rust#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang/rust#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang/rust#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang/rust#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
b8b3ef3
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
fa79d8f
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerAwaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

4 participants

@obeis@rustbot@rust-log-analyzer@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Use attribute parser for deprecated attribute checking - #160459
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Aug 21, 2026
Merged
Use attribute parser for deprecated attribute checking#160459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Conversation
@obeis
@obeisobeis
commented
Aug 3, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbot
rustbot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Aug 3, 2026
@obeisobeis
changed the title
Use attribute parser for deprecated attribute checkingUse attribute parser for deprecated attribute checkingAug 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer
requested changes
Aug 7, 2026
View reviewed changes
Comment threadcompiler/rustc_hir/src/target.rs
Outdated

Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 7, 2026
@rustbot
rustbot
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_ir
cc @jdonszelmann, @JonathanBrouwer
@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 15, 2026
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
approved these changes
Aug 20, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after that
@rustbot author
View changes since this review
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 20, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@obeis
obeis
commented
Aug 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I have split into a separate commit.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 21, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@bors r+ rollup

Thanks!
@rust-bors
rust-borsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit da0ecbb has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 21, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
6e3f459
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
9da5d16
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161455- JonathanBrouwer:rollup-hQbbeP7, r=JonathanBro…
aeca481
…uwer
Rollup of 16 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@jhprattjhpratt
mentioned this pull request
Aug 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
a872286
Rollup of 20 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #161161 (proc_macro: add support for 16-bit targets)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- #160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- #160595 (Clarify `str::split_at` docs)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@rust-bors
rust-borsBot
merged commit 7f9b824
into
rust-lang:mainAug 21, 2026

13 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Unrolled build for#160459in rollup 161458
0ba17bc
Rollup merge of #160459 - obeis:check_deprecated, r=JonathanBrouwer
Use attribute parser for `deprecated` attribute checking
Updates #153101
r? @JonathanBrouwer
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 21, 2026
@obeis
obeis
deleted the

check_deprecated

branch
August 21, 2026 18:44
pullBot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Aug 22, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
b4454c1
Rollup of 20 pull requests
Successful merges:
- rust-lang/rust#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang/rust#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang/rust#161161 (proc_macro: add support for 16-bit targets)
- rust-lang/rust#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang/rust#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang/rust#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang/rust#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang/rust#160595 (Clarify `str::split_at` docs)
- rust-lang/rust#160813 (Optimize linked list iterator performance)
- rust-lang/rust#161271 (doc: document safety requirements for core WTF-8)
- rust-lang/rust#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang/rust#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang/rust#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang/rust#161393 (Configure LLM policy URL for triagebot)
- rust-lang/rust#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang/rust#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang/rust#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang/rust#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang/rust#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang/rust#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
b8b3ef3
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
fa79d8f
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerAwaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

4 participants

@obeis@rustbot@rust-log-analyzer@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Use attribute parser for deprecated attribute checking - #160459
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Aug 21, 2026
Merged
Use attribute parser for deprecated attribute checking#160459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Conversation
@obeis
@obeisobeis
commented
Aug 3, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbot
rustbot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Aug 3, 2026
@obeisobeis
changed the title
Use attribute parser for deprecated attribute checkingUse attribute parser for deprecated attribute checkingAug 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer
requested changes
Aug 7, 2026
View reviewed changes
Comment threadcompiler/rustc_hir/src/target.rs
Outdated

Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 7, 2026
@rustbot
rustbot
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_ir
cc @jdonszelmann, @JonathanBrouwer
@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 15, 2026
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
approved these changes
Aug 20, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after that
@rustbot author
View changes since this review
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 20, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@obeis
obeis
commented
Aug 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I have split into a separate commit.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 21, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@bors r+ rollup

Thanks!
@rust-bors
rust-borsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit da0ecbb has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 21, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
6e3f459
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
9da5d16
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161455- JonathanBrouwer:rollup-hQbbeP7, r=JonathanBro…
aeca481
…uwer
Rollup of 16 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@jhprattjhpratt
mentioned this pull request
Aug 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
a872286
Rollup of 20 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #161161 (proc_macro: add support for 16-bit targets)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- #160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- #160595 (Clarify `str::split_at` docs)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@rust-bors
rust-borsBot
merged commit 7f9b824
into
rust-lang:mainAug 21, 2026

13 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Unrolled build for#160459in rollup 161458
0ba17bc
Rollup merge of #160459 - obeis:check_deprecated, r=JonathanBrouwer
Use attribute parser for `deprecated` attribute checking
Updates #153101
r? @JonathanBrouwer
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 21, 2026
@obeis
obeis
deleted the

check_deprecated

branch
August 21, 2026 18:44
pullBot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Aug 22, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
b4454c1
Rollup of 20 pull requests
Successful merges:
- rust-lang/rust#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang/rust#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang/rust#161161 (proc_macro: add support for 16-bit targets)
- rust-lang/rust#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang/rust#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang/rust#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang/rust#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang/rust#160595 (Clarify `str::split_at` docs)
- rust-lang/rust#160813 (Optimize linked list iterator performance)
- rust-lang/rust#161271 (doc: document safety requirements for core WTF-8)
- rust-lang/rust#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang/rust#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang/rust#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang/rust#161393 (Configure LLM policy URL for triagebot)
- rust-lang/rust#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang/rust#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang/rust#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang/rust#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang/rust#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang/rust#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
b8b3ef3
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
fa79d8f
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerAwaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

4 participants

@obeis@rustbot@rust-log-analyzer@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Use attribute parser for deprecated attribute checking - #160459
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Aug 21, 2026
Merged
Use attribute parser for deprecated attribute checking#160459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Conversation
@obeis
@obeisobeis
commented
Aug 3, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbot
rustbot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Aug 3, 2026
@obeisobeis
changed the title
Use attribute parser for deprecated attribute checkingUse attribute parser for deprecated attribute checkingAug 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer
requested changes
Aug 7, 2026
View reviewed changes
Comment threadcompiler/rustc_hir/src/target.rs
Outdated

Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 7, 2026
@rustbot
rustbot
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_ir
cc @jdonszelmann, @JonathanBrouwer
@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 15, 2026
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
approved these changes
Aug 20, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after that
@rustbot author
View changes since this review
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 20, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@obeis
obeis
commented
Aug 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I have split into a separate commit.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 21, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@bors r+ rollup

Thanks!
@rust-bors
rust-borsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit da0ecbb has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 21, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
6e3f459
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
9da5d16
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161455- JonathanBrouwer:rollup-hQbbeP7, r=JonathanBro…
aeca481
…uwer
Rollup of 16 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@jhprattjhpratt
mentioned this pull request
Aug 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
a872286
Rollup of 20 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #161161 (proc_macro: add support for 16-bit targets)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- #160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- #160595 (Clarify `str::split_at` docs)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@rust-bors
rust-borsBot
merged commit 7f9b824
into
rust-lang:mainAug 21, 2026

13 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Unrolled build for#160459in rollup 161458
0ba17bc
Rollup merge of #160459 - obeis:check_deprecated, r=JonathanBrouwer
Use attribute parser for `deprecated` attribute checking
Updates #153101
r? @JonathanBrouwer
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 21, 2026
@obeis
obeis
deleted the

check_deprecated

branch
August 21, 2026 18:44
pullBot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Aug 22, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
b4454c1
Rollup of 20 pull requests
Successful merges:
- rust-lang/rust#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang/rust#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang/rust#161161 (proc_macro: add support for 16-bit targets)
- rust-lang/rust#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang/rust#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang/rust#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang/rust#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang/rust#160595 (Clarify `str::split_at` docs)
- rust-lang/rust#160813 (Optimize linked list iterator performance)
- rust-lang/rust#161271 (doc: document safety requirements for core WTF-8)
- rust-lang/rust#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang/rust#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang/rust#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang/rust#161393 (Configure LLM policy URL for triagebot)
- rust-lang/rust#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang/rust#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang/rust#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang/rust#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang/rust#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang/rust#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
b8b3ef3
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
fa79d8f
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerAwaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

4 participants

@obeis@rustbot@rust-log-analyzer@JonathanBrouwer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Use attribute parser for deprecated attribute checking - #160459
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Aug 21, 2026
Merged
Use attribute parser for deprecated attribute checking#160459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
obeis:check_deprecated
Conversation
@obeis
@obeisobeis
commented
Aug 3, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
@rustbot
rustbot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_parsing
cc @jdonszelmann, @JonathanBrouwer
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
cc @jdonszelmann, @JonathanBrouwer
@rustbotrustbot
added

A-attributes
Area: Attributes (`#[…]`, `#![…]`)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Aug 3, 2026
@obeisobeis
changed the title
Use attribute parser for deprecated attribute checkingUse attribute parser for deprecated attribute checkingAug 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer
requested changes
Aug 7, 2026
View reviewed changes
Comment threadcompiler/rustc_hir/src/target.rs
Outdated

Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
Comment threadcompiler/rustc_attr_parsing/src/attributes/deprecation.rs
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 7, 2026
@rustbot
rustbot
commented
Aug 7, 2026

Copy link


Copy Markdown

Collaborator
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in compiler/rustc_attr_ir
cc @jdonszelmann, @JonathanBrouwer
@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 15, 2026
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
reviewed
Aug 20, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/check_attr.rs
JonathanBrouwer
JonathanBrouwer
approved these changes
Aug 20, 2026
View reviewed changes
@JonathanBrouwerJonathanBrouwer
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after that
@rustbot author
View changes since this review
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 20, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
rustbot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@obeis
obeis
commented
Aug 21, 2026

Copy link


Copy Markdown

ContributorAuthor
I have split into a separate commit.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 21, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Aug 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@bors r+ rollup

Thanks!
@rust-bors
rust-borsBot
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
📌 Commit da0ecbb has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 21, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
6e3f459
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160459- obeis:check_deprecated, r=Jonathan…
9da5d16
…Brouwer
Use attribute parser for `deprecated` attribute checking
Updates rust-lang#153101
r? @JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 21, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161455- JonathanBrouwer:rollup-hQbbeP7, r=JonathanBro…
aeca481
…uwer
Rollup of 16 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@jhprattjhpratt
mentioned this pull request
Aug 21, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Auto merge of#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
a872286
Rollup of 20 pull requests
Successful merges:
- #161259 (move some attribute related structs out of rustc_attr_ir)
- #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- #161161 (proc_macro: add support for 16-bit targets)
- #159899 ( `GenericArgs::types` triage + possible fixes)
- #160459 (Use attribute parser for `deprecated` attribute checking)
- #160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- #160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- #160595 (Clarify `str::split_at` docs)
- #160813 (Optimize linked list iterator performance)
- #161271 (doc: document safety requirements for core WTF-8)
- #161317 (LLVM 24: configure float-abi via module flag)
- #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- #161369 (Add regression test for confusing lifetime error message issue)
- #161393 (Configure LLM policy URL for triagebot)
- #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- #161410 (Fix rustdoc remapping `documentation` scope documentation)
- #161415 (Update expect messages in path docs to better follow guidelines)
- #161438 (Change triagebot backport to ping T-libs-fcp)
- #161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@rust-bors
rust-borsBot
merged commit 7f9b824
into
rust-lang:mainAug 21, 2026

13 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 21, 2026
@bors
Unrolled build for#160459in rollup 161458
0ba17bc
Rollup merge of #160459 - obeis:check_deprecated, r=JonathanBrouwer
Use attribute parser for `deprecated` attribute checking
Updates #153101
r? @JonathanBrouwer
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 21, 2026
@obeis
obeis
deleted the

check_deprecated

branch
August 21, 2026 18:44
pullBot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Aug 22, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
b4454c1
Rollup of 20 pull requests
Successful merges:
- rust-lang/rust#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang/rust#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang/rust#161161 (proc_macro: add support for 16-bit targets)
- rust-lang/rust#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang/rust#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang/rust#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang/rust#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang/rust#160595 (Clarify `str::split_at` docs)
- rust-lang/rust#160813 (Optimize linked list iterator performance)
- rust-lang/rust#161271 (doc: document safety requirements for core WTF-8)
- rust-lang/rust#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang/rust#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang/rust#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang/rust#161393 (Configure LLM policy URL for triagebot)
- rust-lang/rust#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang/rust#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang/rust#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang/rust#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang/rust#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang/rust#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
b8b3ef3
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
malezjaa pushed a commit
to malezjaa/rust
that referenced
this pull request
Aug 23, 2026
@bors@malezjaa
Auto merge ofrust-lang#161458- jhpratt:rollup-q1wVzyt, r=jhpratt
fa79d8f
Rollup of 20 pull requests
Successful merges:
- rust-lang#161259 (move some attribute related structs out of rustc_attr_ir)
- rust-lang#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
- rust-lang#161161 (proc_macro: add support for 16-bit targets)
- rust-lang#159899 ( `GenericArgs::types` triage + possible fixes)
- rust-lang#160459 (Use attribute parser for `deprecated` attribute checking)
- rust-lang#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
- rust-lang#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
- rust-lang#160595 (Clarify `str::split_at` docs)
- rust-lang#160813 (Optimize linked list iterator performance)
- rust-lang#161271 (doc: document safety requirements for core WTF-8)
- rust-lang#161317 (LLVM 24: configure float-abi via module flag)
- rust-lang#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
- rust-lang#161369 (Add regression test for confusing lifetime error message issue)
- rust-lang#161393 (Configure LLM policy URL for triagebot)
- rust-lang#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
- rust-lang#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
- rust-lang#161410 (Fix rustdoc remapping `documentation` scope documentation)
- rust-lang#161415 (Update expect messages in path docs to better follow guidelines)
- rust-lang#161438 (Change triagebot backport to ping T-libs-fcp)
- rust-lang#161442 (Add regression test for dead code on type alias used in impl self type)
Failed merges:
- rust-lang#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
implement [u8]::split_ascii_whitespace
format
fix
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerAwaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

4 participants

@obeis@rustbot@rust-log-analyzer@JonathanBrouwer