Uh oh!
There was an error while loading. Please reload this page.
Various fixes in macro code. - #1606
Closed
kevina wants to merge 7 commits into
Closed
Conversation
kevina
commented
Jan 22, 2012
ContributorAuthor
This code should't have any portability problems, but just in case can you please test it on the build bots before merging. Thanks. |
brson
commented
Jan 22, 2012
Contributor
This fixes several issues but doesn't appear to include regression tests. Can you add some compile-fail tests for the two issues this closes? They will include probably an |
kevina
commented
Jan 23, 2012
ContributorAuthor
Note: Please don't accept until I give the all clear. Want to rebase now after some more testing... |
Need a better fix, right now it is just causing even more confusion, for example in issue rust-lang#1448 and rust-lang#1387. This reverts commit 1e4de33.
This correctly fixes issue rust-lang#1362. chpos/byte_pos are now the offsets within a particular file, but rather the offsets within a virtual file with is formed by combing all of the modules within a crate. Thus, resetting them to 0 causes an overlap and hence, bogus source locations. Fixrust-lang#1362 by moving chpos/byte_pos to parse_sess so that new_parser_from_source_str has access to them and hence can chose an initial value that is not already been used in the crate. Note that the trigger for bug 1361 was that syntax/ext/expand.rs calls parse_expr_from_source_str (which calls new_parser_from_source_str) using the same codemap as the current crate (and hence causing overlap with files in the crate as new_parser_from_source_str resets the chpos/byte_pos to 0).
This involved changing the prototype for the callbacks to thread the span though. A wrapper function, fold::wrap, can be used to wrap the old style callbacks.
the replacement and not the span of the pattern variable. Fixes issue rust-lang#1448, and rust-lang#1387.
kevina
commented
Jan 23, 2012
ContributorAuthor
Okay, ready to be accepted. I fixed the bug brson pointed out on IRC and it looks like it passed the build bot build, but just in case please try it on the build-bots again accepting. |
kevina
commented
Jan 23, 2012
ContributorAuthor
Still ready to go, just rebased to fix an incorrect issue reference in the commit message. |
Although its not really needed. Without that fix, reported spans will likely be bogus if the error is within the first couple of lines (probable around 5) of that file. Thus, many of the compile-fail tests will fail due to incorrect location.
brson
commented
Jan 23, 2012
Contributor
This looks good to me. Pushing to try one last time. |
brson
commented
Jan 24, 2012
Contributor
It's in! |
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
1606: Add `if let`, `while let` and match arm inlay hints r=matklad a=SomeoneToIgnore <img width="693" alt="image" src="https://user-images.githubusercontent.com/2690773/62013363-152f1d80-b19a-11e9-90ea-07568757baa2.png"> Add more inline hints support. Looks like `while let` type inference support is missing currently, so the corresponding hint tests lack the actual results. I've also could not find a good way to distinguish between `a` and `b` pats in the following expressions: `if let Some(Test { a: None, b: y }) = &test {};` In this case we don't need to add a hint for first pat (`a: None`), since it's matched against the particular enum variant and need a hint for `y`, since it's a new variable. But both `a` and `b` are `BIND_PAT` with similar contents, so looks like there's nothing I can check for to find any differences. I don't display any hints for such cases now, to avoid confusion, but would be nice to know if there's a way to fix this behavior. Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
update trophy case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly fixes Issue #1362. Fixes#1387 and #1448.
See the bug reports and commit messages for details.
Note my work on a #rust as discussed with Graydon will depend on these commits.