Uh oh!
There was an error while loading. Please reload this page.
sort lint names in lint pass declarations - #160704
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
When adding a new lint, you'd naturally add the new lint at the bottom, and would have to deal with merge conflicts with all other PRs that also add a lint.
folkertdevforce-pushed
the
sort-lint-names
branch
from
August 7, 2026 15:56
f9c89b1 to
23442b9Comparefolkertdev
commented
Aug 7, 2026
Comment on lines
+267
to
+268
| // Depends on referenced function signatures in expressions | ||
| PtrNullChecks: PtrNullChecks, |
ContributorAuthor
There was a problem hiding this comment.
The update was made with tidy --bless, not manually. It moves the comments correctly.
ContributorAuthor
There was a problem hiding this comment.
somewhat surprisingly exactly one error message that moved across the whole test suite (I'd assume zero or many, but, whatever).
folkertdev
marked this pull request as ready for review
August 7, 2026 20:51
rustbot
commented
Aug 7, 2026
Collaborator
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JonathanBrouwer
approved these changes
Aug 8, 2026
Contributor
rust-borsBot
pushed a commit
that referenced
this pull request
Aug 8, 2026
…uwer Rollup of 12 pull requests Successful merges: - #160336 (Move attributes out of rustc_hir) - #160715 (ignore tests with the GCC backend if we can't find `libgccjit.so` for the target) - #157609 (fix: build-std on 32 bit arm with 64 bit time) - #160613 (Add regression test for unsized non-last struct field with overlapping impls) - #160658 (miri: implement more restrictive trivial-ABI checks) - #160704 (sort lint names in lint pass declarations) - #160707 (Add regression test for higher ranked fn pointer impl not general enough) - #160713 (Add regression test for #135287) - #160720 (triagebot: add ubiratan to infra-ci) - #160747 (rustc_errors: remove unused code) - #160751 (Add regression test for incremental borrowck ICE with generic const exprs) - #160753 (rustc_lint: remove unused rustc_attrs feature) Failed merges: - #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules)
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Aug 8, 2026
Rollup merge of #160704 - folkertdev:sort-lint-names, r=JonathanBrouwer sort lint names in lint pass declarations When adding a new lint, you'd naturally add the new lint at the bottom, and would have to deal with merge conflicts with all other PRs that also add a lint. Sorting the list should at least mitigate that, and is probably more readable overall.
pullBot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Aug 9, 2026
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#160336 (Move attributes out of rustc_hir) - rust-lang/rust#160715 (ignore tests with the GCC backend if we can't find `libgccjit.so` for the target) - rust-lang/rust#157609 (fix: build-std on 32 bit arm with 64 bit time) - rust-lang/rust#160613 (Add regression test for unsized non-last struct field with overlapping impls) - rust-lang/rust#160658 (miri: implement more restrictive trivial-ABI checks) - rust-lang/rust#160704 (sort lint names in lint pass declarations) - rust-lang/rust#160707 (Add regression test for higher ranked fn pointer impl not general enough) - rust-lang/rust#160713 (Add regression test for rust-lang/rust#135287) - rust-lang/rust#160720 (triagebot: add ubiratan to infra-ci) - rust-lang/rust#160747 (rustc_errors: remove unused code) - rust-lang/rust#160751 (Add regression test for incremental borrowck ICE with generic const exprs) - rust-lang/rust#160753 (rustc_lint: remove unused rustc_attrs feature) Failed merges: - rust-lang/rust#158835 (rustc_passes: lint unused `#[path]` attributes on inline modules)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding a new lint, you'd naturally add the new lint at the bottom, and would have to deal with merge conflicts with all other PRs that also add a lint. Sorting the list should at least mitigate that, and is probably more readable overall.