Rollup of 5 pull requests - #160789

Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02
Aug 9, 2026
Merged

Rollup of 5 pull requests#160789
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02

Conversation

@jhpratt

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

JonathanBrouwerand others added 13 commits July 31, 2026 13:27
…ameters, r=JohnTitor
Initial implementation of named `Fn` trait parameters
This is an initial implementation of the feature `named_fn_trait_parameters`.
This implementation is incomplete (and also marked as such) , and needs significant further changes to be implemented correctly. To keep the size of this PR managable, I propose we do this in follow-up PRs.
I've added a test that shows the current behaviour, with `FIXME` comments where the test output is currently incorrect.
Tracking issue: rust-lang#158499
Accepted RFC: rust-lang/rfcs#3955
check if len of array const arg matches the expected len of the type when lowering to valtree
When creating valtrees for arrays passed as const args in `lower_const_arg_array`, we assume the array has the correct length without actually checking the length of the arg, leading to UB at runtime (rust-lang#155168) or an ICE during CTFE (rust-lang#151079). This PR adds a check comparing the expected length of the type with the actual number of elements, similar to `lower_const_arg_tup`.
fixesrust-lang#155168
…eGomez
Add regression test for cross-crate assoc const private field leak in rustdoc
Closesrust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field
…ism, r=Mark-Simulacrum
remove old update mechanism
…=mejrs,ZuseZ4
Fix autodiff_illegal.rs test
This fixes the current CI failure: rust-lang#160761 (comment)
r? @ZuseZ4
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Aug 9, 2026
@rustbotrustbot added A-CI Area: Our Github Actions CI S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 9, 2026
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f5c9a72 has been approved by jhpratt

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026
@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Aug 9, 2026
Rollup of 5 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-*
try-job: x86_64-mingw-1
try-job: i686-msvc-*
@rust-bors

This comment has been minimized.

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 5935028 (5935028fb25fa0deb7251544b7749991f78cd2f5)
Base parent: 4667d75 (4667d75565e47ba5df36c0df598c556b543e8624)

@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2026
@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 10m 32s
Pushing 153ecc4 to main...

@rust-bors
rust-borsBot merged commit 153ecc4 into rust-lang:mainAug 9, 2026
15 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Aug 9, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#158517Initial implementation of named Fn trait parameters46acd848c6b4c8cce41d89a4da179a896261cca0 (link)
#158587check if len of array const arg matches the expected len of…0fc1b525bd79609487d8a7e985e23f98a726781e (link)
#160748Add regression test for cross-crate assoc const private fie…c0bbab77d195e1fb7b06605a04fcd1d1e78d3007 (link)
#160708remove old update mechanism4ee128bde3dcb1a049f9196306c891aea03be3c0 (link)
#160768Fix autodiff_illegal.rs testb7148e02d3248369b6c4cbf4b7b13b02579baeb3 (link)

previous master: 4667d75565

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4667d75 (parent) -> 153ecc4 (this PR)

Test differences

Show 15 test diffs

Stage 1

  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J1)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J4)
  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J4)

Stage 2

  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J5)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J5)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J5)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 153ecc4f74035b709bb3e1eb9546f1d934865042 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-i686-msvc: 1h 13m -> 1h 57m (+59.0%)
  2. dist-x86_64-msvc-alt: 1h 48m -> 2h 44m (+51.4%)
  3. x86_64-gnu: 1h 41m -> 2h 23m (+42.1%)
  4. i686-gnu-nopt-1: 1h 38m -> 2h 16m (+38.6%)
  5. dist-riscv64-linux-musl: 1h 3m -> 1h 25m (+34.8%)
  6. x86_64-gnu-llvm-21-3: 1h 17m -> 1h 40m (+29.8%)
  7. dist-x86_64-freebsd: 1h 24m -> 1h (-28.0%)
  8. dist-x86_64-musl: 1h 47m -> 2h 14m (+25.8%)
  9. i686-gnu-nopt-2: 2h 19m -> 1h 44m (-25.6%)
  10. x86_64-rust-for-linux: 51m 30s -> 38m 25s (-25.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (153ecc4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.0%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.4%[9.4%, 9.4%]1
Regressions ❌
(secondary)
3.5%[0.5%, 7.7%]7
Improvements ✅
(primary)
-1.4%[-1.4%, -1.4%]1
Improvements ✅
(secondary)
-2.1%[-4.3%, -0.5%]5
All ❌✅ (primary)4.0%[-1.4%, 9.4%]2

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
1.1%[0.4%, 4.9%]12
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-1.2%[-4.7%, -0.5%]12
All ❌✅ (primary)--0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.83s -> 458.036s (-0.17%)
Artifact size: 398.59 MiB -> 398.61 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CImerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@rust-timer@rustbot@JonathanBrouwer@sjwang05@marcoieni@zakrad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Rollup of 5 pull requests - #160789

Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02
Aug 9, 2026
Merged

Rollup of 5 pull requests#160789
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02

Conversation

@jhpratt

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

JonathanBrouwerand others added 13 commits July 31, 2026 13:27
…ameters, r=JohnTitor
Initial implementation of named `Fn` trait parameters
This is an initial implementation of the feature `named_fn_trait_parameters`.
This implementation is incomplete (and also marked as such) , and needs significant further changes to be implemented correctly. To keep the size of this PR managable, I propose we do this in follow-up PRs.
I've added a test that shows the current behaviour, with `FIXME` comments where the test output is currently incorrect.
Tracking issue: rust-lang#158499
Accepted RFC: rust-lang/rfcs#3955
check if len of array const arg matches the expected len of the type when lowering to valtree
When creating valtrees for arrays passed as const args in `lower_const_arg_array`, we assume the array has the correct length without actually checking the length of the arg, leading to UB at runtime (rust-lang#155168) or an ICE during CTFE (rust-lang#151079). This PR adds a check comparing the expected length of the type with the actual number of elements, similar to `lower_const_arg_tup`.
fixesrust-lang#155168
…eGomez
Add regression test for cross-crate assoc const private field leak in rustdoc
Closesrust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field
…ism, r=Mark-Simulacrum
remove old update mechanism
…=mejrs,ZuseZ4
Fix autodiff_illegal.rs test
This fixes the current CI failure: rust-lang#160761 (comment)
r? @ZuseZ4
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Aug 9, 2026
@rustbotrustbot added A-CI Area: Our Github Actions CI S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 9, 2026
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f5c9a72 has been approved by jhpratt

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026
@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Aug 9, 2026
Rollup of 5 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-*
try-job: x86_64-mingw-1
try-job: i686-msvc-*
@rust-bors

This comment has been minimized.

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 5935028 (5935028fb25fa0deb7251544b7749991f78cd2f5)
Base parent: 4667d75 (4667d75565e47ba5df36c0df598c556b543e8624)

@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2026
@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 10m 32s
Pushing 153ecc4 to main...

@rust-bors
rust-borsBot merged commit 153ecc4 into rust-lang:mainAug 9, 2026
15 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Aug 9, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#158517Initial implementation of named Fn trait parameters46acd848c6b4c8cce41d89a4da179a896261cca0 (link)
#158587check if len of array const arg matches the expected len of…0fc1b525bd79609487d8a7e985e23f98a726781e (link)
#160748Add regression test for cross-crate assoc const private fie…c0bbab77d195e1fb7b06605a04fcd1d1e78d3007 (link)
#160708remove old update mechanism4ee128bde3dcb1a049f9196306c891aea03be3c0 (link)
#160768Fix autodiff_illegal.rs testb7148e02d3248369b6c4cbf4b7b13b02579baeb3 (link)

previous master: 4667d75565

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4667d75 (parent) -> 153ecc4 (this PR)

Test differences

Show 15 test diffs

Stage 1

  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J1)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J4)
  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J4)

Stage 2

  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J5)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J5)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J5)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 153ecc4f74035b709bb3e1eb9546f1d934865042 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-i686-msvc: 1h 13m -> 1h 57m (+59.0%)
  2. dist-x86_64-msvc-alt: 1h 48m -> 2h 44m (+51.4%)
  3. x86_64-gnu: 1h 41m -> 2h 23m (+42.1%)
  4. i686-gnu-nopt-1: 1h 38m -> 2h 16m (+38.6%)
  5. dist-riscv64-linux-musl: 1h 3m -> 1h 25m (+34.8%)
  6. x86_64-gnu-llvm-21-3: 1h 17m -> 1h 40m (+29.8%)
  7. dist-x86_64-freebsd: 1h 24m -> 1h (-28.0%)
  8. dist-x86_64-musl: 1h 47m -> 2h 14m (+25.8%)
  9. i686-gnu-nopt-2: 2h 19m -> 1h 44m (-25.6%)
  10. x86_64-rust-for-linux: 51m 30s -> 38m 25s (-25.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (153ecc4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.0%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.4%[9.4%, 9.4%]1
Regressions ❌
(secondary)
3.5%[0.5%, 7.7%]7
Improvements ✅
(primary)
-1.4%[-1.4%, -1.4%]1
Improvements ✅
(secondary)
-2.1%[-4.3%, -0.5%]5
All ❌✅ (primary)4.0%[-1.4%, 9.4%]2

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
1.1%[0.4%, 4.9%]12
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-1.2%[-4.7%, -0.5%]12
All ❌✅ (primary)--0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.83s -> 458.036s (-0.17%)
Artifact size: 398.59 MiB -> 398.61 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CImerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@rust-timer@rustbot@JonathanBrouwer@sjwang05@marcoieni@zakrad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 5 pull requests - #160789

Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02
Aug 9, 2026
Merged

Rollup of 5 pull requests#160789
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02

Conversation

@jhpratt

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

JonathanBrouwerand others added 13 commits July 31, 2026 13:27
…ameters, r=JohnTitor
Initial implementation of named `Fn` trait parameters
This is an initial implementation of the feature `named_fn_trait_parameters`.
This implementation is incomplete (and also marked as such) , and needs significant further changes to be implemented correctly. To keep the size of this PR managable, I propose we do this in follow-up PRs.
I've added a test that shows the current behaviour, with `FIXME` comments where the test output is currently incorrect.
Tracking issue: rust-lang#158499
Accepted RFC: rust-lang/rfcs#3955
check if len of array const arg matches the expected len of the type when lowering to valtree
When creating valtrees for arrays passed as const args in `lower_const_arg_array`, we assume the array has the correct length without actually checking the length of the arg, leading to UB at runtime (rust-lang#155168) or an ICE during CTFE (rust-lang#151079). This PR adds a check comparing the expected length of the type with the actual number of elements, similar to `lower_const_arg_tup`.
fixesrust-lang#155168
…eGomez
Add regression test for cross-crate assoc const private field leak in rustdoc
Closesrust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field
…ism, r=Mark-Simulacrum
remove old update mechanism
…=mejrs,ZuseZ4
Fix autodiff_illegal.rs test
This fixes the current CI failure: rust-lang#160761 (comment)
r? @ZuseZ4
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Aug 9, 2026
@rustbotrustbot added A-CI Area: Our Github Actions CI S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 9, 2026
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f5c9a72 has been approved by jhpratt

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026
@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Aug 9, 2026
Rollup of 5 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-*
try-job: x86_64-mingw-1
try-job: i686-msvc-*
@rust-bors

This comment has been minimized.

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 5935028 (5935028fb25fa0deb7251544b7749991f78cd2f5)
Base parent: 4667d75 (4667d75565e47ba5df36c0df598c556b543e8624)

@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2026
@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 10m 32s
Pushing 153ecc4 to main...

@rust-bors
rust-borsBot merged commit 153ecc4 into rust-lang:mainAug 9, 2026
15 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Aug 9, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#158517Initial implementation of named Fn trait parameters46acd848c6b4c8cce41d89a4da179a896261cca0 (link)
#158587check if len of array const arg matches the expected len of…0fc1b525bd79609487d8a7e985e23f98a726781e (link)
#160748Add regression test for cross-crate assoc const private fie…c0bbab77d195e1fb7b06605a04fcd1d1e78d3007 (link)
#160708remove old update mechanism4ee128bde3dcb1a049f9196306c891aea03be3c0 (link)
#160768Fix autodiff_illegal.rs testb7148e02d3248369b6c4cbf4b7b13b02579baeb3 (link)

previous master: 4667d75565

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4667d75 (parent) -> 153ecc4 (this PR)

Test differences

Show 15 test diffs

Stage 1

  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J1)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J4)
  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J4)

Stage 2

  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J5)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J5)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J5)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 153ecc4f74035b709bb3e1eb9546f1d934865042 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-i686-msvc: 1h 13m -> 1h 57m (+59.0%)
  2. dist-x86_64-msvc-alt: 1h 48m -> 2h 44m (+51.4%)
  3. x86_64-gnu: 1h 41m -> 2h 23m (+42.1%)
  4. i686-gnu-nopt-1: 1h 38m -> 2h 16m (+38.6%)
  5. dist-riscv64-linux-musl: 1h 3m -> 1h 25m (+34.8%)
  6. x86_64-gnu-llvm-21-3: 1h 17m -> 1h 40m (+29.8%)
  7. dist-x86_64-freebsd: 1h 24m -> 1h (-28.0%)
  8. dist-x86_64-musl: 1h 47m -> 2h 14m (+25.8%)
  9. i686-gnu-nopt-2: 2h 19m -> 1h 44m (-25.6%)
  10. x86_64-rust-for-linux: 51m 30s -> 38m 25s (-25.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (153ecc4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.0%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.4%[9.4%, 9.4%]1
Regressions ❌
(secondary)
3.5%[0.5%, 7.7%]7
Improvements ✅
(primary)
-1.4%[-1.4%, -1.4%]1
Improvements ✅
(secondary)
-2.1%[-4.3%, -0.5%]5
All ❌✅ (primary)4.0%[-1.4%, 9.4%]2

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
1.1%[0.4%, 4.9%]12
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-1.2%[-4.7%, -0.5%]12
All ❌✅ (primary)--0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.83s -> 458.036s (-0.17%)
Artifact size: 398.59 MiB -> 398.61 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CImerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@rust-timer@rustbot@JonathanBrouwer@sjwang05@marcoieni@zakrad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 5 pull requests - #160789

Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02
Aug 9, 2026
Merged

Rollup of 5 pull requests#160789
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02

Conversation

@jhpratt

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

JonathanBrouwerand others added 13 commits July 31, 2026 13:27
…ameters, r=JohnTitor
Initial implementation of named `Fn` trait parameters
This is an initial implementation of the feature `named_fn_trait_parameters`.
This implementation is incomplete (and also marked as such) , and needs significant further changes to be implemented correctly. To keep the size of this PR managable, I propose we do this in follow-up PRs.
I've added a test that shows the current behaviour, with `FIXME` comments where the test output is currently incorrect.
Tracking issue: rust-lang#158499
Accepted RFC: rust-lang/rfcs#3955
check if len of array const arg matches the expected len of the type when lowering to valtree
When creating valtrees for arrays passed as const args in `lower_const_arg_array`, we assume the array has the correct length without actually checking the length of the arg, leading to UB at runtime (rust-lang#155168) or an ICE during CTFE (rust-lang#151079). This PR adds a check comparing the expected length of the type with the actual number of elements, similar to `lower_const_arg_tup`.
fixesrust-lang#155168
…eGomez
Add regression test for cross-crate assoc const private field leak in rustdoc
Closesrust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field
…ism, r=Mark-Simulacrum
remove old update mechanism
…=mejrs,ZuseZ4
Fix autodiff_illegal.rs test
This fixes the current CI failure: rust-lang#160761 (comment)
r? @ZuseZ4
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Aug 9, 2026
@rustbotrustbot added A-CI Area: Our Github Actions CI S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 9, 2026
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f5c9a72 has been approved by jhpratt

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026
@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Aug 9, 2026
Rollup of 5 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-*
try-job: x86_64-mingw-1
try-job: i686-msvc-*
@rust-bors

This comment has been minimized.

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 5935028 (5935028fb25fa0deb7251544b7749991f78cd2f5)
Base parent: 4667d75 (4667d75565e47ba5df36c0df598c556b543e8624)

@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2026
@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 10m 32s
Pushing 153ecc4 to main...

@rust-bors
rust-borsBot merged commit 153ecc4 into rust-lang:mainAug 9, 2026
15 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Aug 9, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#158517Initial implementation of named Fn trait parameters46acd848c6b4c8cce41d89a4da179a896261cca0 (link)
#158587check if len of array const arg matches the expected len of…0fc1b525bd79609487d8a7e985e23f98a726781e (link)
#160748Add regression test for cross-crate assoc const private fie…c0bbab77d195e1fb7b06605a04fcd1d1e78d3007 (link)
#160708remove old update mechanism4ee128bde3dcb1a049f9196306c891aea03be3c0 (link)
#160768Fix autodiff_illegal.rs testb7148e02d3248369b6c4cbf4b7b13b02579baeb3 (link)

previous master: 4667d75565

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4667d75 (parent) -> 153ecc4 (this PR)

Test differences

Show 15 test diffs

Stage 1

  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J1)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J4)
  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J4)

Stage 2

  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J5)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J5)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J5)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 153ecc4f74035b709bb3e1eb9546f1d934865042 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-i686-msvc: 1h 13m -> 1h 57m (+59.0%)
  2. dist-x86_64-msvc-alt: 1h 48m -> 2h 44m (+51.4%)
  3. x86_64-gnu: 1h 41m -> 2h 23m (+42.1%)
  4. i686-gnu-nopt-1: 1h 38m -> 2h 16m (+38.6%)
  5. dist-riscv64-linux-musl: 1h 3m -> 1h 25m (+34.8%)
  6. x86_64-gnu-llvm-21-3: 1h 17m -> 1h 40m (+29.8%)
  7. dist-x86_64-freebsd: 1h 24m -> 1h (-28.0%)
  8. dist-x86_64-musl: 1h 47m -> 2h 14m (+25.8%)
  9. i686-gnu-nopt-2: 2h 19m -> 1h 44m (-25.6%)
  10. x86_64-rust-for-linux: 51m 30s -> 38m 25s (-25.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (153ecc4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.0%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.4%[9.4%, 9.4%]1
Regressions ❌
(secondary)
3.5%[0.5%, 7.7%]7
Improvements ✅
(primary)
-1.4%[-1.4%, -1.4%]1
Improvements ✅
(secondary)
-2.1%[-4.3%, -0.5%]5
All ❌✅ (primary)4.0%[-1.4%, 9.4%]2

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
1.1%[0.4%, 4.9%]12
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-1.2%[-4.7%, -0.5%]12
All ❌✅ (primary)--0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.83s -> 458.036s (-0.17%)
Artifact size: 398.59 MiB -> 398.61 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CImerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@rust-timer@rustbot@JonathanBrouwer@sjwang05@marcoieni@zakrad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Rollup of 5 pull requests - #160789

Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02
Aug 9, 2026
Merged

Rollup of 5 pull requests#160789
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02

Conversation

@jhpratt

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

JonathanBrouwerand others added 13 commits July 31, 2026 13:27
…ameters, r=JohnTitor
Initial implementation of named `Fn` trait parameters
This is an initial implementation of the feature `named_fn_trait_parameters`.
This implementation is incomplete (and also marked as such) , and needs significant further changes to be implemented correctly. To keep the size of this PR managable, I propose we do this in follow-up PRs.
I've added a test that shows the current behaviour, with `FIXME` comments where the test output is currently incorrect.
Tracking issue: rust-lang#158499
Accepted RFC: rust-lang/rfcs#3955
check if len of array const arg matches the expected len of the type when lowering to valtree
When creating valtrees for arrays passed as const args in `lower_const_arg_array`, we assume the array has the correct length without actually checking the length of the arg, leading to UB at runtime (rust-lang#155168) or an ICE during CTFE (rust-lang#151079). This PR adds a check comparing the expected length of the type with the actual number of elements, similar to `lower_const_arg_tup`.
fixesrust-lang#155168
…eGomez
Add regression test for cross-crate assoc const private field leak in rustdoc
Closesrust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field
…ism, r=Mark-Simulacrum
remove old update mechanism
…=mejrs,ZuseZ4
Fix autodiff_illegal.rs test
This fixes the current CI failure: rust-lang#160761 (comment)
r? @ZuseZ4
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Aug 9, 2026
@rustbotrustbot added A-CI Area: Our Github Actions CI S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 9, 2026
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f5c9a72 has been approved by jhpratt

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026
@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Aug 9, 2026
Rollup of 5 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-*
try-job: x86_64-mingw-1
try-job: i686-msvc-*
@rust-bors

This comment has been minimized.

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 5935028 (5935028fb25fa0deb7251544b7749991f78cd2f5)
Base parent: 4667d75 (4667d75565e47ba5df36c0df598c556b543e8624)

@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2026
@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 10m 32s
Pushing 153ecc4 to main...

@rust-bors
rust-borsBot merged commit 153ecc4 into rust-lang:mainAug 9, 2026
15 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Aug 9, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#158517Initial implementation of named Fn trait parameters46acd848c6b4c8cce41d89a4da179a896261cca0 (link)
#158587check if len of array const arg matches the expected len of…0fc1b525bd79609487d8a7e985e23f98a726781e (link)
#160748Add regression test for cross-crate assoc const private fie…c0bbab77d195e1fb7b06605a04fcd1d1e78d3007 (link)
#160708remove old update mechanism4ee128bde3dcb1a049f9196306c891aea03be3c0 (link)
#160768Fix autodiff_illegal.rs testb7148e02d3248369b6c4cbf4b7b13b02579baeb3 (link)

previous master: 4667d75565

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4667d75 (parent) -> 153ecc4 (this PR)

Test differences

Show 15 test diffs

Stage 1

  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J1)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J4)
  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J4)

Stage 2

  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J5)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J5)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J5)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 153ecc4f74035b709bb3e1eb9546f1d934865042 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-i686-msvc: 1h 13m -> 1h 57m (+59.0%)
  2. dist-x86_64-msvc-alt: 1h 48m -> 2h 44m (+51.4%)
  3. x86_64-gnu: 1h 41m -> 2h 23m (+42.1%)
  4. i686-gnu-nopt-1: 1h 38m -> 2h 16m (+38.6%)
  5. dist-riscv64-linux-musl: 1h 3m -> 1h 25m (+34.8%)
  6. x86_64-gnu-llvm-21-3: 1h 17m -> 1h 40m (+29.8%)
  7. dist-x86_64-freebsd: 1h 24m -> 1h (-28.0%)
  8. dist-x86_64-musl: 1h 47m -> 2h 14m (+25.8%)
  9. i686-gnu-nopt-2: 2h 19m -> 1h 44m (-25.6%)
  10. x86_64-rust-for-linux: 51m 30s -> 38m 25s (-25.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (153ecc4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.0%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.4%[9.4%, 9.4%]1
Regressions ❌
(secondary)
3.5%[0.5%, 7.7%]7
Improvements ✅
(primary)
-1.4%[-1.4%, -1.4%]1
Improvements ✅
(secondary)
-2.1%[-4.3%, -0.5%]5
All ❌✅ (primary)4.0%[-1.4%, 9.4%]2

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
1.1%[0.4%, 4.9%]12
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-1.2%[-4.7%, -0.5%]12
All ❌✅ (primary)--0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.83s -> 458.036s (-0.17%)
Artifact size: 398.59 MiB -> 398.61 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CImerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@rust-timer@rustbot@JonathanBrouwer@sjwang05@marcoieni@zakrad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 5 pull requests - #160789

Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02
Aug 9, 2026
Merged

Rollup of 5 pull requests#160789
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02

Conversation

@jhpratt

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

JonathanBrouwerand others added 13 commits July 31, 2026 13:27
…ameters, r=JohnTitor
Initial implementation of named `Fn` trait parameters
This is an initial implementation of the feature `named_fn_trait_parameters`.
This implementation is incomplete (and also marked as such) , and needs significant further changes to be implemented correctly. To keep the size of this PR managable, I propose we do this in follow-up PRs.
I've added a test that shows the current behaviour, with `FIXME` comments where the test output is currently incorrect.
Tracking issue: rust-lang#158499
Accepted RFC: rust-lang/rfcs#3955
check if len of array const arg matches the expected len of the type when lowering to valtree
When creating valtrees for arrays passed as const args in `lower_const_arg_array`, we assume the array has the correct length without actually checking the length of the arg, leading to UB at runtime (rust-lang#155168) or an ICE during CTFE (rust-lang#151079). This PR adds a check comparing the expected length of the type with the actual number of elements, similar to `lower_const_arg_tup`.
fixesrust-lang#155168
…eGomez
Add regression test for cross-crate assoc const private field leak in rustdoc
Closesrust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field
…ism, r=Mark-Simulacrum
remove old update mechanism
…=mejrs,ZuseZ4
Fix autodiff_illegal.rs test
This fixes the current CI failure: rust-lang#160761 (comment)
r? @ZuseZ4
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Aug 9, 2026
@rustbotrustbot added A-CI Area: Our Github Actions CI S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 9, 2026
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f5c9a72 has been approved by jhpratt

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026
@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Aug 9, 2026
Rollup of 5 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-*
try-job: x86_64-mingw-1
try-job: i686-msvc-*
@rust-bors

This comment has been minimized.

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 5935028 (5935028fb25fa0deb7251544b7749991f78cd2f5)
Base parent: 4667d75 (4667d75565e47ba5df36c0df598c556b543e8624)

@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2026
@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 10m 32s
Pushing 153ecc4 to main...

@rust-bors
rust-borsBot merged commit 153ecc4 into rust-lang:mainAug 9, 2026
15 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Aug 9, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#158517Initial implementation of named Fn trait parameters46acd848c6b4c8cce41d89a4da179a896261cca0 (link)
#158587check if len of array const arg matches the expected len of…0fc1b525bd79609487d8a7e985e23f98a726781e (link)
#160748Add regression test for cross-crate assoc const private fie…c0bbab77d195e1fb7b06605a04fcd1d1e78d3007 (link)
#160708remove old update mechanism4ee128bde3dcb1a049f9196306c891aea03be3c0 (link)
#160768Fix autodiff_illegal.rs testb7148e02d3248369b6c4cbf4b7b13b02579baeb3 (link)

previous master: 4667d75565

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4667d75 (parent) -> 153ecc4 (this PR)

Test differences

Show 15 test diffs

Stage 1

  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J1)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J4)
  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J4)

Stage 2

  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J5)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J5)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J5)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 153ecc4f74035b709bb3e1eb9546f1d934865042 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-i686-msvc: 1h 13m -> 1h 57m (+59.0%)
  2. dist-x86_64-msvc-alt: 1h 48m -> 2h 44m (+51.4%)
  3. x86_64-gnu: 1h 41m -> 2h 23m (+42.1%)
  4. i686-gnu-nopt-1: 1h 38m -> 2h 16m (+38.6%)
  5. dist-riscv64-linux-musl: 1h 3m -> 1h 25m (+34.8%)
  6. x86_64-gnu-llvm-21-3: 1h 17m -> 1h 40m (+29.8%)
  7. dist-x86_64-freebsd: 1h 24m -> 1h (-28.0%)
  8. dist-x86_64-musl: 1h 47m -> 2h 14m (+25.8%)
  9. i686-gnu-nopt-2: 2h 19m -> 1h 44m (-25.6%)
  10. x86_64-rust-for-linux: 51m 30s -> 38m 25s (-25.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (153ecc4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.0%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.4%[9.4%, 9.4%]1
Regressions ❌
(secondary)
3.5%[0.5%, 7.7%]7
Improvements ✅
(primary)
-1.4%[-1.4%, -1.4%]1
Improvements ✅
(secondary)
-2.1%[-4.3%, -0.5%]5
All ❌✅ (primary)4.0%[-1.4%, 9.4%]2

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
1.1%[0.4%, 4.9%]12
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-1.2%[-4.7%, -0.5%]12
All ❌✅ (primary)--0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.83s -> 458.036s (-0.17%)
Artifact size: 398.59 MiB -> 398.61 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CImerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@rust-timer@rustbot@JonathanBrouwer@sjwang05@marcoieni@zakrad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 5 pull requests - #160789

Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02
Aug 9, 2026
Merged

Rollup of 5 pull requests#160789
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02

Conversation

@jhpratt

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

JonathanBrouwerand others added 13 commits July 31, 2026 13:27
…ameters, r=JohnTitor
Initial implementation of named `Fn` trait parameters
This is an initial implementation of the feature `named_fn_trait_parameters`.
This implementation is incomplete (and also marked as such) , and needs significant further changes to be implemented correctly. To keep the size of this PR managable, I propose we do this in follow-up PRs.
I've added a test that shows the current behaviour, with `FIXME` comments where the test output is currently incorrect.
Tracking issue: rust-lang#158499
Accepted RFC: rust-lang/rfcs#3955
check if len of array const arg matches the expected len of the type when lowering to valtree
When creating valtrees for arrays passed as const args in `lower_const_arg_array`, we assume the array has the correct length without actually checking the length of the arg, leading to UB at runtime (rust-lang#155168) or an ICE during CTFE (rust-lang#151079). This PR adds a check comparing the expected length of the type with the actual number of elements, similar to `lower_const_arg_tup`.
fixesrust-lang#155168
…eGomez
Add regression test for cross-crate assoc const private field leak in rustdoc
Closesrust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field
…ism, r=Mark-Simulacrum
remove old update mechanism
…=mejrs,ZuseZ4
Fix autodiff_illegal.rs test
This fixes the current CI failure: rust-lang#160761 (comment)
r? @ZuseZ4
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Aug 9, 2026
@rustbotrustbot added A-CI Area: Our Github Actions CI S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 9, 2026
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f5c9a72 has been approved by jhpratt

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026
@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Aug 9, 2026
Rollup of 5 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-*
try-job: x86_64-mingw-1
try-job: i686-msvc-*
@rust-bors

This comment has been minimized.

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 5935028 (5935028fb25fa0deb7251544b7749991f78cd2f5)
Base parent: 4667d75 (4667d75565e47ba5df36c0df598c556b543e8624)

@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2026
@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 10m 32s
Pushing 153ecc4 to main...

@rust-bors
rust-borsBot merged commit 153ecc4 into rust-lang:mainAug 9, 2026
15 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Aug 9, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#158517Initial implementation of named Fn trait parameters46acd848c6b4c8cce41d89a4da179a896261cca0 (link)
#158587check if len of array const arg matches the expected len of…0fc1b525bd79609487d8a7e985e23f98a726781e (link)
#160748Add regression test for cross-crate assoc const private fie…c0bbab77d195e1fb7b06605a04fcd1d1e78d3007 (link)
#160708remove old update mechanism4ee128bde3dcb1a049f9196306c891aea03be3c0 (link)
#160768Fix autodiff_illegal.rs testb7148e02d3248369b6c4cbf4b7b13b02579baeb3 (link)

previous master: 4667d75565

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4667d75 (parent) -> 153ecc4 (this PR)

Test differences

Show 15 test diffs

Stage 1

  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J1)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J4)
  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J4)

Stage 2

  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J5)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J5)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J5)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 153ecc4f74035b709bb3e1eb9546f1d934865042 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-i686-msvc: 1h 13m -> 1h 57m (+59.0%)
  2. dist-x86_64-msvc-alt: 1h 48m -> 2h 44m (+51.4%)
  3. x86_64-gnu: 1h 41m -> 2h 23m (+42.1%)
  4. i686-gnu-nopt-1: 1h 38m -> 2h 16m (+38.6%)
  5. dist-riscv64-linux-musl: 1h 3m -> 1h 25m (+34.8%)
  6. x86_64-gnu-llvm-21-3: 1h 17m -> 1h 40m (+29.8%)
  7. dist-x86_64-freebsd: 1h 24m -> 1h (-28.0%)
  8. dist-x86_64-musl: 1h 47m -> 2h 14m (+25.8%)
  9. i686-gnu-nopt-2: 2h 19m -> 1h 44m (-25.6%)
  10. x86_64-rust-for-linux: 51m 30s -> 38m 25s (-25.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (153ecc4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.0%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.4%[9.4%, 9.4%]1
Regressions ❌
(secondary)
3.5%[0.5%, 7.7%]7
Improvements ✅
(primary)
-1.4%[-1.4%, -1.4%]1
Improvements ✅
(secondary)
-2.1%[-4.3%, -0.5%]5
All ❌✅ (primary)4.0%[-1.4%, 9.4%]2

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
1.1%[0.4%, 4.9%]12
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-1.2%[-4.7%, -0.5%]12
All ❌✅ (primary)--0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.83s -> 458.036s (-0.17%)
Artifact size: 398.59 MiB -> 398.61 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CImerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@rust-timer@rustbot@JonathanBrouwer@sjwang05@marcoieni@zakrad
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Rollup of 5 pull requests - #160789

Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02
Aug 9, 2026
Merged

Rollup of 5 pull requests#160789
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
jhpratt:rollup-zFeRr02

Conversation

@jhpratt

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

JonathanBrouwerand others added 13 commits July 31, 2026 13:27
…ameters, r=JohnTitor
Initial implementation of named `Fn` trait parameters
This is an initial implementation of the feature `named_fn_trait_parameters`.
This implementation is incomplete (and also marked as such) , and needs significant further changes to be implemented correctly. To keep the size of this PR managable, I propose we do this in follow-up PRs.
I've added a test that shows the current behaviour, with `FIXME` comments where the test output is currently incorrect.
Tracking issue: rust-lang#158499
Accepted RFC: rust-lang/rfcs#3955
check if len of array const arg matches the expected len of the type when lowering to valtree
When creating valtrees for arrays passed as const args in `lower_const_arg_array`, we assume the array has the correct length without actually checking the length of the arg, leading to UB at runtime (rust-lang#155168) or an ICE during CTFE (rust-lang#151079). This PR adds a check comparing the expected length of the type with the actual number of elements, similar to `lower_const_arg_tup`.
fixesrust-lang#155168
…eGomez
Add regression test for cross-crate assoc const private field leak in rustdoc
Closesrust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field
…ism, r=Mark-Simulacrum
remove old update mechanism
…=mejrs,ZuseZ4
Fix autodiff_illegal.rs test
This fixes the current CI failure: rust-lang#160761 (comment)
r? @ZuseZ4
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Aug 9, 2026
@rustbotrustbot added A-CI Area: Our Github Actions CI S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 9, 2026
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f5c9a72 has been approved by jhpratt

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2026
@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Aug 9, 2026
Rollup of 5 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-*
try-job: x86_64-mingw-1
try-job: i686-msvc-*
@rust-bors

This comment has been minimized.

@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 5935028 (5935028fb25fa0deb7251544b7749991f78cd2f5)
Base parent: 4667d75 (4667d75565e47ba5df36c0df598c556b543e8624)

@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2026
@rust-bors

rust-borsBot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 10m 32s
Pushing 153ecc4 to main...

@rust-bors
rust-borsBot merged commit 153ecc4 into rust-lang:mainAug 9, 2026
15 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Aug 9, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#158517Initial implementation of named Fn trait parameters46acd848c6b4c8cce41d89a4da179a896261cca0 (link)
#158587check if len of array const arg matches the expected len of…0fc1b525bd79609487d8a7e985e23f98a726781e (link)
#160748Add regression test for cross-crate assoc const private fie…c0bbab77d195e1fb7b06605a04fcd1d1e78d3007 (link)
#160708remove old update mechanism4ee128bde3dcb1a049f9196306c891aea03be3c0 (link)
#160768Fix autodiff_illegal.rs testb7148e02d3248369b6c4cbf4b7b13b02579baeb3 (link)

previous master: 4667d75565

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4667d75 (parent) -> 153ecc4 (this PR)

Test differences

Show 15 test diffs

Stage 1

  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J1)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J1)
  • [ui (polonius)] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [ui (polonius)] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J4)
  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J4)

Stage 2

  • [rustdoc-html] tests/rustdoc-html/inline_cross/assoc-const-private-fields-99630.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/160553.rs: [missing] -> pass (J2)
  • [ui] tests/ui/const-generics/mgca/array-const-arg-len-mismatch.rs: [missing] -> pass (J5)
  • [ui] tests/ui/feature-gates/feature-gate-named-fn-trait-parameters.rs: [missing] -> pass (J5)
  • [ui] tests/ui/fn/named-fn-trait-parameters.rs: [missing] -> pass (J5)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 153ecc4f74035b709bb3e1eb9546f1d934865042 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-i686-msvc: 1h 13m -> 1h 57m (+59.0%)
  2. dist-x86_64-msvc-alt: 1h 48m -> 2h 44m (+51.4%)
  3. x86_64-gnu: 1h 41m -> 2h 23m (+42.1%)
  4. i686-gnu-nopt-1: 1h 38m -> 2h 16m (+38.6%)
  5. dist-riscv64-linux-musl: 1h 3m -> 1h 25m (+34.8%)
  6. x86_64-gnu-llvm-21-3: 1h 17m -> 1h 40m (+29.8%)
  7. dist-x86_64-freebsd: 1h 24m -> 1h (-28.0%)
  8. dist-x86_64-musl: 1h 47m -> 2h 14m (+25.8%)
  9. i686-gnu-nopt-2: 2h 19m -> 1h 44m (-25.6%)
  10. x86_64-rust-for-linux: 51m 30s -> 38m 25s (-25.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (153ecc4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.0%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.4%[9.4%, 9.4%]1
Regressions ❌
(secondary)
3.5%[0.5%, 7.7%]7
Improvements ✅
(primary)
-1.4%[-1.4%, -1.4%]1
Improvements ✅
(secondary)
-2.1%[-4.3%, -0.5%]5
All ❌✅ (primary)4.0%[-1.4%, 9.4%]2

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
1.1%[0.4%, 4.9%]12
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-1.2%[-4.7%, -0.5%]12
All ❌✅ (primary)--0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 458.83s -> 458.036s (-0.17%)
Artifact size: 398.59 MiB -> 398.61 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CImerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@rust-timer@rustbot@JonathanBrouwer@sjwang05@marcoieni@zakrad