Add basic `splat` support to `rustdoc` by bushrat011899 · Pull Request #160882 · rust-lang/rust

bushrat011899 · 2026-08-10T23:37:46Z

Tracking Issue: #153629

Description

While experimenting on variadic min/max, it was noted that the rustdoc output for a splatted function is less than ideal. Consider the below:

pubfnsmallest<T:Ord>(#[rustc_splat]vals:implTupleReduce<Item = T>) -> T{// ...}

Currently, this is rendered in rustdoc as-is, obfuscating the variadic nature of the function:

Solution

I've updated the clean Parameter type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed.

Notes

No AI tooling of any kind was used during the creation of this PR.

rustbot · 2026-08-10T23:37:51Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 8 candidates
Random selection from GuillaumeGomez, lolbinarycat, notriddle

bushrat011899 · 2026-08-10T23:50:15Z

@rustbot label F-splat

GuillaumeGomez · 2026-08-11T09:06:38Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

bushrat011899 · 2026-08-11T09:33:32Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

Done! Sorry I should've included that initially, haven't contributed to rustdoc before! I swapped the … with args to confirm the test fails as well.

notriddle · 2026-08-11T14:59:44Z

r? @GuillaumeGomez

rustbot · 2026-08-11T14:59:47Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

GuillaumeGomez · 2026-08-11T22:33:25Z

Looks good to me, thanks! r=me once CI pass.

@bors delegate+

rust-bors · 2026-08-11T22:33:28Z

✌️ @bushrat011899, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, then please make that change and post @bors r=GuillaumeGomez.

View changes since this delegation.

bushrat011899 · 2026-08-11T23:50:20Z

@bors r=GuillaumeGomez

rust-bors · 2026-08-11T23:50:23Z

📌 Commit 413fdca has been approved by GuillaumeGomez

It is now in the queue for this repository.

Rollup of 14 pull requests Successful merges: - #160620 (Do not pass `-no-pie` on Windows) - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - #160854 (Add -Zwasm-proc-macros flag) - #160868 (std: Adjust cfgs again for TLS on WASI) - #160882 (Add basic `splat` support to `rustdoc`) - #160894 (Allow running an arbitrary number of try jobs per PR) - #160790 (rustc-book: update sys-v abi link) - #160878 (Add rust_analyzer to check-cfg names) - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - #160920 (No longer mention the removed generic) - #160921 (rustdoc: Fix invalid CSS classes generated for notable items) - #160924 (split up `rustc_session`) - #160934 (Ensure TLS accesses don't call the global allocator through panic) - #160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

Rollup merge of #160882 - bushrat011899:rustdoc_splat_ellipsis, r=GuillaumeGomez Add basic `splat` support to `rustdoc` Tracking Issue: #153629 # Description While experimenting on variadic `min`/`max`, it was [noted](rust-lang/libs-team#848 (comment)) that the `rustdoc` output for a splatted function is less than ideal. Consider the below: ```rust pub fn smallest<T: Ord>(#[rustc_splat] vals: impl TupleReduce<Item = T>) -> T { // ... } ``` Currently, this is rendered in `rustdoc` as-is, obfuscating the variadic nature of the function: <img width="819" height="211" alt="image" src="https://github.com/user-attachments/assets/68569fe6-7285-49f8-aae9-ddad0b10649c" /> ## Solution I've updated the clean `Parameter` type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed. <img width="820" height="211" alt="image" src="https://github.com/user-attachments/assets/58a27245-cc38-44e6-908a-f67991bcdb64" /> --- ## Notes * No AI tooling of any kind was used during the creation of this PR.

Rollup of 14 pull requests Successful merges: - rust-lang/rust#160620 (Do not pass `-no-pie` on Windows) - rust-lang/rust#160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - rust-lang/rust#160854 (Add -Zwasm-proc-macros flag) - rust-lang/rust#160868 (std: Adjust cfgs again for TLS on WASI) - rust-lang/rust#160882 (Add basic `splat` support to `rustdoc`) - rust-lang/rust#160894 (Allow running an arbitrary number of try jobs per PR) - rust-lang/rust#160790 (rustc-book: update sys-v abi link) - rust-lang/rust#160878 (Add rust_analyzer to check-cfg names) - rust-lang/rust#160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - rust-lang/rust#160920 (No longer mention the removed generic) - rust-lang/rust#160921 (rustdoc: Fix invalid CSS classes generated for notable items) - rust-lang/rust#160924 (split up `rustc_session`) - rust-lang/rust#160934 (Ensure TLS accesses don't call the global allocator through panic) - rust-lang/rust#160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

bushrat011899 · 2026-08-10T23:37:46Z

Tracking Issue: #153629

Description

While experimenting on variadic min/max, it was noted that the rustdoc output for a splatted function is less than ideal. Consider the below:

pubfnsmallest<T:Ord>(#[rustc_splat]vals:implTupleReduce<Item = T>) -> T{// ...}

Currently, this is rendered in rustdoc as-is, obfuscating the variadic nature of the function:

Solution

I've updated the clean Parameter type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed.

Notes

No AI tooling of any kind was used during the creation of this PR.

rustbot · 2026-08-10T23:37:51Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 8 candidates
Random selection from GuillaumeGomez, lolbinarycat, notriddle

bushrat011899 · 2026-08-10T23:50:15Z

@rustbot label F-splat

GuillaumeGomez · 2026-08-11T09:06:38Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

bushrat011899 · 2026-08-11T09:33:32Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

Done! Sorry I should've included that initially, haven't contributed to rustdoc before! I swapped the … with args to confirm the test fails as well.

notriddle · 2026-08-11T14:59:44Z

r? @GuillaumeGomez

rustbot · 2026-08-11T14:59:47Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

GuillaumeGomez · 2026-08-11T22:33:25Z

Looks good to me, thanks! r=me once CI pass.

@bors delegate+

rust-bors · 2026-08-11T22:33:28Z

✌️ @bushrat011899, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, then please make that change and post @bors r=GuillaumeGomez.

View changes since this delegation.

bushrat011899 · 2026-08-11T23:50:20Z

@bors r=GuillaumeGomez

rust-bors · 2026-08-11T23:50:23Z

📌 Commit 413fdca has been approved by GuillaumeGomez

It is now in the queue for this repository.

Rollup of 14 pull requests Successful merges: - #160620 (Do not pass `-no-pie` on Windows) - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - #160854 (Add -Zwasm-proc-macros flag) - #160868 (std: Adjust cfgs again for TLS on WASI) - #160882 (Add basic `splat` support to `rustdoc`) - #160894 (Allow running an arbitrary number of try jobs per PR) - #160790 (rustc-book: update sys-v abi link) - #160878 (Add rust_analyzer to check-cfg names) - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - #160920 (No longer mention the removed generic) - #160921 (rustdoc: Fix invalid CSS classes generated for notable items) - #160924 (split up `rustc_session`) - #160934 (Ensure TLS accesses don't call the global allocator through panic) - #160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

Rollup merge of #160882 - bushrat011899:rustdoc_splat_ellipsis, r=GuillaumeGomez Add basic `splat` support to `rustdoc` Tracking Issue: #153629 # Description While experimenting on variadic `min`/`max`, it was [noted](rust-lang/libs-team#848 (comment)) that the `rustdoc` output for a splatted function is less than ideal. Consider the below: ```rust pub fn smallest<T: Ord>(#[rustc_splat] vals: impl TupleReduce<Item = T>) -> T { // ... } ``` Currently, this is rendered in `rustdoc` as-is, obfuscating the variadic nature of the function: <img width="819" height="211" alt="image" src="https://github.com/user-attachments/assets/68569fe6-7285-49f8-aae9-ddad0b10649c" /> ## Solution I've updated the clean `Parameter` type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed. <img width="820" height="211" alt="image" src="https://github.com/user-attachments/assets/58a27245-cc38-44e6-908a-f67991bcdb64" /> --- ## Notes * No AI tooling of any kind was used during the creation of this PR.

Rollup of 14 pull requests Successful merges: - rust-lang/rust#160620 (Do not pass `-no-pie` on Windows) - rust-lang/rust#160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - rust-lang/rust#160854 (Add -Zwasm-proc-macros flag) - rust-lang/rust#160868 (std: Adjust cfgs again for TLS on WASI) - rust-lang/rust#160882 (Add basic `splat` support to `rustdoc`) - rust-lang/rust#160894 (Allow running an arbitrary number of try jobs per PR) - rust-lang/rust#160790 (rustc-book: update sys-v abi link) - rust-lang/rust#160878 (Add rust_analyzer to check-cfg names) - rust-lang/rust#160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - rust-lang/rust#160920 (No longer mention the removed generic) - rust-lang/rust#160921 (rustdoc: Fix invalid CSS classes generated for notable items) - rust-lang/rust#160924 (split up `rustc_session`) - rust-lang/rust#160934 (Ensure TLS accesses don't call the global allocator through panic) - rust-lang/rust#160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

bushrat011899 · 2026-08-10T23:37:46Z

Tracking Issue: #153629

Description

While experimenting on variadic min/max, it was noted that the rustdoc output for a splatted function is less than ideal. Consider the below:

pubfnsmallest<T:Ord>(#[rustc_splat]vals:implTupleReduce<Item = T>) -> T{// ...}

Currently, this is rendered in rustdoc as-is, obfuscating the variadic nature of the function:

Solution

I've updated the clean Parameter type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed.

Notes

No AI tooling of any kind was used during the creation of this PR.

rustbot · 2026-08-10T23:37:51Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 8 candidates
Random selection from GuillaumeGomez, lolbinarycat, notriddle

bushrat011899 · 2026-08-10T23:50:15Z

@rustbot label F-splat

GuillaumeGomez · 2026-08-11T09:06:38Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

bushrat011899 · 2026-08-11T09:33:32Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

Done! Sorry I should've included that initially, haven't contributed to rustdoc before! I swapped the … with args to confirm the test fails as well.

notriddle · 2026-08-11T14:59:44Z

r? @GuillaumeGomez

rustbot · 2026-08-11T14:59:47Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

GuillaumeGomez · 2026-08-11T22:33:25Z

Looks good to me, thanks! r=me once CI pass.

@bors delegate+

rust-bors · 2026-08-11T22:33:28Z

✌️ @bushrat011899, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, then please make that change and post @bors r=GuillaumeGomez.

View changes since this delegation.

bushrat011899 · 2026-08-11T23:50:20Z

@bors r=GuillaumeGomez

rust-bors · 2026-08-11T23:50:23Z

📌 Commit 413fdca has been approved by GuillaumeGomez

It is now in the queue for this repository.

Rollup of 14 pull requests Successful merges: - #160620 (Do not pass `-no-pie` on Windows) - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - #160854 (Add -Zwasm-proc-macros flag) - #160868 (std: Adjust cfgs again for TLS on WASI) - #160882 (Add basic `splat` support to `rustdoc`) - #160894 (Allow running an arbitrary number of try jobs per PR) - #160790 (rustc-book: update sys-v abi link) - #160878 (Add rust_analyzer to check-cfg names) - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - #160920 (No longer mention the removed generic) - #160921 (rustdoc: Fix invalid CSS classes generated for notable items) - #160924 (split up `rustc_session`) - #160934 (Ensure TLS accesses don't call the global allocator through panic) - #160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

Rollup merge of #160882 - bushrat011899:rustdoc_splat_ellipsis, r=GuillaumeGomez Add basic `splat` support to `rustdoc` Tracking Issue: #153629 # Description While experimenting on variadic `min`/`max`, it was [noted](rust-lang/libs-team#848 (comment)) that the `rustdoc` output for a splatted function is less than ideal. Consider the below: ```rust pub fn smallest<T: Ord>(#[rustc_splat] vals: impl TupleReduce<Item = T>) -> T { // ... } ``` Currently, this is rendered in `rustdoc` as-is, obfuscating the variadic nature of the function: <img width="819" height="211" alt="image" src="https://github.com/user-attachments/assets/68569fe6-7285-49f8-aae9-ddad0b10649c" /> ## Solution I've updated the clean `Parameter` type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed. <img width="820" height="211" alt="image" src="https://github.com/user-attachments/assets/58a27245-cc38-44e6-908a-f67991bcdb64" /> --- ## Notes * No AI tooling of any kind was used during the creation of this PR.

Rollup of 14 pull requests Successful merges: - rust-lang/rust#160620 (Do not pass `-no-pie` on Windows) - rust-lang/rust#160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - rust-lang/rust#160854 (Add -Zwasm-proc-macros flag) - rust-lang/rust#160868 (std: Adjust cfgs again for TLS on WASI) - rust-lang/rust#160882 (Add basic `splat` support to `rustdoc`) - rust-lang/rust#160894 (Allow running an arbitrary number of try jobs per PR) - rust-lang/rust#160790 (rustc-book: update sys-v abi link) - rust-lang/rust#160878 (Add rust_analyzer to check-cfg names) - rust-lang/rust#160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - rust-lang/rust#160920 (No longer mention the removed generic) - rust-lang/rust#160921 (rustdoc: Fix invalid CSS classes generated for notable items) - rust-lang/rust#160924 (split up `rustc_session`) - rust-lang/rust#160934 (Ensure TLS accesses don't call the global allocator through panic) - rust-lang/rust#160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

bushrat011899 · 2026-08-10T23:37:46Z

Tracking Issue: #153629

Description

While experimenting on variadic min/max, it was noted that the rustdoc output for a splatted function is less than ideal. Consider the below:

pubfnsmallest<T:Ord>(#[rustc_splat]vals:implTupleReduce<Item = T>) -> T{// ...}

Currently, this is rendered in rustdoc as-is, obfuscating the variadic nature of the function:

Solution

I've updated the clean Parameter type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed.

Notes

No AI tooling of any kind was used during the creation of this PR.

rustbot · 2026-08-10T23:37:51Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 8 candidates
Random selection from GuillaumeGomez, lolbinarycat, notriddle

bushrat011899 · 2026-08-10T23:50:15Z

@rustbot label F-splat

GuillaumeGomez · 2026-08-11T09:06:38Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

bushrat011899 · 2026-08-11T09:33:32Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

Done! Sorry I should've included that initially, haven't contributed to rustdoc before! I swapped the … with args to confirm the test fails as well.

notriddle · 2026-08-11T14:59:44Z

r? @GuillaumeGomez

rustbot · 2026-08-11T14:59:47Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

GuillaumeGomez · 2026-08-11T22:33:25Z

Looks good to me, thanks! r=me once CI pass.

@bors delegate+

rust-bors · 2026-08-11T22:33:28Z

✌️ @bushrat011899, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, then please make that change and post @bors r=GuillaumeGomez.

View changes since this delegation.

bushrat011899 · 2026-08-11T23:50:20Z

@bors r=GuillaumeGomez

rust-bors · 2026-08-11T23:50:23Z

📌 Commit 413fdca has been approved by GuillaumeGomez

It is now in the queue for this repository.

Rollup of 14 pull requests Successful merges: - #160620 (Do not pass `-no-pie` on Windows) - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - #160854 (Add -Zwasm-proc-macros flag) - #160868 (std: Adjust cfgs again for TLS on WASI) - #160882 (Add basic `splat` support to `rustdoc`) - #160894 (Allow running an arbitrary number of try jobs per PR) - #160790 (rustc-book: update sys-v abi link) - #160878 (Add rust_analyzer to check-cfg names) - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - #160920 (No longer mention the removed generic) - #160921 (rustdoc: Fix invalid CSS classes generated for notable items) - #160924 (split up `rustc_session`) - #160934 (Ensure TLS accesses don't call the global allocator through panic) - #160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

Rollup merge of #160882 - bushrat011899:rustdoc_splat_ellipsis, r=GuillaumeGomez Add basic `splat` support to `rustdoc` Tracking Issue: #153629 # Description While experimenting on variadic `min`/`max`, it was [noted](rust-lang/libs-team#848 (comment)) that the `rustdoc` output for a splatted function is less than ideal. Consider the below: ```rust pub fn smallest<T: Ord>(#[rustc_splat] vals: impl TupleReduce<Item = T>) -> T { // ... } ``` Currently, this is rendered in `rustdoc` as-is, obfuscating the variadic nature of the function: <img width="819" height="211" alt="image" src="https://github.com/user-attachments/assets/68569fe6-7285-49f8-aae9-ddad0b10649c" /> ## Solution I've updated the clean `Parameter` type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed. <img width="820" height="211" alt="image" src="https://github.com/user-attachments/assets/58a27245-cc38-44e6-908a-f67991bcdb64" /> --- ## Notes * No AI tooling of any kind was used during the creation of this PR.

Rollup of 14 pull requests Successful merges: - rust-lang/rust#160620 (Do not pass `-no-pie` on Windows) - rust-lang/rust#160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - rust-lang/rust#160854 (Add -Zwasm-proc-macros flag) - rust-lang/rust#160868 (std: Adjust cfgs again for TLS on WASI) - rust-lang/rust#160882 (Add basic `splat` support to `rustdoc`) - rust-lang/rust#160894 (Allow running an arbitrary number of try jobs per PR) - rust-lang/rust#160790 (rustc-book: update sys-v abi link) - rust-lang/rust#160878 (Add rust_analyzer to check-cfg names) - rust-lang/rust#160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - rust-lang/rust#160920 (No longer mention the removed generic) - rust-lang/rust#160921 (rustdoc: Fix invalid CSS classes generated for notable items) - rust-lang/rust#160924 (split up `rustc_session`) - rust-lang/rust#160934 (Ensure TLS accesses don't call the global allocator through panic) - rust-lang/rust#160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

bushrat011899 · 2026-08-10T23:37:46Z

Tracking Issue: #153629

Description

While experimenting on variadic min/max, it was noted that the rustdoc output for a splatted function is less than ideal. Consider the below:

pubfnsmallest<T:Ord>(#[rustc_splat]vals:implTupleReduce<Item = T>) -> T{// ...}

Currently, this is rendered in rustdoc as-is, obfuscating the variadic nature of the function:

Solution

I've updated the clean Parameter type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed.

Notes

No AI tooling of any kind was used during the creation of this PR.

rustbot · 2026-08-10T23:37:51Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 8 candidates
Random selection from GuillaumeGomez, lolbinarycat, notriddle

bushrat011899 · 2026-08-10T23:50:15Z

@rustbot label F-splat

GuillaumeGomez · 2026-08-11T09:06:38Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

bushrat011899 · 2026-08-11T09:33:32Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

Done! Sorry I should've included that initially, haven't contributed to rustdoc before! I swapped the … with args to confirm the test fails as well.

notriddle · 2026-08-11T14:59:44Z

r? @GuillaumeGomez

rustbot · 2026-08-11T14:59:47Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

GuillaumeGomez · 2026-08-11T22:33:25Z

Looks good to me, thanks! r=me once CI pass.

@bors delegate+

rust-bors · 2026-08-11T22:33:28Z

✌️ @bushrat011899, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, then please make that change and post @bors r=GuillaumeGomez.

View changes since this delegation.

bushrat011899 · 2026-08-11T23:50:20Z

@bors r=GuillaumeGomez

rust-bors · 2026-08-11T23:50:23Z

📌 Commit 413fdca has been approved by GuillaumeGomez

It is now in the queue for this repository.

Rollup of 14 pull requests Successful merges: - #160620 (Do not pass `-no-pie` on Windows) - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - #160854 (Add -Zwasm-proc-macros flag) - #160868 (std: Adjust cfgs again for TLS on WASI) - #160882 (Add basic `splat` support to `rustdoc`) - #160894 (Allow running an arbitrary number of try jobs per PR) - #160790 (rustc-book: update sys-v abi link) - #160878 (Add rust_analyzer to check-cfg names) - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - #160920 (No longer mention the removed generic) - #160921 (rustdoc: Fix invalid CSS classes generated for notable items) - #160924 (split up `rustc_session`) - #160934 (Ensure TLS accesses don't call the global allocator through panic) - #160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

Rollup merge of #160882 - bushrat011899:rustdoc_splat_ellipsis, r=GuillaumeGomez Add basic `splat` support to `rustdoc` Tracking Issue: #153629 # Description While experimenting on variadic `min`/`max`, it was [noted](rust-lang/libs-team#848 (comment)) that the `rustdoc` output for a splatted function is less than ideal. Consider the below: ```rust pub fn smallest<T: Ord>(#[rustc_splat] vals: impl TupleReduce<Item = T>) -> T { // ... } ``` Currently, this is rendered in `rustdoc` as-is, obfuscating the variadic nature of the function: <img width="819" height="211" alt="image" src="https://github.com/user-attachments/assets/68569fe6-7285-49f8-aae9-ddad0b10649c" /> ## Solution I've updated the clean `Parameter` type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed. <img width="820" height="211" alt="image" src="https://github.com/user-attachments/assets/58a27245-cc38-44e6-908a-f67991bcdb64" /> --- ## Notes * No AI tooling of any kind was used during the creation of this PR.

Rollup of 14 pull requests Successful merges: - rust-lang/rust#160620 (Do not pass `-no-pie` on Windows) - rust-lang/rust#160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - rust-lang/rust#160854 (Add -Zwasm-proc-macros flag) - rust-lang/rust#160868 (std: Adjust cfgs again for TLS on WASI) - rust-lang/rust#160882 (Add basic `splat` support to `rustdoc`) - rust-lang/rust#160894 (Allow running an arbitrary number of try jobs per PR) - rust-lang/rust#160790 (rustc-book: update sys-v abi link) - rust-lang/rust#160878 (Add rust_analyzer to check-cfg names) - rust-lang/rust#160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - rust-lang/rust#160920 (No longer mention the removed generic) - rust-lang/rust#160921 (rustdoc: Fix invalid CSS classes generated for notable items) - rust-lang/rust#160924 (split up `rustc_session`) - rust-lang/rust#160934 (Ensure TLS accesses don't call the global allocator through panic) - rust-lang/rust#160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

bushrat011899 · 2026-08-10T23:37:46Z

Tracking Issue: #153629

Description

While experimenting on variadic min/max, it was noted that the rustdoc output for a splatted function is less than ideal. Consider the below:

pubfnsmallest<T:Ord>(#[rustc_splat]vals:implTupleReduce<Item = T>) -> T{// ...}

Currently, this is rendered in rustdoc as-is, obfuscating the variadic nature of the function:

Solution

I've updated the clean Parameter type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed.

Notes

No AI tooling of any kind was used during the creation of this PR.

rustbot · 2026-08-10T23:37:51Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 8 candidates
Random selection from GuillaumeGomez, lolbinarycat, notriddle

bushrat011899 · 2026-08-10T23:50:15Z

@rustbot label F-splat

GuillaumeGomez · 2026-08-11T09:06:38Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

bushrat011899 · 2026-08-11T09:33:32Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

Done! Sorry I should've included that initially, haven't contributed to rustdoc before! I swapped the … with args to confirm the test fails as well.

notriddle · 2026-08-11T14:59:44Z

r? @GuillaumeGomez

rustbot · 2026-08-11T14:59:47Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

GuillaumeGomez · 2026-08-11T22:33:25Z

Looks good to me, thanks! r=me once CI pass.

@bors delegate+

rust-bors · 2026-08-11T22:33:28Z

✌️ @bushrat011899, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, then please make that change and post @bors r=GuillaumeGomez.

View changes since this delegation.

bushrat011899 · 2026-08-11T23:50:20Z

@bors r=GuillaumeGomez

rust-bors · 2026-08-11T23:50:23Z

📌 Commit 413fdca has been approved by GuillaumeGomez

It is now in the queue for this repository.

Rollup of 14 pull requests Successful merges: - #160620 (Do not pass `-no-pie` on Windows) - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - #160854 (Add -Zwasm-proc-macros flag) - #160868 (std: Adjust cfgs again for TLS on WASI) - #160882 (Add basic `splat` support to `rustdoc`) - #160894 (Allow running an arbitrary number of try jobs per PR) - #160790 (rustc-book: update sys-v abi link) - #160878 (Add rust_analyzer to check-cfg names) - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - #160920 (No longer mention the removed generic) - #160921 (rustdoc: Fix invalid CSS classes generated for notable items) - #160924 (split up `rustc_session`) - #160934 (Ensure TLS accesses don't call the global allocator through panic) - #160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

Rollup merge of #160882 - bushrat011899:rustdoc_splat_ellipsis, r=GuillaumeGomez Add basic `splat` support to `rustdoc` Tracking Issue: #153629 # Description While experimenting on variadic `min`/`max`, it was [noted](rust-lang/libs-team#848 (comment)) that the `rustdoc` output for a splatted function is less than ideal. Consider the below: ```rust pub fn smallest<T: Ord>(#[rustc_splat] vals: impl TupleReduce<Item = T>) -> T { // ... } ``` Currently, this is rendered in `rustdoc` as-is, obfuscating the variadic nature of the function: <img width="819" height="211" alt="image" src="https://github.com/user-attachments/assets/68569fe6-7285-49f8-aae9-ddad0b10649c" /> ## Solution I've updated the clean `Parameter` type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed. <img width="820" height="211" alt="image" src="https://github.com/user-attachments/assets/58a27245-cc38-44e6-908a-f67991bcdb64" /> --- ## Notes * No AI tooling of any kind was used during the creation of this PR.

Rollup of 14 pull requests Successful merges: - rust-lang/rust#160620 (Do not pass `-no-pie` on Windows) - rust-lang/rust#160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - rust-lang/rust#160854 (Add -Zwasm-proc-macros flag) - rust-lang/rust#160868 (std: Adjust cfgs again for TLS on WASI) - rust-lang/rust#160882 (Add basic `splat` support to `rustdoc`) - rust-lang/rust#160894 (Allow running an arbitrary number of try jobs per PR) - rust-lang/rust#160790 (rustc-book: update sys-v abi link) - rust-lang/rust#160878 (Add rust_analyzer to check-cfg names) - rust-lang/rust#160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - rust-lang/rust#160920 (No longer mention the removed generic) - rust-lang/rust#160921 (rustdoc: Fix invalid CSS classes generated for notable items) - rust-lang/rust#160924 (split up `rustc_session`) - rust-lang/rust#160934 (Ensure TLS accesses don't call the global allocator through panic) - rust-lang/rust#160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

bushrat011899 · 2026-08-10T23:37:46Z

Tracking Issue: #153629

Description

While experimenting on variadic min/max, it was noted that the rustdoc output for a splatted function is less than ideal. Consider the below:

pubfnsmallest<T:Ord>(#[rustc_splat]vals:implTupleReduce<Item = T>) -> T{// ...}

Currently, this is rendered in rustdoc as-is, obfuscating the variadic nature of the function:

Solution

I've updated the clean Parameter type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed.

Notes

No AI tooling of any kind was used during the creation of this PR.

rustbot · 2026-08-10T23:37:51Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 8 candidates
Random selection from GuillaumeGomez, lolbinarycat, notriddle

bushrat011899 · 2026-08-10T23:50:15Z

@rustbot label F-splat

GuillaumeGomez · 2026-08-11T09:06:38Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

bushrat011899 · 2026-08-11T09:33:32Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

Done! Sorry I should've included that initially, haven't contributed to rustdoc before! I swapped the … with args to confirm the test fails as well.

notriddle · 2026-08-11T14:59:44Z

r? @GuillaumeGomez

rustbot · 2026-08-11T14:59:47Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

GuillaumeGomez · 2026-08-11T22:33:25Z

Looks good to me, thanks! r=me once CI pass.

@bors delegate+

rust-bors · 2026-08-11T22:33:28Z

✌️ @bushrat011899, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, then please make that change and post @bors r=GuillaumeGomez.

View changes since this delegation.

bushrat011899 · 2026-08-11T23:50:20Z

@bors r=GuillaumeGomez

rust-bors · 2026-08-11T23:50:23Z

📌 Commit 413fdca has been approved by GuillaumeGomez

It is now in the queue for this repository.

Rollup of 14 pull requests Successful merges: - #160620 (Do not pass `-no-pie` on Windows) - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - #160854 (Add -Zwasm-proc-macros flag) - #160868 (std: Adjust cfgs again for TLS on WASI) - #160882 (Add basic `splat` support to `rustdoc`) - #160894 (Allow running an arbitrary number of try jobs per PR) - #160790 (rustc-book: update sys-v abi link) - #160878 (Add rust_analyzer to check-cfg names) - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - #160920 (No longer mention the removed generic) - #160921 (rustdoc: Fix invalid CSS classes generated for notable items) - #160924 (split up `rustc_session`) - #160934 (Ensure TLS accesses don't call the global allocator through panic) - #160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

Rollup merge of #160882 - bushrat011899:rustdoc_splat_ellipsis, r=GuillaumeGomez Add basic `splat` support to `rustdoc` Tracking Issue: #153629 # Description While experimenting on variadic `min`/`max`, it was [noted](rust-lang/libs-team#848 (comment)) that the `rustdoc` output for a splatted function is less than ideal. Consider the below: ```rust pub fn smallest<T: Ord>(#[rustc_splat] vals: impl TupleReduce<Item = T>) -> T { // ... } ``` Currently, this is rendered in `rustdoc` as-is, obfuscating the variadic nature of the function: <img width="819" height="211" alt="image" src="https://github.com/user-attachments/assets/68569fe6-7285-49f8-aae9-ddad0b10649c" /> ## Solution I've updated the clean `Parameter` type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed. <img width="820" height="211" alt="image" src="https://github.com/user-attachments/assets/58a27245-cc38-44e6-908a-f67991bcdb64" /> --- ## Notes * No AI tooling of any kind was used during the creation of this PR.

Rollup of 14 pull requests Successful merges: - rust-lang/rust#160620 (Do not pass `-no-pie` on Windows) - rust-lang/rust#160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - rust-lang/rust#160854 (Add -Zwasm-proc-macros flag) - rust-lang/rust#160868 (std: Adjust cfgs again for TLS on WASI) - rust-lang/rust#160882 (Add basic `splat` support to `rustdoc`) - rust-lang/rust#160894 (Allow running an arbitrary number of try jobs per PR) - rust-lang/rust#160790 (rustc-book: update sys-v abi link) - rust-lang/rust#160878 (Add rust_analyzer to check-cfg names) - rust-lang/rust#160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - rust-lang/rust#160920 (No longer mention the removed generic) - rust-lang/rust#160921 (rustdoc: Fix invalid CSS classes generated for notable items) - rust-lang/rust#160924 (split up `rustc_session`) - rust-lang/rust#160934 (Ensure TLS accesses don't call the global allocator through panic) - rust-lang/rust#160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

bushrat011899 · 2026-08-10T23:37:46Z

Tracking Issue: #153629

Description

While experimenting on variadic min/max, it was noted that the rustdoc output for a splatted function is less than ideal. Consider the below:

pubfnsmallest<T:Ord>(#[rustc_splat]vals:implTupleReduce<Item = T>) -> T{// ...}

Currently, this is rendered in rustdoc as-is, obfuscating the variadic nature of the function:

Solution

I've updated the clean Parameter type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed.

Notes

No AI tooling of any kind was used during the creation of this PR.

rustbot · 2026-08-10T23:37:51Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 8 candidates
Random selection from GuillaumeGomez, lolbinarycat, notriddle

bushrat011899 · 2026-08-10T23:50:15Z

@rustbot label F-splat

GuillaumeGomez · 2026-08-11T09:06:38Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

bushrat011899 · 2026-08-11T09:33:32Z

Please add a regression test in tests/rustdoc-html to ensure the "..." is correctly generated.

Done! Sorry I should've included that initially, haven't contributed to rustdoc before! I swapped the … with args to confirm the test fails as well.

notriddle · 2026-08-11T14:59:44Z

r? @GuillaumeGomez

rustbot · 2026-08-11T14:59:47Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

GuillaumeGomez · 2026-08-11T22:33:25Z

Looks good to me, thanks! r=me once CI pass.

@bors delegate+

rust-bors · 2026-08-11T22:33:28Z

✌️ @bushrat011899, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, then please make that change and post @bors r=GuillaumeGomez.

View changes since this delegation.

bushrat011899 · 2026-08-11T23:50:20Z

@bors r=GuillaumeGomez

rust-bors · 2026-08-11T23:50:23Z

📌 Commit 413fdca has been approved by GuillaumeGomez

It is now in the queue for this repository.

Rollup of 14 pull requests Successful merges: - #160620 (Do not pass `-no-pie` on Windows) - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - #160854 (Add -Zwasm-proc-macros flag) - #160868 (std: Adjust cfgs again for TLS on WASI) - #160882 (Add basic `splat` support to `rustdoc`) - #160894 (Allow running an arbitrary number of try jobs per PR) - #160790 (rustc-book: update sys-v abi link) - #160878 (Add rust_analyzer to check-cfg names) - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - #160920 (No longer mention the removed generic) - #160921 (rustdoc: Fix invalid CSS classes generated for notable items) - #160924 (split up `rustc_session`) - #160934 (Ensure TLS accesses don't call the global allocator through panic) - #160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

Rollup merge of #160882 - bushrat011899:rustdoc_splat_ellipsis, r=GuillaumeGomez Add basic `splat` support to `rustdoc` Tracking Issue: #153629 # Description While experimenting on variadic `min`/`max`, it was [noted](rust-lang/libs-team#848 (comment)) that the `rustdoc` output for a splatted function is less than ideal. Consider the below: ```rust pub fn smallest<T: Ord>(#[rustc_splat] vals: impl TupleReduce<Item = T>) -> T { // ... } ``` Currently, this is rendered in `rustdoc` as-is, obfuscating the variadic nature of the function: <img width="819" height="211" alt="image" src="https://github.com/user-attachments/assets/68569fe6-7285-49f8-aae9-ddad0b10649c" /> ## Solution I've updated the clean `Parameter` type to include whether it is splatted, and overridden the display of that parameter to replace the name with an ellipsis, similar to how fake variadic implementations are displayed. <img width="820" height="211" alt="image" src="https://github.com/user-attachments/assets/58a27245-cc38-44e6-908a-f67991bcdb64" /> --- ## Notes * No AI tooling of any kind was used during the creation of this PR.

Rollup of 14 pull requests Successful merges: - rust-lang/rust#160620 (Do not pass `-no-pie` on Windows) - rust-lang/rust#160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion) - rust-lang/rust#160854 (Add -Zwasm-proc-macros flag) - rust-lang/rust#160868 (std: Adjust cfgs again for TLS on WASI) - rust-lang/rust#160882 (Add basic `splat` support to `rustdoc`) - rust-lang/rust#160894 (Allow running an arbitrary number of try jobs per PR) - rust-lang/rust#160790 (rustc-book: update sys-v abi link) - rust-lang/rust#160878 (Add rust_analyzer to check-cfg names) - rust-lang/rust#160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency) - rust-lang/rust#160920 (No longer mention the removed generic) - rust-lang/rust#160921 (rustdoc: Fix invalid CSS classes generated for notable items) - rust-lang/rust#160924 (split up `rustc_session`) - rust-lang/rust#160934 (Ensure TLS accesses don't call the global allocator through panic) - rust-lang/rust#160937 (Store the names of `Fn` trait parameters in the AST, fix rustfmt bug)

rustbot assigned GuillaumeGomez Aug 10, 2026

bushrat011899 mentioned this pull request Aug 10, 2026
ACP: Variadic core::cmp::{min, max}rust-lang/libs-team#848
Closed

rustbot added the F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 label Aug 10, 2026

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from c649afa to 015e677Compare August 11, 2026 09:31

GuillaumeGomez reviewed Aug 11, 2026
View reviewed changes

Comment threadtests/rustdoc-html/splat-variadic-ellipsis.rs

Add basic splat support to rustdoc
413fdca
Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from 015e677 to 413fdcaCompare August 11, 2026 22:18

bushrat011899 requested a review from GuillaumeGomez August 11, 2026 22:19

GuillaumeGomez approved these changes Aug 11, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026

jhpratt mentioned this pull request Aug 12, 2026
Rollup of 14 pull requests #160954
Merged

rust-borsBot merged commit 7718d14 into rust-lang:mainAug 12, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 12, 2026

This was referenced Aug 18, 2026
Nightly support for function overloading in FFI bindings rust-lang/goals#643
Open
C++/Rust Interop Problem Space Mapping rust-lang/goals#388
Open

rustbot assigned GuillaumeGomez Aug 10, 2026

bushrat011899 mentioned this pull request Aug 10, 2026
ACP: Variadic core::cmp::{min, max}rust-lang/libs-team#848
Closed

rustbot added the F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 label Aug 10, 2026

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from c649afa to 015e677Compare August 11, 2026 09:31

GuillaumeGomez reviewed Aug 11, 2026
View reviewed changes

Comment threadtests/rustdoc-html/splat-variadic-ellipsis.rs

Add basic splat support to rustdoc
413fdca
Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from 015e677 to 413fdcaCompare August 11, 2026 22:18

bushrat011899 requested a review from GuillaumeGomez August 11, 2026 22:19

GuillaumeGomez approved these changes Aug 11, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026

jhpratt mentioned this pull request Aug 12, 2026
Rollup of 14 pull requests #160954
Merged

rust-borsBot merged commit 7718d14 into rust-lang:mainAug 12, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 12, 2026

This was referenced Aug 18, 2026
Nightly support for function overloading in FFI bindings rust-lang/goals#643
Open
C++/Rust Interop Problem Space Mapping rust-lang/goals#388
Open

rustbot assigned GuillaumeGomez Aug 10, 2026

bushrat011899 mentioned this pull request Aug 10, 2026
ACP: Variadic core::cmp::{min, max}rust-lang/libs-team#848
Closed

rustbot added the F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 label Aug 10, 2026

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from c649afa to 015e677Compare August 11, 2026 09:31

GuillaumeGomez reviewed Aug 11, 2026
View reviewed changes

Comment threadtests/rustdoc-html/splat-variadic-ellipsis.rs

Add basic splat support to rustdoc
413fdca
Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from 015e677 to 413fdcaCompare August 11, 2026 22:18

bushrat011899 requested a review from GuillaumeGomez August 11, 2026 22:19

GuillaumeGomez approved these changes Aug 11, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026

jhpratt mentioned this pull request Aug 12, 2026
Rollup of 14 pull requests #160954
Merged

rust-borsBot merged commit 7718d14 into rust-lang:mainAug 12, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 12, 2026

This was referenced Aug 18, 2026
Nightly support for function overloading in FFI bindings rust-lang/goals#643
Open
C++/Rust Interop Problem Space Mapping rust-lang/goals#388
Open

rustbot assigned GuillaumeGomez Aug 10, 2026

bushrat011899 mentioned this pull request Aug 10, 2026
ACP: Variadic core::cmp::{min, max}rust-lang/libs-team#848
Closed

rustbot added the F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 label Aug 10, 2026

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from c649afa to 015e677Compare August 11, 2026 09:31

GuillaumeGomez reviewed Aug 11, 2026
View reviewed changes

Comment threadtests/rustdoc-html/splat-variadic-ellipsis.rs

Add basic splat support to rustdoc
413fdca
Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from 015e677 to 413fdcaCompare August 11, 2026 22:18

bushrat011899 requested a review from GuillaumeGomez August 11, 2026 22:19

GuillaumeGomez approved these changes Aug 11, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026

jhpratt mentioned this pull request Aug 12, 2026
Rollup of 14 pull requests #160954
Merged

rust-borsBot merged commit 7718d14 into rust-lang:mainAug 12, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 12, 2026

This was referenced Aug 18, 2026
Nightly support for function overloading in FFI bindings rust-lang/goals#643
Open
C++/Rust Interop Problem Space Mapping rust-lang/goals#388
Open

rustbot assigned GuillaumeGomez Aug 10, 2026

bushrat011899 mentioned this pull request Aug 10, 2026
ACP: Variadic core::cmp::{min, max}rust-lang/libs-team#848
Closed

rustbot added the F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 label Aug 10, 2026

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from c649afa to 015e677Compare August 11, 2026 09:31

GuillaumeGomez reviewed Aug 11, 2026
View reviewed changes

Comment threadtests/rustdoc-html/splat-variadic-ellipsis.rs

Add basic splat support to rustdoc
413fdca
Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from 015e677 to 413fdcaCompare August 11, 2026 22:18

bushrat011899 requested a review from GuillaumeGomez August 11, 2026 22:19

GuillaumeGomez approved these changes Aug 11, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026

jhpratt mentioned this pull request Aug 12, 2026
Rollup of 14 pull requests #160954
Merged

rust-borsBot merged commit 7718d14 into rust-lang:mainAug 12, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 12, 2026

This was referenced Aug 18, 2026
Nightly support for function overloading in FFI bindings rust-lang/goals#643
Open
C++/Rust Interop Problem Space Mapping rust-lang/goals#388
Open

rustbot assigned GuillaumeGomez Aug 10, 2026

bushrat011899 mentioned this pull request Aug 10, 2026
ACP: Variadic core::cmp::{min, max}rust-lang/libs-team#848
Closed

rustbot added the F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 label Aug 10, 2026

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from c649afa to 015e677Compare August 11, 2026 09:31

GuillaumeGomez reviewed Aug 11, 2026
View reviewed changes

Comment threadtests/rustdoc-html/splat-variadic-ellipsis.rs

Add basic splat support to rustdoc
413fdca
Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from 015e677 to 413fdcaCompare August 11, 2026 22:18

bushrat011899 requested a review from GuillaumeGomez August 11, 2026 22:19

GuillaumeGomez approved these changes Aug 11, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026

jhpratt mentioned this pull request Aug 12, 2026
Rollup of 14 pull requests #160954
Merged

rust-borsBot merged commit 7718d14 into rust-lang:mainAug 12, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 12, 2026

This was referenced Aug 18, 2026
Nightly support for function overloading in FFI bindings rust-lang/goals#643
Open
C++/Rust Interop Problem Space Mapping rust-lang/goals#388
Open

rustbot assigned GuillaumeGomez Aug 10, 2026

bushrat011899 mentioned this pull request Aug 10, 2026
ACP: Variadic core::cmp::{min, max}rust-lang/libs-team#848
Closed

rustbot added the F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 label Aug 10, 2026

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from c649afa to 015e677Compare August 11, 2026 09:31

GuillaumeGomez reviewed Aug 11, 2026
View reviewed changes

Comment threadtests/rustdoc-html/splat-variadic-ellipsis.rs

Add basic splat support to rustdoc
413fdca
Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from 015e677 to 413fdcaCompare August 11, 2026 22:18

bushrat011899 requested a review from GuillaumeGomez August 11, 2026 22:19

GuillaumeGomez approved these changes Aug 11, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026

jhpratt mentioned this pull request Aug 12, 2026
Rollup of 14 pull requests #160954
Merged

rust-borsBot merged commit 7718d14 into rust-lang:mainAug 12, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 12, 2026

This was referenced Aug 18, 2026
Nightly support for function overloading in FFI bindings rust-lang/goals#643
Open
C++/Rust Interop Problem Space Mapping rust-lang/goals#388
Open

rustbot assigned GuillaumeGomez Aug 10, 2026

bushrat011899 mentioned this pull request Aug 10, 2026
ACP: Variadic core::cmp::{min, max}rust-lang/libs-team#848
Closed

rustbot added the F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 label Aug 10, 2026

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from c649afa to 015e677Compare August 11, 2026 09:31

GuillaumeGomez reviewed Aug 11, 2026
View reviewed changes

Comment threadtests/rustdoc-html/splat-variadic-ellipsis.rs

Add basic splat support to rustdoc
413fdca
Simply replace the parameter name and `#[rustc_splat]` attribute with an ellipsis. This preserves the type information of the splat while still documenting the variadic nature of the function.

bushrat011899 force-pushed the rustdoc_splat_ellipsis branch from 015e677 to 413fdcaCompare August 11, 2026 22:18

bushrat011899 requested a review from GuillaumeGomez August 11, 2026 22:19

GuillaumeGomez approved these changes Aug 11, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026

jhpratt mentioned this pull request Aug 12, 2026
Rollup of 14 pull requests #160954
Merged

rust-borsBot merged commit 7718d14 into rust-lang:mainAug 12, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 12, 2026

This was referenced Aug 18, 2026
Nightly support for function overloading in FFI bindings rust-lang/goals#643
Open
C++/Rust Interop Problem Space Mapping rust-lang/goals#388
Open

Uh oh!

Uh oh!

Conversation

bushrat011899 commented Aug 10, 2026• edited by steffahn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Solution

Notes

Uh oh!

rustbot commented Aug 10, 2026

Uh oh!

bushrat011899 commented Aug 10, 2026

Uh oh!

GuillaumeGomez commented Aug 11, 2026

Uh oh!

bushrat011899 commented Aug 11, 2026

Uh oh!

Uh oh!

notriddle commented Aug 11, 2026

Uh oh!

rustbot commented Aug 11, 2026

Uh oh!

GuillaumeGomez commented Aug 11, 2026

Uh oh!

rust-borsBot commented Aug 11, 2026

Uh oh!

bushrat011899 commented Aug 11, 2026

Uh oh!

rust-borsBot commented Aug 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

bushrat011899 commented Aug 10, 2026• edited by steffahn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Solution

Notes

Uh oh!

rustbot commented Aug 10, 2026

Uh oh!

bushrat011899 commented Aug 10, 2026

Uh oh!

GuillaumeGomez commented Aug 11, 2026

Uh oh!

bushrat011899 commented Aug 11, 2026

Uh oh!

Uh oh!

notriddle commented Aug 11, 2026

Uh oh!

rustbot commented Aug 11, 2026

Uh oh!

GuillaumeGomez commented Aug 11, 2026

Uh oh!

rust-borsBot commented Aug 11, 2026

Uh oh!

bushrat011899 commented Aug 11, 2026

Uh oh!

rust-borsBot commented Aug 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

bushrat011899 commented Aug 10, 2026•
edited by steffahn
Loading

bushrat011899 commented Aug 10, 2026•
edited by steffahn
Loading

bushrat011899 commented Aug 10, 2026•
edited by steffahn
Loading

bushrat011899 commented Aug 10, 2026•
edited by steffahn
Loading