Skip to content

Add TypeId::is_signed method - #160925

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
yara-blue:is_signed
Aug 12, 2026
Merged

Add TypeId::is_signed method#160925
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
yara-blue:is_signed

Conversation

@yara-blue

@yara-blueyara-blue commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Tracking issue #146922

r? @oli-obk

@rustbot

rustbot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

The reflection data structures are tied exactly to the implementation
in the compiler. Make sure to also adjust rustc_const_eval/src/const_eval/type_info.rs

cc @oli-obk

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 11, 2026
@rustbot

rustbot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@oli-obkoli-obk added the F-type_info #![feature(type_info)] label Aug 12, 2026
oli-obk
oli-obk approved these changes Aug 12, 2026
View reviewed changes

@oli-obkoli-obk left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors

rust-borsBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0ea82de has been approved by oli-obk

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Aug 12, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Aug 12, 2026
@bors
Auto merge of#160980- JonathanBrouwer:rollup-MX1XSgM, r=JonathanBro…
c98d0cb
…uwer
Rollup of 6 pull requests
Successful merges:
- #160966 (bootstrap: Avoid some unnecessary imports from the crate root)
- #159987 (trait solver: Track canonical response universe assumptions)
- #160886 (Trim `GoalStalledOn::Certainty`)
- #160925 (Add `TypeId::is_signed` method)
- #160926 (sve: add addl. passing test for field projection)
- #160977 (Remove `MutatingUseContext::Retag`)
@rust-bors
rust-borsBot merged commit 5d8a3c9 into rust-lang:mainAug 12, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Aug 12, 2026
rust-timer added a commit that referenced this pull request Aug 12, 2026
@rust-timer
Unrolled build for#160925
07c1ddb
Rollup merge of #160925 - yara-blue:is_signed, r=oli-obk
Add `TypeId::is_signed` method
Tracking issue #146922
r? @oli-obk
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obkoli-obkoli-obk approved these changes

Assignees

@oli-obkoli-obk

Labels

F-type_info#![feature(type_info)]S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

3 participants

@yara-blue@rustbot@oli-obk