Enforce safety comments on alloc - #160941

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
nia-e:alloc-safety-comments
Aug 30, 2026
Merged

Enforce safety comments on alloc#160941
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
nia-e:alloc-safety-comments

Conversation

@nia-e

@nia-enia-e commented Aug 11, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^

r? clarfonthey

@rustbotrustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 11, 2026
@nia-e

nia-e commented Aug 11, 2026

Copy link
Copy Markdown
MemberAuthor

This will break a lot of ppl's CI ^^

@bors rollup=never

@JonathanBrouwer

JonathanBrouwer commented Aug 11, 2026•
edited
Loading

Copy link
Copy Markdown
Member

I'm not convinced rollup=never actually helps. This kind of PR is likely to have soft conflicts (i.e. someone adds an unsafe block between this PR being opened and merged), but rollup=never doesn't help detecting those. In fact, it makes them worse because soft conflicts may get detected in PR CI/try jobs of rollups and not waste queue time. My primary recommendation to help with this would be to reduce the time between PR open and r+, and rebase before r+ if this is more than a few days

@JonathanBrouwer

JonathanBrouwer commented Aug 11, 2026

Copy link
Copy Markdown
Member

@bors rollup=iffy p=1 likely to soft conflict
p=1 does help because it makes you get into rollups earlier reducing time between pr open & merge

@nia-e

nia-e commented Aug 12, 2026

Copy link
Copy Markdown
MemberAuthor

...i completely forgot to actually push the commit with all my manual work. apologies 🫠

@clarfonthey

clarfonthey commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Oh, I didn't know that you were actually going through and adding comments to these. I'd, probably want to do an actual review in that case.

clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/btree/mem.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/drain.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/ffi/c_str.rs Outdated
clarfonthey
clarfonthey reviewed Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/raw_vec/mod.rs
type Cap = core::num::niche_types::UsizeNoHighBit;

// SAFETY: Untriaged.
// SAFETY: 0 *definitely* is less than isize::MAX.

@clarfontheyclarfontheyAug 12, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how can you be sure?

View changes since the review

@nia-enia-eAug 12, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy: isize was defined before 2025 and therefore there were affordable computers around that had to address more than 0 bytes of memory!

@rustbotrustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@clarfonthey

clarfonthey commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

(apologies for merging some conflicting PRs. wouldn't mind helping rebase if this is getting difficult to manage)

@nia-e
tidy: enforce documented unsafe in alloc
f1f423d
safety comments in alloc
this was pain and it's not even half i think
oepsje woepsje
@nia-e
update some comments
483873e
@nia-e
nia-eforce-pushed the alloc-safety-comments branch from 75cc497 to 483873eCompareAugust 28, 2026 21:56
@rustbot

rustbot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@nia-e

nia-e commented Aug 28, 2026

Copy link
Copy Markdown
MemberAuthor

think this is done and mergeable now. rebased on main, so it shouldn't conflict much i hope?

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 28, 2026
@clarfonthey

clarfonthey commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Okay, that was painful, but reviewed.

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot pushed a commit that referenced this pull request Aug 29, 2026
@bors
Auto merge of#160941- nia-e:alloc-safety-comments, r=<try>
8e834e4
Enforce safety comments on `alloc`
@clarfonthey

clarfonthey commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Recommended merge command assuming try passes:

r=clarfonthey p=1 note="Affects entire alloc crate, can easily go stale"

@clarfonthey

clarfonthey commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Also fine with you just rebasing this yourself and merging in case of conflicts, assuming you mark new blocks as ignored instead of trying to determine what their comments should be.

@rust-bors

rust-borsBot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 8e834e4 (8e834e4af0546ff9e43f5ddca26d6ea6c9305778)
Base parent: 6bb812b (6bb812b714cce8e08864b7b569303f25ab08eaad)

@clarfonthey

clarfonthey commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

@bors r+ p=1 note="Affects entire alloc crate, can easily go stale"

@rust-bors

rust-borsBot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 483873e has been approved by clarfonthey

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
213016c
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer mentioned this pull request Aug 29, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
ed10cbd
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer mentioned this pull request Aug 29, 2026
Closed
@GuillaumeGomezGuillaumeGomez mentioned this pull request Aug 29, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Aug 29, 2026
@bors
Auto merge of#161990- GuillaumeGomez:rollup-jrJIOEF, r=GuillaumeGomez
4545c83
Rollup of 7 pull requests
Successful merges:
- #160941 (Enforce safety comments on `alloc`)
- #161975 (Abort instead of unwinding out of an inconsistent BTreeMap::split_off)
- #157968 (Preserve ambiguous glob lint for subtrait method picks)
- #161514 (rework handling of doc attributes on macro calls)
- #161944 (rustdoc: Take into account edition information for keyword highlighting)
- #161974 (remove rustc_never_type_options attr remnants)
- #161978 (Move rustdoc ui doctests into the right testsuite)
Failed merges:
- #161702 (Use `drop_guard` in some places in {core,alloc,std})
@rust-bors
rust-borsBot merged commit 984e522 into rust-lang:mainAug 30, 2026
14 checks passed
rust-borsBot pushed a commit that referenced this pull request Aug 30, 2026
@bors
Unrolled build for#160941in rollup 161990
71fc40e
Rollup merge of #160941 - nia-e:alloc-safety-comments, r=clarfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot added this to the 1.100.0 milestone Aug 30, 2026
@DanielEScherzerDanielEScherzer mentioned this pull request Sep 1, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clarfontheyclarfontheyclarfonthey left review comments
+1 more reviewer
@DanielEScherzerDanielEScherzerDanielEScherzer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@clarfontheyclarfonthey

Labels

A-tidyArea: The tidy toolS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nia-e@JonathanBrouwer@clarfonthey@ChrisDenton@rust-log-analyzer@rustbot@DanielEScherzer
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Enforce safety comments on alloc - #160941
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Aug 30, 2026
Merged
Enforce safety comments on alloc#160941
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Conversation
@nia-e
@nia-enia-e
commented
Aug 11, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Aug 11, 2026
@nia-e
nia-e
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
This will break a lot of ppl's CI ^^
@bors rollup=never
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'm not convinced rollup=never actually helps. This kind of PR is likely to have soft conflicts (i.e. someone adds an unsafe block between this PR being opened and merged), but rollup=never doesn't help detecting those. In fact, it makes them worse because soft conflicts may get detected in PR CI/try jobs of rollups and not waste queue time. My primary recommendation to help with this would be to reduce the time between PR open and r+, and rebase before r+ if this is more than a few days
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
@bors rollup=iffy p=1 likely to soft conflict

p=1 does help because it makes you get into rollups earlier reducing time between pr open & merge
@nia-e
nia-e
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
...i completely forgot to actually push the commit with all my manual work. apologies 🫠
@clarfonthey
clarfonthey
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Oh, I didn't know that you were actually going through and adding comments to these. I'd, probably want to do an actual review in that case.
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/btree/mem.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/drain.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/ffi/c_str.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/raw_vec/mod.rs
type Cap = core::num::niche_types::UsizeNoHighBit;

// SAFETY: Untriaged.
// SAFETY: 0 *definitely* is less than isize::MAX.
@clarfontheyclarfontheyAug 12, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how can you be sure?
View changes since the review
@nia-enia-eAug 12, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy: isize was defined before 2025 and therefore there were affordable computers around that had to address more than 0 bytes of memory!
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@clarfonthey
clarfonthey
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
(apologies for merging some conflicting PRs. wouldn't mind helping rebase if this is getting difficult to manage)
@nia-e
tidy: enforce documented unsafe in alloc
f1f423d
safety comments in alloc
this was pain and it's not even half i think
oepsje woepsje
@nia-e
update some comments
483873e
@nia-e
nia-eforce-pushed
the
alloc-safety-comments
branch
from
75cc497 to
483873eCompareAugust 28, 2026 21:56
@rustbot
rustbot
commented
Aug 28, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@nia-e
nia-e
commented
Aug 28, 2026

Copy link


Copy Markdown

MemberAuthor
think this is done and mergeable now. rebased on main, so it shouldn't conflict much i hope?
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 28, 2026
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Okay, that was painful, but reviewed.
@bors try
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#160941- nia-e:alloc-safety-comments, r=<try>
8e834e4
Enforce safety comments on `alloc`
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Recommended merge command assuming try passes:
r=clarfonthey p=1 note="Affects entire alloc crate, can easily go stale"
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Also fine with you just rebasing this yourself and merging in case of conflicts, assuming you mark new blocks as ignored instead of trying to determine what their comments should be.
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8e834e4 (8e834e4af0546ff9e43f5ddca26d6ea6c9305778)

Base parent: 6bb812b (6bb812b714cce8e08864b7b569303f25ab08eaad)
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
@bors r+ p=1 note="Affects entire alloc crate, can easily go stale"
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 483873e has been approved by clarfonthey
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 29, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
213016c
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
ed10cbd
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 29, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#161990- GuillaumeGomez:rollup-jrJIOEF, r=GuillaumeGomez
4545c83
Rollup of 7 pull requests
Successful merges:
- #160941 (Enforce safety comments on `alloc`)
- #161975 (Abort instead of unwinding out of an inconsistent BTreeMap::split_off)
- #157968 (Preserve ambiguous glob lint for subtrait method picks)
- #161514 (rework handling of doc attributes on macro calls)
- #161944 (rustdoc: Take into account edition information for keyword highlighting)
- #161974 (remove rustc_never_type_options attr remnants)
- #161978 (Move rustdoc ui doctests into the right testsuite)
Failed merges:
- #161702 (Use `drop_guard` in some places in {core,alloc,std})
@rust-bors
rust-borsBot
merged commit 984e522
into
rust-lang:mainAug 30, 2026

14 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 30, 2026
@bors
Unrolled build for#160941in rollup 161990
71fc40e
Rollup merge of #160941 - nia-e:alloc-safety-comments, r=clarfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 30, 2026
@DanielEScherzerDanielEScherzer
mentioned this pull request
Sep 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@clarfontheyclarfontheyclarfonthey left review comments

+1 more reviewer

@DanielEScherzerDanielEScherzerDanielEScherzer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@clarfontheyclarfonthey

Labels

A-tidyArea: The tidy toolS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nia-e@JonathanBrouwer@clarfonthey@ChrisDenton@rust-log-analyzer@rustbot@DanielEScherzer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enforce safety comments on alloc - #160941
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Aug 30, 2026
Merged
Enforce safety comments on alloc#160941
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Conversation
@nia-e
@nia-enia-e
commented
Aug 11, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Aug 11, 2026
@nia-e
nia-e
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
This will break a lot of ppl's CI ^^
@bors rollup=never
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'm not convinced rollup=never actually helps. This kind of PR is likely to have soft conflicts (i.e. someone adds an unsafe block between this PR being opened and merged), but rollup=never doesn't help detecting those. In fact, it makes them worse because soft conflicts may get detected in PR CI/try jobs of rollups and not waste queue time. My primary recommendation to help with this would be to reduce the time between PR open and r+, and rebase before r+ if this is more than a few days
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
@bors rollup=iffy p=1 likely to soft conflict

p=1 does help because it makes you get into rollups earlier reducing time between pr open & merge
@nia-e
nia-e
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
...i completely forgot to actually push the commit with all my manual work. apologies 🫠
@clarfonthey
clarfonthey
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Oh, I didn't know that you were actually going through and adding comments to these. I'd, probably want to do an actual review in that case.
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/btree/mem.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/drain.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/ffi/c_str.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/raw_vec/mod.rs
type Cap = core::num::niche_types::UsizeNoHighBit;

// SAFETY: Untriaged.
// SAFETY: 0 *definitely* is less than isize::MAX.
@clarfontheyclarfontheyAug 12, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how can you be sure?
View changes since the review
@nia-enia-eAug 12, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy: isize was defined before 2025 and therefore there were affordable computers around that had to address more than 0 bytes of memory!
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@clarfonthey
clarfonthey
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
(apologies for merging some conflicting PRs. wouldn't mind helping rebase if this is getting difficult to manage)
@nia-e
tidy: enforce documented unsafe in alloc
f1f423d
safety comments in alloc
this was pain and it's not even half i think
oepsje woepsje
@nia-e
update some comments
483873e
@nia-e
nia-eforce-pushed
the
alloc-safety-comments
branch
from
75cc497 to
483873eCompareAugust 28, 2026 21:56
@rustbot
rustbot
commented
Aug 28, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@nia-e
nia-e
commented
Aug 28, 2026

Copy link


Copy Markdown

MemberAuthor
think this is done and mergeable now. rebased on main, so it shouldn't conflict much i hope?
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 28, 2026
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Okay, that was painful, but reviewed.
@bors try
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#160941- nia-e:alloc-safety-comments, r=<try>
8e834e4
Enforce safety comments on `alloc`
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Recommended merge command assuming try passes:
r=clarfonthey p=1 note="Affects entire alloc crate, can easily go stale"
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Also fine with you just rebasing this yourself and merging in case of conflicts, assuming you mark new blocks as ignored instead of trying to determine what their comments should be.
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8e834e4 (8e834e4af0546ff9e43f5ddca26d6ea6c9305778)

Base parent: 6bb812b (6bb812b714cce8e08864b7b569303f25ab08eaad)
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
@bors r+ p=1 note="Affects entire alloc crate, can easily go stale"
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 483873e has been approved by clarfonthey
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 29, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
213016c
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
ed10cbd
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 29, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#161990- GuillaumeGomez:rollup-jrJIOEF, r=GuillaumeGomez
4545c83
Rollup of 7 pull requests
Successful merges:
- #160941 (Enforce safety comments on `alloc`)
- #161975 (Abort instead of unwinding out of an inconsistent BTreeMap::split_off)
- #157968 (Preserve ambiguous glob lint for subtrait method picks)
- #161514 (rework handling of doc attributes on macro calls)
- #161944 (rustdoc: Take into account edition information for keyword highlighting)
- #161974 (remove rustc_never_type_options attr remnants)
- #161978 (Move rustdoc ui doctests into the right testsuite)
Failed merges:
- #161702 (Use `drop_guard` in some places in {core,alloc,std})
@rust-bors
rust-borsBot
merged commit 984e522
into
rust-lang:mainAug 30, 2026

14 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 30, 2026
@bors
Unrolled build for#160941in rollup 161990
71fc40e
Rollup merge of #160941 - nia-e:alloc-safety-comments, r=clarfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 30, 2026
@DanielEScherzerDanielEScherzer
mentioned this pull request
Sep 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@clarfontheyclarfontheyclarfonthey left review comments

+1 more reviewer

@DanielEScherzerDanielEScherzerDanielEScherzer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@clarfontheyclarfonthey

Labels

A-tidyArea: The tidy toolS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nia-e@JonathanBrouwer@clarfonthey@ChrisDenton@rust-log-analyzer@rustbot@DanielEScherzer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enforce safety comments on alloc - #160941
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Aug 30, 2026
Merged
Enforce safety comments on alloc#160941
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Conversation
@nia-e
@nia-enia-e
commented
Aug 11, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Aug 11, 2026
@nia-e
nia-e
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
This will break a lot of ppl's CI ^^
@bors rollup=never
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'm not convinced rollup=never actually helps. This kind of PR is likely to have soft conflicts (i.e. someone adds an unsafe block between this PR being opened and merged), but rollup=never doesn't help detecting those. In fact, it makes them worse because soft conflicts may get detected in PR CI/try jobs of rollups and not waste queue time. My primary recommendation to help with this would be to reduce the time between PR open and r+, and rebase before r+ if this is more than a few days
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
@bors rollup=iffy p=1 likely to soft conflict

p=1 does help because it makes you get into rollups earlier reducing time between pr open & merge
@nia-e
nia-e
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
...i completely forgot to actually push the commit with all my manual work. apologies 🫠
@clarfonthey
clarfonthey
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Oh, I didn't know that you were actually going through and adding comments to these. I'd, probably want to do an actual review in that case.
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/btree/mem.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/drain.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/ffi/c_str.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/raw_vec/mod.rs
type Cap = core::num::niche_types::UsizeNoHighBit;

// SAFETY: Untriaged.
// SAFETY: 0 *definitely* is less than isize::MAX.
@clarfontheyclarfontheyAug 12, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how can you be sure?
View changes since the review
@nia-enia-eAug 12, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy: isize was defined before 2025 and therefore there were affordable computers around that had to address more than 0 bytes of memory!
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@clarfonthey
clarfonthey
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
(apologies for merging some conflicting PRs. wouldn't mind helping rebase if this is getting difficult to manage)
@nia-e
tidy: enforce documented unsafe in alloc
f1f423d
safety comments in alloc
this was pain and it's not even half i think
oepsje woepsje
@nia-e
update some comments
483873e
@nia-e
nia-eforce-pushed
the
alloc-safety-comments
branch
from
75cc497 to
483873eCompareAugust 28, 2026 21:56
@rustbot
rustbot
commented
Aug 28, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@nia-e
nia-e
commented
Aug 28, 2026

Copy link


Copy Markdown

MemberAuthor
think this is done and mergeable now. rebased on main, so it shouldn't conflict much i hope?
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 28, 2026
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Okay, that was painful, but reviewed.
@bors try
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#160941- nia-e:alloc-safety-comments, r=<try>
8e834e4
Enforce safety comments on `alloc`
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Recommended merge command assuming try passes:
r=clarfonthey p=1 note="Affects entire alloc crate, can easily go stale"
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Also fine with you just rebasing this yourself and merging in case of conflicts, assuming you mark new blocks as ignored instead of trying to determine what their comments should be.
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8e834e4 (8e834e4af0546ff9e43f5ddca26d6ea6c9305778)

Base parent: 6bb812b (6bb812b714cce8e08864b7b569303f25ab08eaad)
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
@bors r+ p=1 note="Affects entire alloc crate, can easily go stale"
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 483873e has been approved by clarfonthey
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 29, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
213016c
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
ed10cbd
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 29, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#161990- GuillaumeGomez:rollup-jrJIOEF, r=GuillaumeGomez
4545c83
Rollup of 7 pull requests
Successful merges:
- #160941 (Enforce safety comments on `alloc`)
- #161975 (Abort instead of unwinding out of an inconsistent BTreeMap::split_off)
- #157968 (Preserve ambiguous glob lint for subtrait method picks)
- #161514 (rework handling of doc attributes on macro calls)
- #161944 (rustdoc: Take into account edition information for keyword highlighting)
- #161974 (remove rustc_never_type_options attr remnants)
- #161978 (Move rustdoc ui doctests into the right testsuite)
Failed merges:
- #161702 (Use `drop_guard` in some places in {core,alloc,std})
@rust-bors
rust-borsBot
merged commit 984e522
into
rust-lang:mainAug 30, 2026

14 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 30, 2026
@bors
Unrolled build for#160941in rollup 161990
71fc40e
Rollup merge of #160941 - nia-e:alloc-safety-comments, r=clarfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 30, 2026
@DanielEScherzerDanielEScherzer
mentioned this pull request
Sep 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@clarfontheyclarfontheyclarfonthey left review comments

+1 more reviewer

@DanielEScherzerDanielEScherzerDanielEScherzer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@clarfontheyclarfonthey

Labels

A-tidyArea: The tidy toolS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nia-e@JonathanBrouwer@clarfonthey@ChrisDenton@rust-log-analyzer@rustbot@DanielEScherzer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Enforce safety comments on alloc - #160941
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Aug 30, 2026
Merged
Enforce safety comments on alloc#160941
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Conversation
@nia-e
@nia-enia-e
commented
Aug 11, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Aug 11, 2026
@nia-e
nia-e
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
This will break a lot of ppl's CI ^^
@bors rollup=never
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'm not convinced rollup=never actually helps. This kind of PR is likely to have soft conflicts (i.e. someone adds an unsafe block between this PR being opened and merged), but rollup=never doesn't help detecting those. In fact, it makes them worse because soft conflicts may get detected in PR CI/try jobs of rollups and not waste queue time. My primary recommendation to help with this would be to reduce the time between PR open and r+, and rebase before r+ if this is more than a few days
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
@bors rollup=iffy p=1 likely to soft conflict

p=1 does help because it makes you get into rollups earlier reducing time between pr open & merge
@nia-e
nia-e
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
...i completely forgot to actually push the commit with all my manual work. apologies 🫠
@clarfonthey
clarfonthey
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Oh, I didn't know that you were actually going through and adding comments to these. I'd, probably want to do an actual review in that case.
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/btree/mem.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/drain.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/ffi/c_str.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/raw_vec/mod.rs
type Cap = core::num::niche_types::UsizeNoHighBit;

// SAFETY: Untriaged.
// SAFETY: 0 *definitely* is less than isize::MAX.
@clarfontheyclarfontheyAug 12, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how can you be sure?
View changes since the review
@nia-enia-eAug 12, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy: isize was defined before 2025 and therefore there were affordable computers around that had to address more than 0 bytes of memory!
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@clarfonthey
clarfonthey
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
(apologies for merging some conflicting PRs. wouldn't mind helping rebase if this is getting difficult to manage)
@nia-e
tidy: enforce documented unsafe in alloc
f1f423d
safety comments in alloc
this was pain and it's not even half i think
oepsje woepsje
@nia-e
update some comments
483873e
@nia-e
nia-eforce-pushed
the
alloc-safety-comments
branch
from
75cc497 to
483873eCompareAugust 28, 2026 21:56
@rustbot
rustbot
commented
Aug 28, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@nia-e
nia-e
commented
Aug 28, 2026

Copy link


Copy Markdown

MemberAuthor
think this is done and mergeable now. rebased on main, so it shouldn't conflict much i hope?
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 28, 2026
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Okay, that was painful, but reviewed.
@bors try
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#160941- nia-e:alloc-safety-comments, r=<try>
8e834e4
Enforce safety comments on `alloc`
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Recommended merge command assuming try passes:
r=clarfonthey p=1 note="Affects entire alloc crate, can easily go stale"
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Also fine with you just rebasing this yourself and merging in case of conflicts, assuming you mark new blocks as ignored instead of trying to determine what their comments should be.
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8e834e4 (8e834e4af0546ff9e43f5ddca26d6ea6c9305778)

Base parent: 6bb812b (6bb812b714cce8e08864b7b569303f25ab08eaad)
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
@bors r+ p=1 note="Affects entire alloc crate, can easily go stale"
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 483873e has been approved by clarfonthey
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 29, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
213016c
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
ed10cbd
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 29, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#161990- GuillaumeGomez:rollup-jrJIOEF, r=GuillaumeGomez
4545c83
Rollup of 7 pull requests
Successful merges:
- #160941 (Enforce safety comments on `alloc`)
- #161975 (Abort instead of unwinding out of an inconsistent BTreeMap::split_off)
- #157968 (Preserve ambiguous glob lint for subtrait method picks)
- #161514 (rework handling of doc attributes on macro calls)
- #161944 (rustdoc: Take into account edition information for keyword highlighting)
- #161974 (remove rustc_never_type_options attr remnants)
- #161978 (Move rustdoc ui doctests into the right testsuite)
Failed merges:
- #161702 (Use `drop_guard` in some places in {core,alloc,std})
@rust-bors
rust-borsBot
merged commit 984e522
into
rust-lang:mainAug 30, 2026

14 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 30, 2026
@bors
Unrolled build for#160941in rollup 161990
71fc40e
Rollup merge of #160941 - nia-e:alloc-safety-comments, r=clarfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 30, 2026
@DanielEScherzerDanielEScherzer
mentioned this pull request
Sep 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@clarfontheyclarfontheyclarfonthey left review comments

+1 more reviewer

@DanielEScherzerDanielEScherzerDanielEScherzer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@clarfontheyclarfonthey

Labels

A-tidyArea: The tidy toolS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nia-e@JonathanBrouwer@clarfonthey@ChrisDenton@rust-log-analyzer@rustbot@DanielEScherzer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enforce safety comments on alloc - #160941
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Aug 30, 2026
Merged
Enforce safety comments on alloc#160941
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Conversation
@nia-e
@nia-enia-e
commented
Aug 11, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Aug 11, 2026
@nia-e
nia-e
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
This will break a lot of ppl's CI ^^
@bors rollup=never
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'm not convinced rollup=never actually helps. This kind of PR is likely to have soft conflicts (i.e. someone adds an unsafe block between this PR being opened and merged), but rollup=never doesn't help detecting those. In fact, it makes them worse because soft conflicts may get detected in PR CI/try jobs of rollups and not waste queue time. My primary recommendation to help with this would be to reduce the time between PR open and r+, and rebase before r+ if this is more than a few days
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
@bors rollup=iffy p=1 likely to soft conflict

p=1 does help because it makes you get into rollups earlier reducing time between pr open & merge
@nia-e
nia-e
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
...i completely forgot to actually push the commit with all my manual work. apologies 🫠
@clarfonthey
clarfonthey
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Oh, I didn't know that you were actually going through and adding comments to these. I'd, probably want to do an actual review in that case.
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/btree/mem.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/drain.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/ffi/c_str.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/raw_vec/mod.rs
type Cap = core::num::niche_types::UsizeNoHighBit;

// SAFETY: Untriaged.
// SAFETY: 0 *definitely* is less than isize::MAX.
@clarfontheyclarfontheyAug 12, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how can you be sure?
View changes since the review
@nia-enia-eAug 12, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy: isize was defined before 2025 and therefore there were affordable computers around that had to address more than 0 bytes of memory!
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@clarfonthey
clarfonthey
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
(apologies for merging some conflicting PRs. wouldn't mind helping rebase if this is getting difficult to manage)
@nia-e
tidy: enforce documented unsafe in alloc
f1f423d
safety comments in alloc
this was pain and it's not even half i think
oepsje woepsje
@nia-e
update some comments
483873e
@nia-e
nia-eforce-pushed
the
alloc-safety-comments
branch
from
75cc497 to
483873eCompareAugust 28, 2026 21:56
@rustbot
rustbot
commented
Aug 28, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@nia-e
nia-e
commented
Aug 28, 2026

Copy link


Copy Markdown

MemberAuthor
think this is done and mergeable now. rebased on main, so it shouldn't conflict much i hope?
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 28, 2026
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Okay, that was painful, but reviewed.
@bors try
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#160941- nia-e:alloc-safety-comments, r=<try>
8e834e4
Enforce safety comments on `alloc`
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Recommended merge command assuming try passes:
r=clarfonthey p=1 note="Affects entire alloc crate, can easily go stale"
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Also fine with you just rebasing this yourself and merging in case of conflicts, assuming you mark new blocks as ignored instead of trying to determine what their comments should be.
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8e834e4 (8e834e4af0546ff9e43f5ddca26d6ea6c9305778)

Base parent: 6bb812b (6bb812b714cce8e08864b7b569303f25ab08eaad)
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
@bors r+ p=1 note="Affects entire alloc crate, can easily go stale"
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 483873e has been approved by clarfonthey
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 29, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
213016c
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
ed10cbd
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 29, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#161990- GuillaumeGomez:rollup-jrJIOEF, r=GuillaumeGomez
4545c83
Rollup of 7 pull requests
Successful merges:
- #160941 (Enforce safety comments on `alloc`)
- #161975 (Abort instead of unwinding out of an inconsistent BTreeMap::split_off)
- #157968 (Preserve ambiguous glob lint for subtrait method picks)
- #161514 (rework handling of doc attributes on macro calls)
- #161944 (rustdoc: Take into account edition information for keyword highlighting)
- #161974 (remove rustc_never_type_options attr remnants)
- #161978 (Move rustdoc ui doctests into the right testsuite)
Failed merges:
- #161702 (Use `drop_guard` in some places in {core,alloc,std})
@rust-bors
rust-borsBot
merged commit 984e522
into
rust-lang:mainAug 30, 2026

14 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 30, 2026
@bors
Unrolled build for#160941in rollup 161990
71fc40e
Rollup merge of #160941 - nia-e:alloc-safety-comments, r=clarfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 30, 2026
@DanielEScherzerDanielEScherzer
mentioned this pull request
Sep 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@clarfontheyclarfontheyclarfonthey left review comments

+1 more reviewer

@DanielEScherzerDanielEScherzerDanielEScherzer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@clarfontheyclarfonthey

Labels

A-tidyArea: The tidy toolS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nia-e@JonathanBrouwer@clarfonthey@ChrisDenton@rust-log-analyzer@rustbot@DanielEScherzer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enforce safety comments on alloc - #160941
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Aug 30, 2026
Merged
Enforce safety comments on alloc#160941
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Conversation
@nia-e
@nia-enia-e
commented
Aug 11, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Aug 11, 2026
@nia-e
nia-e
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
This will break a lot of ppl's CI ^^
@bors rollup=never
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'm not convinced rollup=never actually helps. This kind of PR is likely to have soft conflicts (i.e. someone adds an unsafe block between this PR being opened and merged), but rollup=never doesn't help detecting those. In fact, it makes them worse because soft conflicts may get detected in PR CI/try jobs of rollups and not waste queue time. My primary recommendation to help with this would be to reduce the time between PR open and r+, and rebase before r+ if this is more than a few days
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
@bors rollup=iffy p=1 likely to soft conflict

p=1 does help because it makes you get into rollups earlier reducing time between pr open & merge
@nia-e
nia-e
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
...i completely forgot to actually push the commit with all my manual work. apologies 🫠
@clarfonthey
clarfonthey
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Oh, I didn't know that you were actually going through and adding comments to these. I'd, probably want to do an actual review in that case.
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/btree/mem.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/drain.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/ffi/c_str.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/raw_vec/mod.rs
type Cap = core::num::niche_types::UsizeNoHighBit;

// SAFETY: Untriaged.
// SAFETY: 0 *definitely* is less than isize::MAX.
@clarfontheyclarfontheyAug 12, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how can you be sure?
View changes since the review
@nia-enia-eAug 12, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy: isize was defined before 2025 and therefore there were affordable computers around that had to address more than 0 bytes of memory!
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@clarfonthey
clarfonthey
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
(apologies for merging some conflicting PRs. wouldn't mind helping rebase if this is getting difficult to manage)
@nia-e
tidy: enforce documented unsafe in alloc
f1f423d
safety comments in alloc
this was pain and it's not even half i think
oepsje woepsje
@nia-e
update some comments
483873e
@nia-e
nia-eforce-pushed
the
alloc-safety-comments
branch
from
75cc497 to
483873eCompareAugust 28, 2026 21:56
@rustbot
rustbot
commented
Aug 28, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@nia-e
nia-e
commented
Aug 28, 2026

Copy link


Copy Markdown

MemberAuthor
think this is done and mergeable now. rebased on main, so it shouldn't conflict much i hope?
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 28, 2026
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Okay, that was painful, but reviewed.
@bors try
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#160941- nia-e:alloc-safety-comments, r=<try>
8e834e4
Enforce safety comments on `alloc`
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Recommended merge command assuming try passes:
r=clarfonthey p=1 note="Affects entire alloc crate, can easily go stale"
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Also fine with you just rebasing this yourself and merging in case of conflicts, assuming you mark new blocks as ignored instead of trying to determine what their comments should be.
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8e834e4 (8e834e4af0546ff9e43f5ddca26d6ea6c9305778)

Base parent: 6bb812b (6bb812b714cce8e08864b7b569303f25ab08eaad)
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
@bors r+ p=1 note="Affects entire alloc crate, can easily go stale"
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 483873e has been approved by clarfonthey
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 29, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
213016c
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
ed10cbd
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 29, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#161990- GuillaumeGomez:rollup-jrJIOEF, r=GuillaumeGomez
4545c83
Rollup of 7 pull requests
Successful merges:
- #160941 (Enforce safety comments on `alloc`)
- #161975 (Abort instead of unwinding out of an inconsistent BTreeMap::split_off)
- #157968 (Preserve ambiguous glob lint for subtrait method picks)
- #161514 (rework handling of doc attributes on macro calls)
- #161944 (rustdoc: Take into account edition information for keyword highlighting)
- #161974 (remove rustc_never_type_options attr remnants)
- #161978 (Move rustdoc ui doctests into the right testsuite)
Failed merges:
- #161702 (Use `drop_guard` in some places in {core,alloc,std})
@rust-bors
rust-borsBot
merged commit 984e522
into
rust-lang:mainAug 30, 2026

14 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 30, 2026
@bors
Unrolled build for#160941in rollup 161990
71fc40e
Rollup merge of #160941 - nia-e:alloc-safety-comments, r=clarfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 30, 2026
@DanielEScherzerDanielEScherzer
mentioned this pull request
Sep 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@clarfontheyclarfontheyclarfonthey left review comments

+1 more reviewer

@DanielEScherzerDanielEScherzerDanielEScherzer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@clarfontheyclarfonthey

Labels

A-tidyArea: The tidy toolS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nia-e@JonathanBrouwer@clarfonthey@ChrisDenton@rust-log-analyzer@rustbot@DanielEScherzer

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Enforce safety comments on alloc - #160941
Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Aug 30, 2026
Merged
Enforce safety comments on alloc#160941
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom 
nia-e:alloc-safety-comments
Conversation
@nia-e
@nia-enia-e
commented
Aug 11, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added

A-tidy
Area: The tidy tool
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Aug 11, 2026
@nia-e
nia-e
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
This will break a lot of ppl's CI ^^
@bors rollup=never
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026•

edited

Loading

Copy link


Copy Markdown

Member
I'm not convinced rollup=never actually helps. This kind of PR is likely to have soft conflicts (i.e. someone adds an unsafe block between this PR being opened and merged), but rollup=never doesn't help detecting those. In fact, it makes them worse because soft conflicts may get detected in PR CI/try jobs of rollups and not waste queue time. My primary recommendation to help with this would be to reduce the time between PR open and r+, and rebase before r+ if this is more than a few days
@JonathanBrouwer
JonathanBrouwer
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
@bors rollup=iffy p=1 likely to soft conflict

p=1 does help because it makes you get into rollups earlier reducing time between pr open & merge
@nia-e
nia-e
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
...i completely forgot to actually push the commit with all my manual work. apologies 🫠
@clarfonthey
clarfonthey
commented
Aug 12, 2026

Copy link


Copy Markdown

Contributor
Oh, I didn't know that you were actually going through and adding comments to these. I'd, probably want to do an actual review in that case.
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/boxed/thin.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/binary_heap/mod.rs
clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/btree/mem.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/drain.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/collections/vec_deque/spec_extend.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/ffi/c_str.rs
Outdated

clarfonthey
clarfonthey
reviewed
Aug 12, 2026
View reviewed changes
Comment threadlibrary/alloc/src/raw_vec/mod.rs
type Cap = core::num::niche_types::UsizeNoHighBit;

// SAFETY: Untriaged.
// SAFETY: 0 *definitely* is less than isize::MAX.
@clarfontheyclarfontheyAug 12, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how can you be sure?
View changes since the review
@nia-enia-eAug 12, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy: isize was defined before 2025 and therefore there were affordable computers around that had to address more than 0 bytes of memory!
@rustbotrustbot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 21, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@clarfonthey
clarfonthey
commented
Aug 21, 2026

Copy link


Copy Markdown

Contributor
(apologies for merging some conflicting PRs. wouldn't mind helping rebase if this is getting difficult to manage)
@nia-e
tidy: enforce documented unsafe in alloc
f1f423d
safety comments in alloc
this was pain and it's not even half i think
oepsje woepsje
@nia-e
update some comments
483873e
@nia-e
nia-eforce-pushed
the
alloc-safety-comments
branch
from
75cc497 to
483873eCompareAugust 28, 2026 21:56
@rustbot
rustbot
commented
Aug 28, 2026

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@nia-e
nia-e
commented
Aug 28, 2026

Copy link


Copy Markdown

MemberAuthor
think this is done and mergeable now. rebased on main, so it shouldn't conflict much i hope?
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 28, 2026
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Okay, that was painful, but reviewed.
@bors try
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#160941- nia-e:alloc-safety-comments, r=<try>
8e834e4
Enforce safety comments on `alloc`
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Recommended merge command assuming try passes:
r=clarfonthey p=1 note="Affects entire alloc crate, can easily go stale"
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
Also fine with you just rebasing this yourself and merging in case of conflicts, assuming you mark new blocks as ignored instead of trying to determine what their comments should be.
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 8e834e4 (8e834e4af0546ff9e43f5ddca26d6ea6c9305778)

Base parent: 6bb812b (6bb812b714cce8e08864b7b569303f25ab08eaad)
@clarfonthey
clarfonthey
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
@bors r+ p=1 note="Affects entire alloc crate, can easily go stale"
@rust-bors
rust-borsBot
commented
Aug 29, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 483873e has been approved by clarfonthey
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 29, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
213016c
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160941- nia-e:alloc-safety-comments, r=cla…
ed10cbd
…rfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from rust-lang#160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Aug 29, 2026
 Closed

@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 29, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 29, 2026
@bors
Auto merge of#161990- GuillaumeGomez:rollup-jrJIOEF, r=GuillaumeGomez
4545c83
Rollup of 7 pull requests
Successful merges:
- #160941 (Enforce safety comments on `alloc`)
- #161975 (Abort instead of unwinding out of an inconsistent BTreeMap::split_off)
- #157968 (Preserve ambiguous glob lint for subtrait method picks)
- #161514 (rework handling of doc attributes on macro calls)
- #161944 (rustdoc: Take into account edition information for keyword highlighting)
- #161974 (remove rustc_never_type_options attr remnants)
- #161978 (Move rustdoc ui doctests into the right testsuite)
Failed merges:
- #161702 (Use `drop_guard` in some places in {core,alloc,std})
@rust-bors
rust-borsBot
merged commit 984e522
into
rust-lang:mainAug 30, 2026

14 checks passed

rust-borsBot
pushed a commit
that referenced
this pull request
Aug 30, 2026
@bors
Unrolled build for#160941in rollup 161990
71fc40e
Rollup merge of #160941 - nia-e:alloc-safety-comments, r=clarfonthey
Enforce safety comments on `alloc`
cc @clarfonthey, @workingjubilee. Following up from #160824. I spent a painfully long time going over the comments and ensuring there's nothing too awful ^^
r? clarfonthey
@rustbotrustbot
added this to the 1.100.0 milestone
Aug 30, 2026
@DanielEScherzerDanielEScherzer
mentioned this pull request
Sep 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@clarfontheyclarfontheyclarfonthey left review comments

+1 more reviewer

@DanielEScherzerDanielEScherzerDanielEScherzer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@clarfontheyclarfonthey

Labels

A-tidyArea: The tidy toolS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nia-e@JonathanBrouwer@clarfonthey@ChrisDenton@rust-log-analyzer@rustbot@DanielEScherzer