Skip to content

Rollup of 4 pull requests - #160992

Closed
JonathanBrouwer wants to merge 16 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-ddGVF23
Closed

Rollup of 4 pull requests#160992
JonathanBrouwer wants to merge 16 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-ddGVF23

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost

Create a similar rollup

GuillaumeGomezand others added 16 commits August 12, 2026 14:48
Currently it will always load proc-macros for the host. In the future it
may also start loading wasm proc-macros. This way rust-analyzer doesn't
have to pick between both options itself.
…notriddle
Add new rustdoc `broken_footnote` lint
I think in this case, instead of spawning `unpportable_markdown`, we should instead notify that this footnote reference doesn't have an associated definition.
r? @notriddle
…rk-Simulacrum
Remove target argument from get_proc_macros
Currently it will always load proc-macros for the host. In the future it may also start loading wasm proc-macros. This way rust-analyzer doesn't have to pick between both options itself.
Part of rust-lang#160389
…stion, r=chenyukang
rustc_parse: suggest removing semicolon before `if` block
Closesrust-lang#159812
Suggest removing semicolon before the block in an `if` expression
…r=JonathanBrouwer
Remove old cfg parser which is now dead code
Since rustdoc was fully migrated to the new `cfg` parser, this code can be removed.
r? @JonathanBrouwer
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Aug 12, 2026
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 12, 2026
@JonathanBrouwer

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-1,aarch64-apple-2,x86_64-mingw-1,i686-msvc-1,i686-msvc-2

@rust-bors

rust-borsBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 97d9fcc has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2026
@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Aug 12, 2026
Rollup of 4 pull requests
try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-1
try-job: aarch64-apple-2
try-job: x86_64-mingw-1
try-job: i686-msvc-1
try-job: i686-msvc-2
@rust-bors

rust-borsBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit 97d9fcc with merge 5883e30...

Workflow: https://github.com/rust-lang/rust/actions/runs/31623644276

rust-borsBot pushed a commit that referenced this pull request Aug 12, 2026
…uwer
Rollup of 4 pull requests
Successful merges:
- #137803 (Add new rustdoc `broken_footnote` lint)
- #160975 (Remove target argument from get_proc_macros)
- #160861 (rustc_parse: suggest removing semicolon before `if` block)
- #160990 (Remove old cfg parser which is now dead code)
Failed merges:
- #137858 (Add new `unused_footnote_definition` rustdoc lint)
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-mingw-1 failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src`
Currently active steps:
test::Crate { build_compiler: Compiler { stage: 2, host: x86_64-pc-windows-gnu, forced_compiler: false }, target: x86_64-pc-windows-gnu, mode: Std, crates: ["alloc", "alloctests", "compiler_builtins", "core", "coretests", "panic_abort", "panic_unwind", "proc_macro", "rustc-std-workspace-core", "std", "std_detect", "sysroot", "test", "unwind"] } at src\bootstrap\src\core\build_steps\test.rs:3455
Build completed unsuccessfully in 2:04:38
make: *** [Makefile:126: ci-mingw-x] Error 1
local time: Wed Aug 12 18:03:08 CUT 2026
network time: Wed, 12 Aug 2026 18:03:09 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 12, 2026
@rust-bors

rust-borsBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 1e7fb68 failed: CI. Failed jobs:

@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 12, 2026
@rust-bors

rust-borsBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

PR #137803, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 12, 2026
@JonathanBrouwer
JonathanBrouwer deleted the rollup-ddGVF23 branch August 21, 2026 08:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rust-analyzerRelevant to the rust-analyzer team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@JonathanBrouwer@rust-log-analyzer@rustbot@GuillaumeGomez@notriddle@bjorn3@ravlynd