Skip to content

Output tests/debuginfo raw JSON data on failure in CI - #162002

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Walnut356:json_dump
Aug 31, 2026
Merged

Output tests/debuginfo raw JSON data on failure in CI#162002
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Walnut356:json_dump

Conversation

@Walnut356

Copy link
Copy Markdown
Contributor

As discussed a few days ago, this change allows people to "manually bless" in cases where they do not have access to the target that caused the failure in CI. When run outside of CI, no json is dumped (since it's assumed you're running it locally and thus can just use --bless).

It makes things a lot easier (for the user) to present this as minified, single-line json, but obviously we'd prefer if it's formatted after they copypaste it. Maybe a tidy pass to enforce that? I'm not sure if we have anything that currently handles JSON, but I can look into it.

r? @Kobzol , @jieyouxu

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@Kobzol

Copy link
Copy Markdown
Member

Thanks! Do you have a link to a job where this happened, so I can take a look at it?

In general, this is a nice improvement, though not perfect by far (but that is for follow-up PRs). If this happens for multiple tests and/or OSes, it would be annoying to manually update all that. I wonder if we could generate a single git patch file that could then be updated as a GitHub Actions artifact, and after download you could just git apply it away. But as I said, that's not for this PR :)

@Walnut356

Walnut356 commented Aug 31, 2026

Copy link
Copy Markdown
ContributorAuthor

Should be this one: #161574 (comment)

Though that run didnt have the "use this to bless" tip, just the raw json.

@Kobzol

Copy link
Copy Markdown
Member

Thanks. It is a bit non-trivial to copy, but better than nothing. Thanks! Let's land this as an initial implementation.

@bors r+ rollup

@rust-bors

rust-borsBot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1b0c94c has been approved by Kobzol

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 31, 2026
Output `tests/debuginfo` raw JSON data on failure in CI
As discussed a few days ago, this change allows people to "manually bless" in cases where they do not have access to the target that caused the failure in CI. When run outside of CI, no json is dumped (since it's assumed you're running it locally and thus can just use `--bless`).
It makes things a lot easier (for the user) to present this as minified, single-line json, but obviously we'd prefer if it's formatted after they copypaste it. Maybe a tidy pass to enforce that? I'm not sure if we have anything that currently handles JSON, but I can look into it.
r? @Kobzol , @jieyouxu
@ZalatharZalathar mentioned this pull request Aug 31, 2026
rust-borsBot pushed a commit that referenced this pull request Aug 31, 2026
Rollup of 5 pull requests
Successful merges:
- #161556 (document some rustc_dump attributes)
- #161353 (Add test for parallel compiler reproducible build)
- #161776 (Add a couple polonius tests and move universal region liveness generation)
- #162002 (Output `tests/debuginfo` raw JSON data on failure in CI)
- #162049 (Fix a compile error on the ESP-IDF target)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 31, 2026
Output `tests/debuginfo` raw JSON data on failure in CI
As discussed a few days ago, this change allows people to "manually bless" in cases where they do not have access to the target that caused the failure in CI. When run outside of CI, no json is dumped (since it's assumed you're running it locally and thus can just use `--bless`).
It makes things a lot easier (for the user) to present this as minified, single-line json, but obviously we'd prefer if it's formatted after they copypaste it. Maybe a tidy pass to enforce that? I'm not sure if we have anything that currently handles JSON, but I can look into it.
r? @Kobzol , @jieyouxu
This was referenced Aug 31, 2026
rust-borsBot pushed a commit that referenced this pull request Aug 31, 2026
…uwer
Rollup of 6 pull requests
Successful merges:
- #162058 (Port 1.98.1 release notes into main)
- #161556 (document some rustc_dump attributes)
- #161776 (Add a couple polonius tests and move universal region liveness generation)
- #162002 (Output `tests/debuginfo` raw JSON data on failure in CI)
- #162049 (Fix a compile error on the ESP-IDF target)
- #162054 (Refine InferCtxtInner docs)
rust-borsBot pushed a commit that referenced this pull request Aug 31, 2026
…uwer
Rollup of 6 pull requests
Successful merges:
- #162058 (Port 1.98.1 release notes into main)
- #161556 (document some rustc_dump attributes)
- #161776 (Add a couple polonius tests and move universal region liveness generation)
- #162002 (Output `tests/debuginfo` raw JSON data on failure in CI)
- #162049 (Fix a compile error on the ESP-IDF target)
- #162054 (Refine InferCtxtInner docs)
rust-borsBot pushed a commit that referenced this pull request Aug 31, 2026
…uwer
Rollup of 6 pull requests
Successful merges:
- #162058 (Port 1.98.1 release notes into main)
- #161556 (document some rustc_dump attributes)
- #161776 (Add a couple polonius tests and move universal region liveness generation)
- #162002 (Output `tests/debuginfo` raw JSON data on failure in CI)
- #162049 (Fix a compile error on the ESP-IDF target)
- #162054 (Refine InferCtxtInner docs)
@rust-bors
rust-borsBot merged commit 38359d0 into rust-lang:mainAug 31, 2026
13 checks passed
@rustbotrustbot added this to the 1.100.0 milestone Aug 31, 2026
rust-borsBot pushed a commit that referenced this pull request Aug 31, 2026
Rollup merge of #162002 - Walnut356:json_dump, r=Kobzol
Output `tests/debuginfo` raw JSON data on failure in CI
As discussed a few days ago, this change allows people to "manually bless" in cases where they do not have access to the target that caused the failure in CI. When run outside of CI, no json is dumped (since it's assumed you're running it locally and thus can just use `--bless`).
It makes things a lot easier (for the user) to present this as minified, single-line json, but obviously we'd prefer if it's formatted after they copypaste it. Maybe a tidy pass to enforce that? I'm not sure if we have anything that currently handles JSON, but I can look into it.
r? @Kobzol , @jieyouxu
@Walnut356
Walnut356 deleted the json_dump branch September 1, 2026 06:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Walnut356@rustbot@Kobzol