Move more rustdoc-html tests using --test into the right folder - #162014

Open
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom
GuillaumeGomez:more-ui-tests
Open

Move more rustdoc-html tests using --test into the right folder#162014
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom
GuillaumeGomez:more-ui-tests

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Aug 30, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Follow-up of #161944.

I double-checked if more rustdoc-html tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).

Oh also second commit is me realizing that some ui tests were using compile-args (which doesn't exist anymore) and without @. Anyway, fixed that too.

r? @fmease

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 30, 2026
fmease
fmease reviewed Aug 30, 2026
View reviewed changes

@fmeasefmease left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of 1st commit

View changes since this review

Comment threadtests/rustdoc-ui/doctest/async-move-doctest.stdout Outdated
Comment threadtests/rustdoc-ui/doctest/comment-in-doctest.stdout Outdated
Comment threadtests/rustdoc-ui/doctest/edition-doctest.stdout Outdated
Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs Outdated
Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
fmease
fmease approved these changes Aug 30, 2026
View reviewed changes

@fmeasefmease left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot!

I wonder if we should at some point modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea

r=me once nits addressed

View changes since this review

Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs Outdated
Comment on lines +1 to +2
//@ compile-flags: --crate-type lib

@fmeasefmeaseAug 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//@ compile-flags: --crate-type lib

or remove it altogether since it's not really relevant (rustdoc doesn't look for main even if the crate type is bin)

@GuillaumeGomezGuillaumeGomezAug 30, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah actually I need to remove it.

Comment threadtests/ui/lint/forbid-error-capped.rs Outdated
@fmeasefmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2026
@GuillaumeGomez

GuillaumeGomez commented Aug 30, 2026

Copy link
Copy Markdown
MemberAuthor

I wonder if we should modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea

On it. ;)

I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).

fmease
fmease reviewed Aug 30, 2026
View reviewed changes
Comment threadtests/ui/lint/forbid-error-capped.rs
@@ -1,5 +1,4 @@
//@ check-pass
// compile-args: --cap-lints=warn -Fwarnings

@fmeasefmeaseAug 30, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this should be converted to //@ compile-flags like you did before. This test specifically intended to test the interaction between --cap-lints=warn and -Fwarnings as the paragraph states below.

Or did that lead to a failure? If so we might want to open a GH issue & investigate further.

View changes since the review

fmease
fmease reviewed Aug 30, 2026
View reviewed changes
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs Outdated

@fmeasefmeaseAug 30, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental removal while trying to apply #162014 (comment) (there's still the corresp. *.stderr file)?.

View changes since the review

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomezGuillaumeGomez mentioned this pull request Aug 30, 2026
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez

GuillaumeGomez commented Aug 31, 2026

Copy link
Copy Markdown
MemberAuthor

@bors r=fmease rollup

@rust-bors

rust-borsBot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 614d9ea has been approved by fmease

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 31, 2026
@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 31, 2026
@rustbot

rustbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 31, 2026
@rust-bors

rust-borsBot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

⚠️ A new commit fa9cd5bd4c583c3b5311698485482ad514026c30 was pushed.

This pull request was unapproved.

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2026
@rust-bors

rust-borsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#162100), which was unapproved.

View changes since this unapproval

@GuillaumeGomez

GuillaumeGomez commented Sep 1, 2026

Copy link
Copy Markdown
MemberAuthor

@bors r=fmease rollup

@rust-bors

rust-borsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 92e4d2a has been approved by fmease

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2026
@GuillaumeGomez

GuillaumeGomez commented Sep 1, 2026

Copy link
Copy Markdown
MemberAuthor

@bors r-

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2026
@rust-bors

rust-borsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

@GuillaumeGomez

GuillaumeGomez commented Sep 1, 2026

Copy link
Copy Markdown
MemberAuthor

Now it's good.

@bors r=fmease rollup

@rust-bors

rust-borsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 5ba810f has been approved by fmease

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
e29ea40
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer mentioned this pull request Sep 1, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
d57a39f
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer mentioned this pull request Sep 1, 2026
Closed
@JonathanBrouwer

JonathanBrouwer commented Sep 1, 2026

Copy link
Copy Markdown
Member

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #162139 (comment)

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2026
@rust-bors

rust-borsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#162139), which was unapproved.

View changes since this unapproval

@GuillaumeGomez

GuillaumeGomez commented Sep 1, 2026

Copy link
Copy Markdown
MemberAuthor

Arf, a test stdout was only generated on mac. Talk about bad luck. :')

@bors try jobs=aarch64-apple-1

@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot pushed a commit that referenced this pull request Sep 1, 2026
@bors
Auto merge of#162014- GuillaumeGomez:more-ui-tests, r=<try>
0878440
Move more `rustdoc-html` tests using `--test` into the right folder
try-job: aarch64-apple-1
@rust-bors

rust-borsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 0878440 (08784406009b5f42c6a6fe27bd3a37e454f83d55)
Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmeasefmeasefmease approved these changes

Assignees

@fmeasefmease

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-log-analyzer@rustbot@jhpratt@JonathanBrouwer@fmease
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Move more rustdoc-html tests using --test into the right folder - #162014
Open
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Open
Move more rustdoc-html tests using --test into the right folder#162014
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Aug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Follow-up of #161944.
I double-checked if more rustdoc-html tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
Oh also second commit is me realizing that some ui tests were using compile-args (which doesn't exist anymore) and without @. Anyway, fixed that too.
r? @fmease
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Aug 30, 2026
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of 1st commit
View changes since this review
Comment threadtests/rustdoc-ui/doctest/async-move-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/comment-in-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/edition-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
fmease
fmease
approved these changes
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot!
I wonder if we should at some point modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
r=me once nits addressed
View changes since this review
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated


Comment on lines

+1
 to 
+2

//@ compile-flags: --crate-type lib

@fmeasefmeaseAug 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

//@ compile-flags: --crate-type lib
or remove it altogether since it's not really relevant (rustdoc doesn't look for main even if the crate type is bin)
@GuillaumeGomezGuillaumeGomezAug 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah actually I need to remove it.
Comment threadtests/ui/lint/forbid-error-capped.rs
Outdated

@fmeasefmease
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 30, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Aug 30, 2026

Copy link


Copy Markdown

MemberAuthor
I wonder if we should modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
On it. ;)
I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/ui/lint/forbid-error-capped.rs
@@ -1,5 +1,4 @@
//@ check-pass
// compile-args: --cap-lints=warn -Fwarnings
@fmeasefmeaseAug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this should be converted to //@ compile-flags like you did before. This test specifically intended to test the interaction between --cap-lints=warn and -Fwarnings as the paragraph states below.
Or did that lead to a failure? If so we might want to open a GH issue & investigate further.
View changes since the review
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated

@fmeasefmeaseAug 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental removal while trying to apply #162014 (comment) (there's still the corresp. *.stderr file)?.
View changes since the review
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 30, 2026
 Open

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
GuillaumeGomez
commented
Aug 31, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 614d9ea has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 31, 2026
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 31, 2026
@rustbot
rustbot
commented
Aug 31, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Aug 31, 2026
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
⚠️ A new commit fa9cd5bd4c583c3b5311698485482ad514026c30 was pushed.
This pull request was unapproved.
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162100), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 92e4d2a has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r-
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Now it's good.
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 5ba810f has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
e29ea40
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
d57a39f
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Sep 1, 2026

Copy link


Copy Markdown

Member
💔 I suspect this PR failed tests as part of a rollup
@bors r-
After fixing the problem, consider running a try job for the failed job before re-approving.
Link to failure: #162139 (comment)
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162139), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Arf, a test stdout was only generated on mac. Talk about bad luck. :')
@bors try jobs=aarch64-apple-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Sep 1, 2026
@bors
Auto merge of#162014- GuillaumeGomez:more-ui-tests, r=<try>
0878440
Move more `rustdoc-html` tests using `--test` into the right folder
try-job: aarch64-apple-1
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 0878440 (08784406009b5f42c6a6fe27bd3a37e454f83d55)

Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fmeasefmeasefmease approved these changes

Assignees

@fmeasefmease

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-log-analyzer@rustbot@jhpratt@JonathanBrouwer@fmease

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Move more rustdoc-html tests using --test into the right folder - #162014
Open
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Open
Move more rustdoc-html tests using --test into the right folder#162014
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Aug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Follow-up of #161944.
I double-checked if more rustdoc-html tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
Oh also second commit is me realizing that some ui tests were using compile-args (which doesn't exist anymore) and without @. Anyway, fixed that too.
r? @fmease
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Aug 30, 2026
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of 1st commit
View changes since this review
Comment threadtests/rustdoc-ui/doctest/async-move-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/comment-in-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/edition-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
fmease
fmease
approved these changes
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot!
I wonder if we should at some point modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
r=me once nits addressed
View changes since this review
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated


Comment on lines

+1
 to 
+2

//@ compile-flags: --crate-type lib

@fmeasefmeaseAug 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

//@ compile-flags: --crate-type lib
or remove it altogether since it's not really relevant (rustdoc doesn't look for main even if the crate type is bin)
@GuillaumeGomezGuillaumeGomezAug 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah actually I need to remove it.
Comment threadtests/ui/lint/forbid-error-capped.rs
Outdated

@fmeasefmease
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 30, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Aug 30, 2026

Copy link


Copy Markdown

MemberAuthor
I wonder if we should modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
On it. ;)
I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/ui/lint/forbid-error-capped.rs
@@ -1,5 +1,4 @@
//@ check-pass
// compile-args: --cap-lints=warn -Fwarnings
@fmeasefmeaseAug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this should be converted to //@ compile-flags like you did before. This test specifically intended to test the interaction between --cap-lints=warn and -Fwarnings as the paragraph states below.
Or did that lead to a failure? If so we might want to open a GH issue & investigate further.
View changes since the review
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated

@fmeasefmeaseAug 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental removal while trying to apply #162014 (comment) (there's still the corresp. *.stderr file)?.
View changes since the review
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 30, 2026
 Open

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
GuillaumeGomez
commented
Aug 31, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 614d9ea has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 31, 2026
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 31, 2026
@rustbot
rustbot
commented
Aug 31, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Aug 31, 2026
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
⚠️ A new commit fa9cd5bd4c583c3b5311698485482ad514026c30 was pushed.
This pull request was unapproved.
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162100), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 92e4d2a has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r-
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Now it's good.
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 5ba810f has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
e29ea40
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
d57a39f
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Sep 1, 2026

Copy link


Copy Markdown

Member
💔 I suspect this PR failed tests as part of a rollup
@bors r-
After fixing the problem, consider running a try job for the failed job before re-approving.
Link to failure: #162139 (comment)
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162139), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Arf, a test stdout was only generated on mac. Talk about bad luck. :')
@bors try jobs=aarch64-apple-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Sep 1, 2026
@bors
Auto merge of#162014- GuillaumeGomez:more-ui-tests, r=<try>
0878440
Move more `rustdoc-html` tests using `--test` into the right folder
try-job: aarch64-apple-1
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 0878440 (08784406009b5f42c6a6fe27bd3a37e454f83d55)

Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fmeasefmeasefmease approved these changes

Assignees

@fmeasefmease

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-log-analyzer@rustbot@jhpratt@JonathanBrouwer@fmease

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Move more rustdoc-html tests using --test into the right folder - #162014
Open
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Open
Move more rustdoc-html tests using --test into the right folder#162014
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Aug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Follow-up of #161944.
I double-checked if more rustdoc-html tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
Oh also second commit is me realizing that some ui tests were using compile-args (which doesn't exist anymore) and without @. Anyway, fixed that too.
r? @fmease
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Aug 30, 2026
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of 1st commit
View changes since this review
Comment threadtests/rustdoc-ui/doctest/async-move-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/comment-in-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/edition-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
fmease
fmease
approved these changes
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot!
I wonder if we should at some point modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
r=me once nits addressed
View changes since this review
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated


Comment on lines

+1
 to 
+2

//@ compile-flags: --crate-type lib

@fmeasefmeaseAug 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

//@ compile-flags: --crate-type lib
or remove it altogether since it's not really relevant (rustdoc doesn't look for main even if the crate type is bin)
@GuillaumeGomezGuillaumeGomezAug 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah actually I need to remove it.
Comment threadtests/ui/lint/forbid-error-capped.rs
Outdated

@fmeasefmease
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 30, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Aug 30, 2026

Copy link


Copy Markdown

MemberAuthor
I wonder if we should modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
On it. ;)
I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/ui/lint/forbid-error-capped.rs
@@ -1,5 +1,4 @@
//@ check-pass
// compile-args: --cap-lints=warn -Fwarnings
@fmeasefmeaseAug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this should be converted to //@ compile-flags like you did before. This test specifically intended to test the interaction between --cap-lints=warn and -Fwarnings as the paragraph states below.
Or did that lead to a failure? If so we might want to open a GH issue & investigate further.
View changes since the review
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated

@fmeasefmeaseAug 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental removal while trying to apply #162014 (comment) (there's still the corresp. *.stderr file)?.
View changes since the review
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 30, 2026
 Open

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
GuillaumeGomez
commented
Aug 31, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 614d9ea has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 31, 2026
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 31, 2026
@rustbot
rustbot
commented
Aug 31, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Aug 31, 2026
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
⚠️ A new commit fa9cd5bd4c583c3b5311698485482ad514026c30 was pushed.
This pull request was unapproved.
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162100), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 92e4d2a has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r-
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Now it's good.
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 5ba810f has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
e29ea40
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
d57a39f
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Sep 1, 2026

Copy link


Copy Markdown

Member
💔 I suspect this PR failed tests as part of a rollup
@bors r-
After fixing the problem, consider running a try job for the failed job before re-approving.
Link to failure: #162139 (comment)
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162139), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Arf, a test stdout was only generated on mac. Talk about bad luck. :')
@bors try jobs=aarch64-apple-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Sep 1, 2026
@bors
Auto merge of#162014- GuillaumeGomez:more-ui-tests, r=<try>
0878440
Move more `rustdoc-html` tests using `--test` into the right folder
try-job: aarch64-apple-1
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 0878440 (08784406009b5f42c6a6fe27bd3a37e454f83d55)

Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fmeasefmeasefmease approved these changes

Assignees

@fmeasefmease

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-log-analyzer@rustbot@jhpratt@JonathanBrouwer@fmease

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Move more rustdoc-html tests using --test into the right folder - #162014
Open
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Open
Move more rustdoc-html tests using --test into the right folder#162014
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Aug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Follow-up of #161944.
I double-checked if more rustdoc-html tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
Oh also second commit is me realizing that some ui tests were using compile-args (which doesn't exist anymore) and without @. Anyway, fixed that too.
r? @fmease
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Aug 30, 2026
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of 1st commit
View changes since this review
Comment threadtests/rustdoc-ui/doctest/async-move-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/comment-in-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/edition-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
fmease
fmease
approved these changes
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot!
I wonder if we should at some point modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
r=me once nits addressed
View changes since this review
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated


Comment on lines

+1
 to 
+2

//@ compile-flags: --crate-type lib

@fmeasefmeaseAug 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

//@ compile-flags: --crate-type lib
or remove it altogether since it's not really relevant (rustdoc doesn't look for main even if the crate type is bin)
@GuillaumeGomezGuillaumeGomezAug 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah actually I need to remove it.
Comment threadtests/ui/lint/forbid-error-capped.rs
Outdated

@fmeasefmease
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 30, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Aug 30, 2026

Copy link


Copy Markdown

MemberAuthor
I wonder if we should modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
On it. ;)
I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/ui/lint/forbid-error-capped.rs
@@ -1,5 +1,4 @@
//@ check-pass
// compile-args: --cap-lints=warn -Fwarnings
@fmeasefmeaseAug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this should be converted to //@ compile-flags like you did before. This test specifically intended to test the interaction between --cap-lints=warn and -Fwarnings as the paragraph states below.
Or did that lead to a failure? If so we might want to open a GH issue & investigate further.
View changes since the review
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated

@fmeasefmeaseAug 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental removal while trying to apply #162014 (comment) (there's still the corresp. *.stderr file)?.
View changes since the review
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 30, 2026
 Open

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
GuillaumeGomez
commented
Aug 31, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 614d9ea has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 31, 2026
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 31, 2026
@rustbot
rustbot
commented
Aug 31, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Aug 31, 2026
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
⚠️ A new commit fa9cd5bd4c583c3b5311698485482ad514026c30 was pushed.
This pull request was unapproved.
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162100), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 92e4d2a has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r-
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Now it's good.
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 5ba810f has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
e29ea40
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
d57a39f
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Sep 1, 2026

Copy link


Copy Markdown

Member
💔 I suspect this PR failed tests as part of a rollup
@bors r-
After fixing the problem, consider running a try job for the failed job before re-approving.
Link to failure: #162139 (comment)
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162139), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Arf, a test stdout was only generated on mac. Talk about bad luck. :')
@bors try jobs=aarch64-apple-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Sep 1, 2026
@bors
Auto merge of#162014- GuillaumeGomez:more-ui-tests, r=<try>
0878440
Move more `rustdoc-html` tests using `--test` into the right folder
try-job: aarch64-apple-1
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 0878440 (08784406009b5f42c6a6fe27bd3a37e454f83d55)

Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fmeasefmeasefmease approved these changes

Assignees

@fmeasefmease

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-log-analyzer@rustbot@jhpratt@JonathanBrouwer@fmease

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Move more rustdoc-html tests using --test into the right folder - #162014
Open
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Open
Move more rustdoc-html tests using --test into the right folder#162014
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Aug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Follow-up of #161944.
I double-checked if more rustdoc-html tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
Oh also second commit is me realizing that some ui tests were using compile-args (which doesn't exist anymore) and without @. Anyway, fixed that too.
r? @fmease
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Aug 30, 2026
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of 1st commit
View changes since this review
Comment threadtests/rustdoc-ui/doctest/async-move-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/comment-in-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/edition-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
fmease
fmease
approved these changes
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot!
I wonder if we should at some point modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
r=me once nits addressed
View changes since this review
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated


Comment on lines

+1
 to 
+2

//@ compile-flags: --crate-type lib

@fmeasefmeaseAug 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

//@ compile-flags: --crate-type lib
or remove it altogether since it's not really relevant (rustdoc doesn't look for main even if the crate type is bin)
@GuillaumeGomezGuillaumeGomezAug 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah actually I need to remove it.
Comment threadtests/ui/lint/forbid-error-capped.rs
Outdated

@fmeasefmease
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 30, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Aug 30, 2026

Copy link


Copy Markdown

MemberAuthor
I wonder if we should modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
On it. ;)
I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/ui/lint/forbid-error-capped.rs
@@ -1,5 +1,4 @@
//@ check-pass
// compile-args: --cap-lints=warn -Fwarnings
@fmeasefmeaseAug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this should be converted to //@ compile-flags like you did before. This test specifically intended to test the interaction between --cap-lints=warn and -Fwarnings as the paragraph states below.
Or did that lead to a failure? If so we might want to open a GH issue & investigate further.
View changes since the review
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated

@fmeasefmeaseAug 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental removal while trying to apply #162014 (comment) (there's still the corresp. *.stderr file)?.
View changes since the review
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 30, 2026
 Open

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
GuillaumeGomez
commented
Aug 31, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 614d9ea has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 31, 2026
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 31, 2026
@rustbot
rustbot
commented
Aug 31, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Aug 31, 2026
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
⚠️ A new commit fa9cd5bd4c583c3b5311698485482ad514026c30 was pushed.
This pull request was unapproved.
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162100), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 92e4d2a has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r-
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Now it's good.
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 5ba810f has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
e29ea40
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
d57a39f
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Sep 1, 2026

Copy link


Copy Markdown

Member
💔 I suspect this PR failed tests as part of a rollup
@bors r-
After fixing the problem, consider running a try job for the failed job before re-approving.
Link to failure: #162139 (comment)
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162139), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Arf, a test stdout was only generated on mac. Talk about bad luck. :')
@bors try jobs=aarch64-apple-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Sep 1, 2026
@bors
Auto merge of#162014- GuillaumeGomez:more-ui-tests, r=<try>
0878440
Move more `rustdoc-html` tests using `--test` into the right folder
try-job: aarch64-apple-1
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 0878440 (08784406009b5f42c6a6fe27bd3a37e454f83d55)

Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fmeasefmeasefmease approved these changes

Assignees

@fmeasefmease

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-log-analyzer@rustbot@jhpratt@JonathanBrouwer@fmease

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Move more rustdoc-html tests using --test into the right folder - #162014
Open
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Open
Move more rustdoc-html tests using --test into the right folder#162014
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Aug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Follow-up of #161944.
I double-checked if more rustdoc-html tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
Oh also second commit is me realizing that some ui tests were using compile-args (which doesn't exist anymore) and without @. Anyway, fixed that too.
r? @fmease
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Aug 30, 2026
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of 1st commit
View changes since this review
Comment threadtests/rustdoc-ui/doctest/async-move-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/comment-in-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/edition-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
fmease
fmease
approved these changes
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot!
I wonder if we should at some point modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
r=me once nits addressed
View changes since this review
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated


Comment on lines

+1
 to 
+2

//@ compile-flags: --crate-type lib

@fmeasefmeaseAug 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

//@ compile-flags: --crate-type lib
or remove it altogether since it's not really relevant (rustdoc doesn't look for main even if the crate type is bin)
@GuillaumeGomezGuillaumeGomezAug 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah actually I need to remove it.
Comment threadtests/ui/lint/forbid-error-capped.rs
Outdated

@fmeasefmease
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 30, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Aug 30, 2026

Copy link


Copy Markdown

MemberAuthor
I wonder if we should modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
On it. ;)
I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/ui/lint/forbid-error-capped.rs
@@ -1,5 +1,4 @@
//@ check-pass
// compile-args: --cap-lints=warn -Fwarnings
@fmeasefmeaseAug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this should be converted to //@ compile-flags like you did before. This test specifically intended to test the interaction between --cap-lints=warn and -Fwarnings as the paragraph states below.
Or did that lead to a failure? If so we might want to open a GH issue & investigate further.
View changes since the review
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated

@fmeasefmeaseAug 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental removal while trying to apply #162014 (comment) (there's still the corresp. *.stderr file)?.
View changes since the review
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 30, 2026
 Open

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
GuillaumeGomez
commented
Aug 31, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 614d9ea has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 31, 2026
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 31, 2026
@rustbot
rustbot
commented
Aug 31, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Aug 31, 2026
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
⚠️ A new commit fa9cd5bd4c583c3b5311698485482ad514026c30 was pushed.
This pull request was unapproved.
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162100), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 92e4d2a has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r-
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Now it's good.
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 5ba810f has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
e29ea40
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
d57a39f
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Sep 1, 2026

Copy link


Copy Markdown

Member
💔 I suspect this PR failed tests as part of a rollup
@bors r-
After fixing the problem, consider running a try job for the failed job before re-approving.
Link to failure: #162139 (comment)
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162139), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Arf, a test stdout was only generated on mac. Talk about bad luck. :')
@bors try jobs=aarch64-apple-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Sep 1, 2026
@bors
Auto merge of#162014- GuillaumeGomez:more-ui-tests, r=<try>
0878440
Move more `rustdoc-html` tests using `--test` into the right folder
try-job: aarch64-apple-1
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 0878440 (08784406009b5f42c6a6fe27bd3a37e454f83d55)

Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fmeasefmeasefmease approved these changes

Assignees

@fmeasefmease

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-log-analyzer@rustbot@jhpratt@JonathanBrouwer@fmease

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Move more rustdoc-html tests using --test into the right folder - #162014
Open
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Open
Move more rustdoc-html tests using --test into the right folder#162014
GuillaumeGomez wants to merge 4 commits into
rust-lang:mainfrom 
GuillaumeGomez:more-ui-tests
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Aug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Follow-up of #161944.
I double-checked if more rustdoc-html tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
Oh also second commit is me realizing that some ui tests were using compile-args (which doesn't exist anymore) and without @. Anyway, fixed that too.
r? @fmease
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Aug 30, 2026
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of 1st commit
View changes since this review
Comment threadtests/rustdoc-ui/doctest/async-move-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/comment-in-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/edition-doctest.stdout
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
Outdated

Comment threadtests/rustdoc-ui/doctest/force-target-feature.rs
fmease
fmease
approved these changes
Aug 30, 2026
View reviewed changes
@fmeasefmease
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot!
I wonder if we should at some point modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
r=me once nits addressed
View changes since this review
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated


Comment on lines

+1
 to 
+2

//@ compile-flags: --crate-type lib

@fmeasefmeaseAug 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

//@ compile-flags: --crate-type lib
or remove it altogether since it's not really relevant (rustdoc doesn't look for main even if the crate type is bin)
@GuillaumeGomezGuillaumeGomezAug 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah actually I need to remove it.
Comment threadtests/ui/lint/forbid-error-capped.rs
Outdated

@fmeasefmease
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 30, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Aug 30, 2026

Copy link


Copy Markdown

MemberAuthor
I wonder if we should modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea
On it. ;)
I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/ui/lint/forbid-error-capped.rs
@@ -1,5 +1,4 @@
//@ check-pass
// compile-args: --cap-lints=warn -Fwarnings
@fmeasefmeaseAug 30, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this should be converted to //@ compile-flags like you did before. This test specifically intended to test the interaction between --cap-lints=warn and -Fwarnings as the paragraph states below.
Or did that lead to a failure? If so we might want to open a GH issue & investigate further.
View changes since the review
fmease
fmease
reviewed
Aug 30, 2026
View reviewed changes
Comment threadtests/rustdoc-ui/lints/renamed-lint-still-applies.rs
Outdated

@fmeasefmeaseAug 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental removal while trying to apply #162014 (comment) (there's still the corresp. *.stderr file)?.
View changes since the review
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Aug 30, 2026
 Open

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
GuillaumeGomez
commented
Aug 31, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 614d9ea has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 31, 2026
@rust-borsrust-borsBot
added
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 31, 2026
@rustbot
rustbot
commented
Aug 31, 2026

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rust-borsrust-borsBot
removed
the 
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Aug 31, 2026
@rust-bors
rust-borsBot
commented
Aug 31, 2026

Copy link


Copy Markdown

Contributor
⚠️ A new commit fa9cd5bd4c583c3b5311698485482ad514026c30 was pushed.
This pull request was unapproved.
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162100), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 92e4d2a has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r-
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Now it's good.
@bors r=fmease rollup
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 5ba810f has been approved by fmease
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
e29ea40
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#162014- GuillaumeGomez:more-ui-tests, r=fm…
d57a39f
…ease
Move more `rustdoc-html` tests using `--test` into the right folder
Follow-up of rust-lang#161944.
I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing).
Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too.
r? @fmease
@JonathanBrouwerJonathanBrouwer
mentioned this pull request
Sep 1, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Sep 1, 2026

Copy link


Copy Markdown

Member
💔 I suspect this PR failed tests as part of a rollup
@bors r-
After fixing the problem, consider running a try job for the failed job before re-approving.
Link to failure: #162139 (comment)
@rust-borsrust-borsBot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Sep 1, 2026
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
This pull request was unapproved.
This PR was contained in a rollup (#162139), which was unapproved.
View changes since this unapproval
@GuillaumeGomez
GuillaumeGomez
commented
Sep 1, 2026

Copy link


Copy Markdown

MemberAuthor
Arf, a test stdout was only generated on mac. Talk about bad luck. :')
@bors try jobs=aarch64-apple-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Sep 1, 2026
@bors
Auto merge of#162014- GuillaumeGomez:more-ui-tests, r=<try>
0878440
Move more `rustdoc-html` tests using `--test` into the right folder
try-job: aarch64-apple-1
@rust-bors
rust-borsBot
commented
Sep 1, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 0878440 (08784406009b5f42c6a6fe27bd3a37e454f83d55)

Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@fmeasefmeasefmease approved these changes

Assignees

@fmeasefmease

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-log-analyzer@rustbot@jhpratt@JonathanBrouwer@fmease