Uh oh!
There was an error while loading. Please reload this page.
librustc: Stop assuming that implementations and traits only contain - #16286
Merged
Conversation
pcwalton
commented
Aug 7, 2014
ContributorAuthor
nikomatsakis
commented
Aug 8, 2014
Contributor
r+ |
sfackler
commented
Aug 8, 2014
Member
Needs a rebase |
nrc
commented
Aug 9, 2014
Member
Sorry I missed the review ping - gmail spam-filtered the email for me :-( |
methods.
This paves the way to associated items by introducing an extra level of
abstraction ("impl-or-trait item") between traits/implementations and
methods. This new abstraction is encoded in the metadata and used
throughout the compiler where appropriate.
There are no functional changes; this is purely a refactoring.bors added a commit
that referenced
this pull request
Aug 14, 2014
…ikomatsakis
methods.
This paves the way to associated items by introducing an extra level of
abstraction ("impl-or-trait item") between traits/implementations and
methods. This new abstraction is encoded in the metadata and used
throughout the compiler where appropriate.
There are no functional changes; this is purely a refactoring.
r? @nick29581lnicola pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 29, 2024
…ebold internal: Be more resilient to bad language item definitions in binop inference Fixesrust-lang#16287Fixesrust-lang#16286 There's one more in `write_fn_trait_method_resolution`, but I'm not sure if it won't cause further problems in `infer_closures`.
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 25, 2025
…{} else {}` expressions (rust-lang#16286)
If two `if` arms contain only a single `if {..} else {..}` statement,
don't suggest a collapse as this can lead to less readable code.
Fixesrust-lang/rust-clippy#4971
changelog: [`collapsible_else_if`]: prevent emitting lint when the all
`if` arms contain only an `if {..} else {..}` expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
methods.
This paves the way to associated items by introducing an extra level of
abstraction ("impl-or-trait item") between traits/implementations and
methods. This new abstraction is encoded in the metadata and used
throughout the compiler where appropriate.
There are no functional changes; this is purely a refactoring.
r? @nick29581