Skip to content

Cleanup some fixed Windows issues - #16450

Merged
bors merged 2 commits into
rust-lang:masterfrom
klutzy:win-fixme-cleanup
Aug 18, 2014
Merged

Cleanup some fixed Windows issues#16450
bors merged 2 commits into
rust-lang:masterfrom
klutzy:win-fixme-cleanup

Conversation

@klutzy

Copy link
Copy Markdown
Contributor

First commit enables regex test on Windows. It was not working at some point (#13725), but it works now.

Second commit removes various FIXMEs regarding #13793, since upstream bug has been fixed.

@alexcrichton

Copy link
Copy Markdown
Member

You may want to back out the addition of --gc-sections, perhaps that's causing trouble?

@brson

Copy link
Copy Markdown
Contributor

😍 @klutzy!

@klutzy

Copy link
Copy Markdown
ContributorAuthor

Retracted #13846. It seems blocked by other issue.

@alexcrichton

Copy link
Copy Markdown
Member

(needs a rebase)

@klutzy

Copy link
Copy Markdown
ContributorAuthor

rebased!

bors added a commit that referenced this pull request Aug 18, 2014
First commit enables regex test on Windows. It was not working at some point (#13725), but it works now.
Second commit removes various FIXMEs regarding #13793, since upstream bug has been fixed.
@borsbors closed this Aug 18, 2014
@bors
bors merged commit 4806746 into rust-lang:masterAug 18, 2014
@klutzy
klutzy deleted the win-fixme-cleanup branch October 10, 2014 20:27
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
…ykril
internal: Prepare parser interface for editions
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
…icola
minor: Fix `rustc_skip_array_during_method_dispatch` edition check
CC rust-lang#16450
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
…ykril
internal: Prepare parser interface for editions
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
…icola
minor: Fix `rustc_skip_array_during_method_dispatch` edition check
CC rust-lang#16450
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@klutzy@alexcrichton@brson@bors