Uh oh!
There was an error while loading. Please reload this page.
Extend #[deriving(...)] helpers to expose field attributes - #17089
Closed
erickt wants to merge 7 commits into
Closed
Extend #[deriving(...)] helpers to expose field attributes#17089erickt wants to merge 7 commits into
erickt wants to merge 7 commits into
Conversation
brson
commented
Sep 12, 2014
Contributor
cc @huonw@nikomatsakis Somebody should have an opinion on this. |
lilyball
commented
Sep 15, 2014
Contributor
I like this. We still need to figure out a generic way of customizing deriving, but having access to field attributes is going to be necessary. |
erickt
commented
Sep 23, 2014
ContributorAuthor
@kballard: thanks for checking it out. I'm going to close this now, because I think I found a better way to do this that should also simplify down how to write |
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 11, 2026
changelog: none r? ada4a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds field attribute support to the
syntax::ext::derivinglibrary. This allows#[deriving(...)]handlers to work with attributes. For example, this could enable the#[deriving(Encodable, Decodable)]to customize how a field name is serialized, which is useful if implementing a schema that uses a field name that is a rust keyword.This also includes some minor cleanup of a couple bits of
libsyntax.