Uh oh!
There was an error while loading. Please reload this page.
Generalize MacExpr / MacPat / MacItems - #18814
Conversation
gamazeps
commented
Nov 9, 2014
r? @kmcallister |
kmcallister
commented
Nov 9, 2014
I don't have review privs on rust-lang/rust, but I added some comments. |
gamazeps
commented
Nov 9, 2014
The blak lines are not present in the other Mac* so I didn't put them in MacGeneral for consistency, but I can add the blank lines |
bstrie
commented
Nov 20, 2014
This looks like an alternate approach to #19019 . Would anyone like to mediate between the two? |
flaper87
commented
Jan 14, 2015
@gamazeps any chance you can address the comments on this patch? Do you want one of us to take it and fix the minor issues? also, is this still needed? |
huonw
commented
Jan 22, 2015
r? @kmcallister (just making sure the PR has an assignee, I think you have review privileges now?) |
kmcallister
commented
Feb 27, 2015
This doesn't really resolve #17637; it should also remove the special-purpose types. The patch has some other problems; I'm working on a revived PR. |
MacEager is a MacResult implementation for the common case where you've already built each form of AST that you might return. Fixesrust-lang#17637. Based on rust-lang#18814. This is a [breaking-change] for syntax extensions: * MacExpr::new becomes MacEager::expr. * MacPat::new becomes MacEager::pat. * MacItems::new becomes MacEager::items. It takes a SmallVector directly, not an iterator. r? @sfackler
Might be a bit clumsy ...
Closes#17637