Skip to content

Use FnvHashMap instead of HashMap in rustc - #18821

Merged
bors merged 1 commit into
rust-lang:masterfrom
arielb1:fnv-hash-map
Nov 11, 2014
Merged

Use FnvHashMap instead of HashMap in rustc#18821
bors merged 1 commit into
rust-lang:masterfrom
arielb1:fnv-hash-map

Conversation

@arielb1

@arielb1 arielb1 commented Nov 9, 2014

Copy link
Copy Markdown
Contributor

This should improve performance

@eddyb

eddyb commented Nov 10, 2014

Copy link
Copy Markdown
Contributor

And determinism, thanks!

@huonw

huonw commented Nov 10, 2014

Copy link
Copy Markdown
Contributor

Would it be possible to measure compiling e.g. librustc before and after this change? (Changes like this can occasionally cause slowdowns, e.g. a lower quality hash can result in more collisions. I find it unlikely that this will be the case, but it would be nice to confirm.)

@ghost

ghost commented Nov 10, 2014

Copy link
Copy Markdown

It'd be nice to test #17872 and #15034 with this change. I assume they can both be considered fixed.

@ghost

ghost commented Nov 10, 2014

Copy link
Copy Markdown

@arielb1 Great PR! :-)

bors added a commit that referenced this pull request Nov 11, 2014
@bors bors closed this Nov 11, 2014
@bors
bors merged commit 85f1262 into rust-lang:master Nov 11, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Jan 7, 2025
feat: Support the new `CoercePointee` derive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants