Uh oh!
There was an error while loading. Please reload this page.
Mark Any::get_type_id as experimental - #19223
Conversation
It is likely going to be removed and replaced with an associated static. Fixesrust-lang#19222
79945fa to
4705475Compareemberian
commented
Nov 23, 2014
cc @aturon |
alexcrichton
commented
Nov 23, 2014
I don't think that associated statics are on the roadmap for 1.0, so this may have to be stable at 1.0 due to a lack of other method of implementing it. |
aturon
commented
Nov 23, 2014
That was my initial thought, but we don't necessarily need to expose the type_id aspect here in the stable channel for 1.0; we could still stabilize the checked downcasting based on it. @reem how would you feel about |
emberian
commented
Nov 23, 2014
Is there a reason something can't be |
aturon
commented
Nov 23, 2014
@cmr Experimental/unstable items can be used internally in As far as the broader policy point, it's all laid out in the blog post on stability. |
reem
commented
Nov 23, 2014
@aturon as long as Ideally we'd get associated statics, but if that's impossible I can just redo this out of tree (that's what I did when AnyPrivate was private). |
reem
commented
Nov 24, 2014
Just bothered to look at TypeId's docs and it is clearly marked experimental. If both this and TypeId are unavailable on the stable version of Rust, then neither Hyper nor Iron are going to build on 1.0. That would be pretty unfortunate, but I'd honestly take the hit over |
aturon
commented
Nov 24, 2014
@reem As we discussed above, marking this as (BTW, we are planning to run an initial 1.0 beta cycle where the stability lints are turned on, but where you can still use unstable features on the stable channel; that will help us discover things like |
reem
commented
Nov 24, 2014
@aturon That sounds great. I figured that TypeId would remain experimental just because it seems like such a raw tool that it wouldn't be finished yet, but certain parts of it could easily be marked stable. For instance, it would be easy to maintain backwards compatibility of |
aturon
commented
Nov 24, 2014
@reem But you do rely on it implementing |
reem
commented
Nov 24, 2014
@aturon Yes, |
aturon
commented
Nov 24, 2014
@reem Ah, I see: there's an inherent Great, this sounds quite doable. I will make sure |
aturon
commented
Nov 24, 2014
@reem BTW, I just posted a comment with some more details about the stabilization status and plans. |
It is likely going to be removed and replaced with an associated static.
…t-feature fix: Support target features implications in target_feature 1.1
It is likely going to be removed and replaced
with an associated static.