Remove `proc` from the language by nikomatsakis · Pull Request #19338 · rust-lang/rust

nikomatsakis · 2014-11-26T16:13:41Z

They are replaced with unboxed closures.

This is a [breaking-change]. Mostly, uses of proc() simply need to be converted to move|| (unboxed closures), but in some cases the adaptations required are more complex (particularly for library authors). A detailed write-up can be found here: http://smallcultfollowing.com/babysteps/blog/2014/11/26/purging-proc/

The commits are ordered to emphasize the more important changes, but are not truly standalone.

rust-highfive · 2014-11-26T16:13:46Z

Warning

These commits modify unsafe code. Please review it carefully!

thestinger · 2014-11-26T16:15:21Z

This is awesome! I was afraid proc() was going to end up staying around as a compatibility shim.

alexcrichton · 2014-11-26T17:08:14Z

@nikomatsakis could you make sure that at least one of the commits if flagged as a breaking-change along with some clear documentation of how to migrate? It would also be nice to expand a bit on migration path for the consuming side you alluded to in the description.

alexcrichton · 2014-11-26T17:11:56Z

I added some comments to a previous set of commits, and my high level comments were:

I think there were a few tests that were removed but could be added back in.
It'd be nice to have some documentation for std::thunk::Thunk

Other than that, and the comments in the previous commits, r=me, thanks so much @nikomatsakis!

sinistersnare · 2014-11-26T20:51:43Z

s/form/from

nikomatsakis · 2014-11-26T22:04:37Z

Blog post explaining the high-level details: http://smallcultfollowing.com/babysteps/blog/2014/11/26/purging-proc/

nikomatsakis · 2014-11-26T22:05:31Z

@alexcrichton the breaking change annotation is in the PR header, and I included a link to my blog post. I believe that shows up in the merge commit, right?

michaelwoerister · 2014-11-27T08:24:06Z

cc me

@nikomatsakis

…, r=alexcrichton This PR lets `rustc` generate debuginfo for variables captured by unboxed closures. Fixes#19356 @nikomatsakis This PR will probably conflict with #19338. If this gets merged before, you should be able to just leave the test case as it is (maybe remove the `#![feature(unboxed_closures)]` directive).

nikomatsakis · 2014-12-02T15:09:59Z

Status: semi-blocked on #19438

boxed `FnOnce` closures.

…ethod. Besides being yucky, it will cause problems if we try to make all traits implement themselves, which would make a lot of things in life easier. Also, it was inextricably linked to `Box`, which was not the intention. We can work around its absence, so better to reimplement it later in a more thorough fashion.

with the fn traits

language. Recommend `move||` instead.

to prevent such oversights in the future.

…nk::new`)

duplicate tests around object types.

cc @steveklabnick

… PR rust-lang#19438

@pcwalton

…oc, r=acrichto They are replaced with unboxed closures. cc @pcwalton @aturon This is a [breaking-change]. Mostly, uses of `proc()` simply need to be converted to `move||` (unboxed closures), but in some cases the adaptations required are more complex (particularly for library authors). A detailed write-up can be found here: http://smallcultfollowing.com/babysteps/blog/2014/11/26/purging-proc/ The commits are ordered to emphasize the more important changes, but are not truly standalone.

zesterer · 2018-03-16T18:23:15Z

'proc' is a very useful keyword to have, particularly when one is writing an operating system. I suggest that it should no longer be a reserved word given that it no longer has semantic meaning.

nikomatsakis · 2018-03-19T19:57:04Z

@zesterer I agree. Care to open a PR? I think all you have to do is to remove this line:

rust/src/libsyntax_pos/symbol.rs

Line 317 in a04b88d

(49,Proc,"proc")

If you do, add r? @nikomatsakis into the PR description.

zesterer · 2018-03-19T21:22:51Z

I've never opened a Rust PR before. Have you any advice on how best to word things?

tshepang · 2018-03-19T21:42:39Z

I would...

remove 'proc' from keyword list
'proc' is a very useful keyword to have, particularly when one is writing an operating system. It is removed from reserve keyword, given that it no longer has semantic meaning.

nikomatsakis · 2018-03-20T16:14:42Z

@zesterer do you mean to word the PR description? If so, what @tshepang wrote sounds fine. We're not too formal on these sorts of things. =)

nikomatsakis force-pushed the unboxed-closure-purge-the-proc branch from ab70f27 to 491d3edCompare November 26, 2014 16:32

sinistersnare reviewed Nov 26, 2014
View reviewed changes

Comment threadsrc/doc/guide-tasks.md Outdated
sinistersnareNov 26, 2014
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/form/from

nikomatsakis changed the title ~~Remove proc types from the language~~Remove proc from the languageNov 26, 2014

nikomatsakis mentioned this pull request Nov 27, 2014
Fix debuginfo around move|| closures #19356
Closed

nikomatsakis force-pushed the unboxed-closure-purge-the-proc branch 2 times, most recently from 7f34f06 to 79ba682Compare November 27, 2014 11:44

nikomatsakis force-pushed the unboxed-closure-purge-the-proc branch from d8405fa to d51d810Compare November 27, 2014 12:32

michaelwoerister mentioned this pull request Nov 27, 2014
debuginfo: Make variables captured in unboxed closures available in debuginfo. #19363
Merged

nikomatsakis force-pushed the unboxed-closure-purge-the-proc branch from d51d810 to a6b5350Compare November 27, 2014 16:33

bvssvni mentioned this pull request Nov 30, 2014
Create a function create_sound_stream_stereo that creates a SoundStream PistonDevelopers/piston#748
Closed

tomaka mentioned this pull request Nov 30, 2014
Unboxed closure metabug #18101
Closed
47 tasks

nikomatsakis force-pushed the unboxed-closure-purge-the-proc branch 6 times, most recently from c876e97 to e2e8768Compare December 8, 2014 15:11

nikomatsakis added 13 commits December 14, 2014 04:21

Rewrite threading infrastructure, introducing Thunk to represent
d613381
boxed `FnOnce` closures.

Adjust feature gates to allow for parenthetical notation to be used
9cc8453
with the fn traits

Remove proc types/expressions from the parser, compiler, and
d258d68
language. Recommend `move||` instead.

Patch rustdoc to include missing types, make the match exhaustive
d8e51ea
to prevent such oversights in the future.

Rewrite WorkItem not to use proc().
394f684

Mostly rote conversion of proc() to move|| (and occasionally `Thu…
5c3d398
…nk::new`)

Delete tests that are either no longer relevant or which have
27676d9
duplicate tests around object types.

Update guide/intro to take into account the removal of proc.
112faab
cc @steveklabnick

Update emacs and vi modes.
0fefd83

Add some tests for obsolete code, sugar used in appropriate ways.
9c9253e

Temporarily remove issuerust-lang#14039; it is fixed and re-added by…
840ce00
… PR rust-lang#19438

Stop using diagnostics to avoid merge conflicts.
f6d60f3

nikomatsakis force-pushed the unboxed-closure-purge-the-proc branch from 7059ad8 to f6d60f3Compare December 14, 2014 09:22

bors closed this Dec 14, 2014

bors merged commit f6d60f3 into rust-lang:masterDec 14, 2014

This was referenced Dec 15, 2014
Rust update: Unboxed closures and removal of proc() chris-morgan/rust-http#188
Merged
Rust update: Remove proc and implementation of AnyRefExt for static NetworkStream hyperium/hyper#198
Merged

laumann mentioned this pull request Dec 16, 2014
ICE: task 'rustc' panicked at 'index out of bounds: the len is 0 but the index is 0', [...]/src/librustc/middle/typeck/check/mod.rs:2761 #19180
Closed

ozkriff mentioned this pull request Dec 22, 2014
Crashes on android after runtime removal rust-mobile/android-rs-glue#16
Closed

chenyukang mentioned this pull request Jan 21, 2015
Task ckkashyap/rustix#6
Merged

nikomatsakis deleted the unboxed-closure-purge-the-proc branch March 30, 2016 16:17

kngwyu mentioned this pull request Apr 12, 2018
Removed 'proc' from the reserved keywords list #49699
Merged

Uh oh!

Uh oh!

Conversation

nikomatsakis commented Nov 26, 2014

Uh oh!

rust-highfive commented Nov 26, 2014

Uh oh!

thestinger commented Nov 26, 2014

Uh oh!

alexcrichton commented Nov 26, 2014

Uh oh!

alexcrichton commented Nov 26, 2014

Uh oh!

sinistersnareNov 26, 2014

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Nov 26, 2014

Uh oh!

nikomatsakis commented Nov 26, 2014

Uh oh!

michaelwoerister commented Nov 27, 2014

Uh oh!

nikomatsakis commented Dec 2, 2014

Uh oh!

zesterer commented Mar 16, 2018

Uh oh!

nikomatsakis commented Mar 19, 2018

Uh oh!

zesterer commented Mar 19, 2018

Uh oh!

tshepang commented Mar 19, 2018

Uh oh!

nikomatsakis commented Mar 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants