Skip to content

Kill TreeMap, TreeSet, TrieMap, TrieSet, LruCache and EnumSet - #19955

Merged
bors merged 3 commits into
rust-lang:masterfrom
Gankra:kill-all-code
Dec 19, 2014
Merged

Kill TreeMap, TreeSet, TrieMap, TrieSet, LruCache and EnumSet#19955
bors merged 3 commits into
rust-lang:masterfrom
Gankra:kill-all-code

Conversation

@Gankra

@GankraGankra commented Dec 17, 2014

Copy link
Copy Markdown
Contributor

EnumSet lives on in libcollections so that librustc can still use it. This adds a direct dependency on libcollections to librustc and libserialize.

Should not be merged until rust-lang/rfcs#509 is accepted.

All of these collections have already been moved to collect-rs where they will ideally be maintained and experimented with, or will be replaced by something better: https://github.com/Gankro/collect-rs/

[breaking-change]

r? @aturon@alexcrichton

@GankraGankra changed the title Kill TreeMap, TreeSet, TrieMap, TrieSet, LruCachu and EnumSetKill TreeMap, TreeSet, TrieMap, TrieSet, LruCache and EnumSetDec 17, 2014
@killercup

Copy link
Copy Markdown
Contributor

@gankro I just noticed there are some FIXMEs with refs of rust issue numbers in here (e.g. here). Should those issues be closed or moved to the new repo?

@Gankra

Copy link
Copy Markdown
ContributorAuthor

Those are almost all general language issues, in my experience. e.g. the linked issue (#5244) is just that Variants and [elem, ..n] notation don't play well. We don't log many issues for specific collection flaws. I will update #8009, though.

@alexcrichton

Copy link
Copy Markdown
Member

This looks great, thanks @gankro!

@aturon

Copy link
Copy Markdown
Contributor

@gankro r=me after rebase/squash

@Gankra
Gankraforce-pushed the kill-all-code branch 2 times, most recently from 9e9768a to 7cb02a7CompareDecember 18, 2014 19:05
bors added a commit that referenced this pull request Dec 19, 2014
EnumSet lives on in libcollections so that librustc can still use it. This adds a direct dependency on libcollections to librustc and libserialize.
Should not be merged until rust-lang/rfcs#509 is accepted.
All of these collections have already been moved to collect-rs where they will ideally be maintained and experimented with, or will be replaced by something better: https://github.com/Gankro/collect-rs/
[breaking-change]
r? @aturon@alexcrichton
@bors
bors merged commit 67d3823 into rust-lang:masterDec 19, 2014
@tbu-

tbu- commented Dec 25, 2014

Copy link
Copy Markdown
Contributor

@gankro You write "Kill EnumSet", but it's still there?

@Gankra

Copy link
Copy Markdown
ContributorAuthor

@tbu- It's not in std anymore; only libcollections.

@ktt3jaktt3ja mentioned this pull request Feb 4, 2015
@pnkfelix

pnkfelix commented Sep 11, 2018

Copy link
Copy Markdown
Contributor

Hmm I think this PR accidentally destroyed the special \r\n characters that were here:

fnmain(){assert_eq!(b"",b"\
");
assert_eq!(b"\n",b"

This breaks the regression testing that we would want for #16278

(I only happened to notice their absence because I was wondering why this file was listed here:)

issue-16278.rs-text

kennytm added a commit to kennytm/rust that referenced this pull request Sep 12, 2018
…278, r=wesleywiser
Recover proper regression test for issue rust-lang#16278.
Spawned from my note rust-lang#19955 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Gankra@killercup@alexcrichton@aturon@tbu-@pnkfelix@bors