Renaming of the Iter types as in RFC #344

[1wilkens]

libcore: slice::Items -> slice::Iter, slice::MutItems -> slice::IterMut
libcollections: *::Items -> *::Iter, *::MoveItems -> *::IntoIter, *::MutItems -> *::IterMut

This is of course a [breaking-change].

Some Unstable attributes of functions affected might not longer need the attribute since the return type is now correctly named.

libstd::collections::hash is left out since the rename there is handled in a different PR as far as I know.

@gankro@aturon

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

[1wilkens]

Build/Tests are still running but I am optimistic :)

[csouth3]

Awesome work! :)
A couple of things that I see:
Looks like #19993 is taking care of the renaming for HashSet, but I think that you could do it for HashMap. Also, BTreeSet has set operation iterators that I think also should be renamed to match the methods that create them. E.g. in BTreeSet:
DifferenceItems -> Difference
SymDifferenceItems -> SymmetricDifference
UnionItems -> Union
IntersectionItems -> Intersection

[aturon]

See #20061 for slice/vec

[1wilkens]

@csouth3 Right, I'm on it!

[1wilkens]

I feel like I messed up the commits.. I rebased my fork from rust/master but now the PR includes these commits. That is not supposed to happen right?

[Gankra]

Normally I would git pull --rebase upstream master on the branch I want to update. Seems something went wrong for you, yeah. One thing you can do is git reset --hard bcfd6214e9c76263fa31 (I highly recommend creating a duplicate branch before doing this, in case something goes wrong).

[1wilkens]

Additional renames are up. Let me know if something is missing/should be changed

[csouth3]

New work looks good! Also, as @aturon mentioned, looks like he handles this work for slice (both libcollections and libcore) and vec in #20061. Unfortunately I think this means (though I'd wait for confirmation from him or @gankro) that you'll probably have to undo your changes to these files since most likely that pull request will land before yours :/

[Gankra]

I'm inclined to let this be first-come-first-serve, but aturon's gone for the holidays so that might be tricky.

Currently finishing up my exams; will review monday if no one else does first.

[1wilkens]

Yeah I skimmed through his PR. Would not be the biggest deal for me, since I had the learning experience anyway and the rest should still be useful.
He mentioned that he changed the structure of various files as well, so it might be more work to rebase his changes on my work instead of the other way round.
Like I said, it doesn't really matter to me, I am just happy I could contribute something useful :)

[csouth3]

Sounds good 👍
After taking another glance at his PR actually, looks like he goes to town on the rest of the iterators in libcore/slice.rs (for example the various Split and Chunk iters), but some of the changes going on with those guys are more significant refactors than just renaming, so it actually probably could work to land the renaming changes in this PR and then leave aturon's PR to do the more heavy lifting, so to speak (his already needs a rebase anyway)...

But, after all, I don't really have any say here, so might as well just wait until Gankro can review after the weekend.

Oh, and thanks again for doing this! :D

[alexcrichton]

Amazing! Thanks @MrFloya!

I agree with @gankro that the queue is basically a first-come-first-serve kinda world, so we'll see who has to rebase first! (dun dun dun!)

[1wilkens]

Okay so I rebased. This needs another r+ then right?

[alexcrichton]

Needs a rebase

[1wilkens]

Should be okay now. r?

[Gankra]

?

[1wilkens]

Okay I renamed the missing DifferenceItems and marked Clone [stable] again.