Uh oh!
There was an error while loading. Please reload this page.
Fix scoped thread local - #20262
Conversation
rust-highfive
commented
Dec 27, 2014
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
aturon
commented
Dec 27, 2014
Thanks for the PR! Could I ask you to add a regression test that would catch this problem? (I'm actually surprised it wasn't previously caught -- @alexcrichton might know more). |
alexcrichton
commented
Dec 28, 2014
Oddly enough it looks like the macro is a valid invocation when called inside of a function but not in an item scope! Not sure why this compiles in that case... |
arturoc
commented
Dec 28, 2014
just added the regression tests for the case in an item scope but not sure how you can test the opposite case where the current version should be failing inside a function |
alexcrichton
commented
Dec 28, 2014
Thanks! Could you also squash the commits together? |
de4025d to
156df26Compare156df26 to
598866dCompare598866d to
a454997Comparearturoc
commented
Dec 28, 2014
just squashed them, hadn't done this in a while and have done a couple of pushes before getting it right which has messed this view. the repo is ok though, with one commit only. |
was missing a couple of semicolons and applications using it failed to compile
fix: Fix search of raw labels and lifetimes
was missing a couple of semicolons and applications using it failed to compile