Skip to content

Match prose with code when discussing Ordering values - #21048

Merged
bors merged 1 commit into
rust-lang:masterfrom
aroben:patch-1
Jan 21, 2015
Merged

Match prose with code when discussing Ordering values#21048
bors merged 1 commit into
rust-lang:masterfrom
aroben:patch-1

Conversation

@aroben

@arobenaroben commented Jan 12, 2015

Copy link
Copy Markdown
Contributor

Now both the enum values and the prose describing them mention the values in the same order.

@aroben
Match prose with code when discussing Ordering values
1c0acb9
Now both the enum values and the prose describing them mention the values in the same order.
@rust-highfive

rust-highfive commented Jan 12, 2015

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton

alexcrichton commented Jan 20, 2015

Copy link
Copy Markdown
Member

r? @steveklabnik

@steveklabnik

steveklabnik commented Jan 20, 2015

Copy link
Copy Markdown
Contributor

@bors: r+ 1c0abc9

@bors

bors commented Jan 20, 2015

Copy link
Copy Markdown
Collaborator

🙀 You have the wrong number! Please try again with 1c0a.

@steveklabnik

steveklabnik commented Jan 20, 2015

Copy link
Copy Markdown
Contributor

@bors: r+ 1c0acb9

@steveklabnik

steveklabnik commented Jan 20, 2015

Copy link
Copy Markdown
Contributor

@bors: r+ 1c-acb9 rollup

@bors

bors commented Jan 20, 2015

Copy link
Copy Markdown
Collaborator

🙀 You have the wrong number! Please try again with 1c0a.

@steveklabnik

steveklabnik commented Jan 20, 2015

Copy link
Copy Markdown
Contributor

@bors: r+ 1c0acb9 rollup

barosl added a commit to barosl/rust that referenced this pull request Jan 20, 2015
@barosl
Rollup merge ofrust-lang#21048- aroben:patch-1, r=steveklabnik
b3f6e82
Now both the enum values and the prose describing them mention the values in the same order.
@baroslbarosl mentioned this pull request Jan 20, 2015
Closed
@bors
bors merged commit 1c0acb9 into rust-lang:masterJan 21, 2015
lnicola pushed a commit to lnicola/rust that referenced this pull request Nov 19, 2025
@ChayimFriedman2
Merge pull requestrust-lang#21048from A4-Tacks/no-mangle-static-no-…
da2aa3c
…incorrect-case
Fix hit incorrect_case on no_mangle static items
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aroben@rust-highfive@alexcrichton@steveklabnik@bors@huonw