Skip to content

Fix intro examples compilation warnings - #21121

Closed
raindev wants to merge 3 commits into
rust-lang:masterfrom
raindev:fix_intro_concurrency_examples
Closed

Fix intro examples compilation warnings#21121
raindev wants to merge 3 commits into
rust-lang:masterfrom
raindev:fix_intro_concurrency_examples

Conversation

@raindev

@raindevraindev commented Jan 13, 2015

Copy link
Copy Markdown
Contributor
  • Use range notation instead of deprecated range()
  • Remove deprecated u integer suffixes used in ranges
  • Replace deprecated i integer suffixes with is for vector numbers

Thread::spawn() still gives warning: use of unstable item: may change with specifics of new Send semantics warning which I hadn't found a way to fix. As long as I've found, it's related to rust-lang/rfcs#458 which hadn't been implemented yet.

Also I encountered two more example issues while going through the tutorial which aren't addressed in this PR:

  • compilation error of first Safety and Speed snippet (update: it should not compile, my bad)
  • the fact that spawned threads are detached by default. Such behaviour causes related examples to be a little bit confusing as the text doesn't mention this fact. It looks like the example was written when Thread::spawn behaviour was different.

Let me know if the two issue should be addressed in scope of this PR or in another one.

@rust-highfive

rust-highfive commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

steveklabnik
steveklabnik reviewed Jan 14, 2015
View reviewed changes
Comment threadsrc/doc/intro.md Outdated

@steveklabniksteveklabnikJan 14, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, these have no annotations. Does it work without them?

@raindevraindevJan 14, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this particular case code without type annotations would fail to compile (error: unable to infer enough type information about). However, to annotate only the first number would be sufficient. I could update the changed examples in such regard.

@steveklabniksteveklabnikJan 14, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please do :) Thanks!

@steveklabnik

steveklabnik commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

Thanks! I think I already have a patch in the queue that removes the suffixes here, but moving to ranges would also be good. Can you check into that?

@raindev

raindev commented Jan 14, 2015

Copy link
Copy Markdown
ContributorAuthor

Yeah, sure. I'd like to do the same changes (update suffixes and ranges) for the rest of examples.

@raindev

raindev commented Jan 14, 2015

Copy link
Copy Markdown
ContributorAuthor

The intro examples are now clear of compilation errors and warning (except the use of unstable Thread::spawn()).

@raindev

raindev commented Jan 14, 2015

Copy link
Copy Markdown
ContributorAuthor

About the issue of detached threads in the examples: I think it's better to create an issue for that and/or address the problem in a separate pull request. What do you think?

@steveklabnik

steveklabnik commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

Well, ideally we'd use scoped instead of spawn. What do you think of that?

@raindev

raindev commented Jan 14, 2015

Copy link
Copy Markdown
ContributorAuthor

Just read the documentation on std::thread: completely agree, scoped() is what we need for these examples. It doesn't seems super hard, so I'll add a commit to this pull request.

@steveklabnik

steveklabnik commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

👍

@raindev

raindev commented Jan 15, 2015

Copy link
Copy Markdown
ContributorAuthor

@steveklabnik, I noticed that 245e6a8 overlaps with #21020. Changes of that pull request could be applied over this one. What do you think about that?

@raindevraindev changed the title Fix intro concurrency examples compilation warningsFix intro examples compilation warningsJan 15, 2015
@steveklabnik

steveklabnik commented Jan 15, 2015

Copy link
Copy Markdown
Contributor

Sounds good

@raindev

raindev commented Jan 15, 2015

Copy link
Copy Markdown
ContributorAuthor

Accordingly to your comment, the threading examples are working sequentially in the current version of this pull request.

@raindev

raindev commented Jan 15, 2015

Copy link
Copy Markdown
ContributorAuthor

I removed the latest commit (245e6a837e58ac866cf5ceb788b914884815ee06), so I wouldn't mess up the thread examples. Leaving them for someone more experienced in Rust.

Goal of this pull request is to make examples compile without warnings which is achieved. Ready to merge.

@raindev
Fix intro concurrency examples compilation warns
d3907b4
* Use range notation instead of deprecated `range()`
* Remove deprecated `u` integer suffixes used in ranges
* Replace deprecated `i` integer suffixes with `is` for vector numbers
`Thread::spawn()` still gives "use of unstable item" warning which I
hadn't found a way to fix.
@raindev
Remove Thread::detach() call from intro example
84d4236
The mentioned method are no longer part of Thread. Spawned threads are
detached by default as of now.
@raindev
Replace obsolete constructions in into examples
37970f1
Replace deprecated integer suffixes. Remove integer type notations
altogether where possible. Replace uses of deprecated `range()`
function with range notation.
@raindev

raindev commented Jan 17, 2015

Copy link
Copy Markdown
ContributorAuthor

@steveklabnik, it looks like this pull request hadn't got merged automatically because of conflicts. I rebased it against master.

bors added a commit that referenced this pull request Jan 17, 2015
@bors
Merge pull request#21121from raindev/fix_intro_concurrency_examples
6df7fcc
Fix intro examples compilation warnings
Reviewed-by: steveklabnik
bors referenced this pull request Jan 17, 2015
@steveklabnik
Add C -> Rust example to FFI chapter of the book.
a5e3849
Fixes#10489.
@steveklabnik

steveklabnik commented Jan 17, 2015

Copy link
Copy Markdown
Contributor

Doing this manually as part of #21300

lnicola pushed a commit to lnicola/rust that referenced this pull request Nov 27, 2025
@ChayimFriedman2
Merge pull requestrust-lang#21121from Zalathar/derive-macro
16f4c86
Basic support for declarative attribute/derive macros
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pcwaltonpcwalton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raindev@rust-highfive@steveklabnik@pcwalton