librustc: hint close matches on accessing nonexisting fields by oli-obk · Pull Request #21187 · rust-lang/rust

oli-obk · 2015-01-15T08:21:58Z

rebase and fix of #19267

rust-highfive · 2015-01-15T08:22:15Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2015-01-18T18:10:21Z

Could you add a test for this error message as well?

sure, allthough the test is not (yet) useful since it's ignored: #21195

oli-obk · 2015-01-19T12:52:50Z

rebased on master, added test and changed number of help messages to one. local make check-stage1 passes, make check is running right now

oli-obk · 2015-01-19T13:20:22Z

make check passed

alexcrichton · 2015-01-19T20:29:31Z

Thanks! Could you squash the commits together as well?

oli-obk · 2015-01-19T20:43:21Z

i just left them there for easier reading.
squashed and rebased

alexcrichton · 2015-01-19T20:45:30Z

@bors: r+ b24da87

bors · 2015-01-20T01:34:27Z

⌛ Testing commit b24da87 with merge b63cc5c...

bors · 2015-01-20T02:23:48Z

💔 Test failed - auto-mac-64-opt

oli-obk · 2015-01-20T13:12:16Z

sorry about that. fixed, rebased and make check ran through

alexcrichton · 2015-01-20T15:27:25Z

@bors: r+ 09d9924

…excrichton rebase and fix of #19267

bors · 2015-01-22T12:09:03Z

⌛ Testing commit 09d9924 with merge b7930d9...

bors · 2015-01-22T14:44:26Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

…lnxww Include operator overload occurrences in SCIP index

rust-highfive assigned alexcrichton Jan 15, 2015

oli-obk force-pushed the feature/hint_struct_field_access branch 2 times, most recently from 59241c8 to 9cd90f7Compare January 15, 2015 12:01

alexcrichton reviewed Jan 18, 2015
View reviewed changes

oli-obk force-pushed the feature/hint_struct_field_access branch 3 times, most recently from 9f085cc to c8d68a7Compare January 19, 2015 12:51

oli-obk force-pushed the feature/hint_struct_field_access branch from c8d68a7 to b24da87Compare January 19, 2015 20:42

librustc: hint close matches on accessing nonexisting fields
09d9924

oli-obk force-pushed the feature/hint_struct_field_access branch from b24da87 to 09d9924Compare January 20, 2015 09:59

bors added a commit that referenced this pull request Jan 22, 2015
Auto merge of#21187- oli-obk:feature/hint_struct_field_access, r=al…
b7930d9
…excrichton rebase and fix of #19267

bors merged commit 09d9924 into rust-lang:masterJan 22, 2015

oli-obk deleted the feature/hint_struct_field_access branch January 23, 2015 09:25

lnicola pushed a commit to lnicola/rust that referenced this pull request Dec 15, 2025
Merge pull requestrust-lang#21187from nicolas-guichard/push-orysqtu…
120be9b
…lnxww Include operator overload occurrences in SCIP index

Uh oh!

Uh oh!

Conversation

oli-obk commented Jan 15, 2015

Uh oh!

rust-highfive commented Jan 15, 2015

Uh oh!

alexcrichtonJan 18, 2015

Choose a reason for hiding this comment

Uh oh!

oli-obkJan 19, 2015

Choose a reason for hiding this comment

Uh oh!

oli-obk commented Jan 19, 2015

Uh oh!

oli-obk commented Jan 19, 2015

Uh oh!

alexcrichton commented Jan 19, 2015

Uh oh!

oli-obk commented Jan 19, 2015

Uh oh!

alexcrichton commented Jan 19, 2015

Uh oh!

bors commented Jan 20, 2015

Uh oh!

bors commented Jan 20, 2015

Uh oh!

oli-obk commented Jan 20, 2015

Uh oh!

alexcrichton commented Jan 20, 2015

Uh oh!

bors commented Jan 22, 2015

Uh oh!

bors commented Jan 22, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants