Skip to content

Add dedicated testcase for #15881 - #21376

Merged
bors merged 1 commit into
rust-lang:masterfrom
fhahn:issue-15881-model-lexer-dotdotdot
Feb 14, 2015
Merged

Add dedicated testcase for #15881#21376
bors merged 1 commit into
rust-lang:masterfrom
fhahn:issue-15881-model-lexer-dotdotdot

Conversation

@fhahn

@fhahnfhahn commented Jan 18, 2015

Copy link
Copy Markdown
Contributor

This PR adds a dedicated regression test for #15881 as @cmr suggested.

@rust-highfive

rust-highfive commented Jan 18, 2015

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

alexcrichton commented Jan 18, 2015

Copy link
Copy Markdown
Member

r? @cmr

pczarn
pczarn reviewed Jan 18, 2015
View reviewed changes
Comment threadsrc/test/run-pass/issue-15881-model-lexer-dotdotdot.rs Outdated

@pczarnpczarnJan 18, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ignore should no longer be here

@fhahnfhahnJan 20, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I've removed the line (and updated the copyright notice date)

@fhahn
Add dedicated testcase forrust-lang#15881
b8efaa6
Also enable an ignored test case, closesrust-lang#15881
@fhahn
fhahnforce-pushed the issue-15881-model-lexer-dotdotdot branch from a4cab28 to b8efaa6CompareJanuary 20, 2015 23:40
@pczarn

pczarn commented Jan 21, 2015

Copy link
Copy Markdown
Contributor

Very well.

@steveklabnik

steveklabnik commented Jan 29, 2015

Copy link
Copy Markdown
Contributor

Isn't @cmr away because of studies?

@fhahn

fhahn commented Feb 1, 2015

Copy link
Copy Markdown
ContributorAuthor

I am not sure if this issue is still relavant after the new model parser got merged, as this issue involves the antlr lexer, which is obselete now, I guess?

@emberian

emberian commented Feb 2, 2015

Copy link
Copy Markdown
Contributor

@bors r+ b8efaa6

@bors

bors commented Feb 3, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b8efaa6 with merge 5870f25...

@alexcrichton

alexcrichton commented Feb 3, 2015

Copy link
Copy Markdown
Member

@bors: retry

@bors

bors commented Feb 3, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b8efaa6 with merge 3b9da16...

@bors

bors commented Feb 3, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-nopt-t

@alexcrichton

alexcrichton commented Feb 3, 2015

Copy link
Copy Markdown
Member

@bors: retry

@bors

bors commented Feb 3, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b8efaa6 with merge 95c237a...

@bors

bors commented Feb 3, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-32-opt

@brson

brson commented Feb 13, 2015

Copy link
Copy Markdown
Contributor

@bors: retry

bors added a commit that referenced this pull request Feb 13, 2015
@bors
Auto merge of#21376- fhahn:issue-15881-model-lexer-dotdotdot, r=cmr
b8c112f
This PR adds a dedicated regression test for #15881 as @cmr suggested.
@bors

bors commented Feb 13, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b8efaa6 with merge b8c112f...

@bors

bors commented Feb 14, 2015

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors
bors merged commit b8efaa6 into rust-lang:masterFeb 14, 2015
@fhahn
fhahn deleted the issue-15881-model-lexer-dotdotdot branch February 14, 2015 08:07
Kobzol pushed a commit to Kobzol/rust that referenced this pull request Jan 5, 2026
@Veykril
Merge pull requestrust-lang#21376from SomeoneToIgnore/doc-find-defs
019d016
Allow finding references from doc comments
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@emberianemberian

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@fhahn@rust-highfive@alexcrichton@pczarn@steveklabnik@emberian@bors@brson@nikomatsakis