Replace usage of slice::from_raw_buf with slice::from_raw_parts by mzabaluev · Pull Request #21926 · rust-lang/rust

mzabaluev · 2015-02-04T08:05:08Z

New functions, slice::from_raw_parts and slice::from_raw_parts_mut,
are added to implement the lifetime convention as agreed in rust-lang/rfcs#556.
The functions slice::from_raw_buf and slice::from_raw_mut_buf are
left deprecated for the time being.

Holding back on changing the signature of std::ffi::c_str_to_bytes as consensus in rust-lang/rfcs#592 is building to replace it with a composition of other functions.

Contribution to #21923.

rust-highfive · 2015-02-04T08:05:22Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

alexcrichton · 2015-02-04T17:09:11Z

Thanks @mzabaluev! This looks great to me, I agree it's best to hold off on c_str_to_bytes for now.

r? @aturon as well, I'm happy with the naming of from_raw_parts as it mirrors Vec::from_raw_parts but I'd like a second opinion as well.

aturon · 2015-02-04T18:45:22Z

Looks good to me too, thanks!

@bors: r+ 1bf653b

bors · 2015-02-05T06:11:56Z

⌛ Testing commit 1bf653b with merge 50612c6...

bors · 2015-02-05T06:27:38Z

💔 Test failed - auto-mac-32-opt

New functions, slice::from_raw_parts and slice::from_raw_parts_mut, are added to implement the lifetime convention as agreed in RFC PR rust-lang#556. The functions slice::from_raw_buf and slice::from_raw_mut_buf are left deprecated for the time being.

mzabaluev · 2015-02-05T12:49:45Z

Rebased: one more use of from_raw_mut_buf has been added with new io.

alexcrichton · 2015-02-05T17:17:24Z

@bors: r+ fb6b970

bors · 2015-02-06T01:22:49Z

⌛ Testing commit fb6b970 with merge 68e7ae8...

bors · 2015-02-06T03:11:33Z

💔 Test failed - auto-win-64-nopt-t

alexcrichton · 2015-02-06T04:13:52Z

@bors: retry

bors · 2015-02-06T09:33:05Z

⌛ Testing commit fb6b970 with merge db851fd...

New functions, `slice::from_raw_parts` and `slice::from_raw_parts_mut`, are added to implement the lifetime convention as agreed in rust-lang/rfcs#556. The functions `slice::from_raw_buf` and `slice::from_raw_mut_buf` are left deprecated for the time being. Holding back on changing the signature of `std::ffi::c_str_to_bytes` as consensus in rust-lang/rfcs#592 is building to replace it with a composition of other functions. Contribution to rust-lang#21923.

bors · 2015-02-06T11:35:50Z

💔 Test failed - auto-win-32-nopt-t

alexcrichton · 2015-02-06T16:33:24Z

@bors: retry

bors · 2015-02-06T19:49:32Z

⌛ Testing commit fb6b970 with merge b75b21c...

New functions, `slice::from_raw_parts` and `slice::from_raw_parts_mut`, are added to implement the lifetime convention as agreed in rust-lang/rfcs#556. The functions `slice::from_raw_buf` and `slice::from_raw_mut_buf` are left deprecated for the time being. Holding back on changing the signature of `std::ffi::c_str_to_bytes` as consensus in rust-lang/rfcs#592 is building to replace it with a composition of other functions. Contribution to #21923.

bors · 2015-02-06T21:53:36Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

fix: Fix param inlayHints on empty expr and comma

rust-highfive assigned alexcrichton Feb 4, 2015

rust-highfive assigned aturon and unassigned alexcrichton Feb 4, 2015

mzabaluev added 2 commits February 5, 2015 13:54

Replace one more slice::from_raw_mut_buf added with new io
fb6b970

mzabaluev force-pushed the raw-lifetime branch from 1bf653b to fb6b970Compare February 5, 2015 12:44

bors merged commit fb6b970 into rust-lang:masterFeb 6, 2015

aturon mentioned this pull request Feb 6, 2015
Stabilization for 1.0-alpha2 #20761
Closed
38 tasks

alexcrichton mentioned this pull request Feb 6, 2015
from_raw(_mut)_buf returns slices with weird lifetimes #20031
Closed

lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 6, 2026
Merge pull requestrust-lang#21926from A4-Tacks/inlayhint-empty-arg
c54002f
fix: Fix param inlayHints on empty expr and comma

lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 9, 2026
Merge pull requestrust-lang#21926from A4-Tacks/inlayhint-empty-arg
166f219
fix: Fix param inlayHints on empty expr and comma

Uh oh!

Uh oh!

Conversation

mzabaluev commented Feb 4, 2015

Uh oh!

rust-highfive commented Feb 4, 2015

Uh oh!

alexcrichton commented Feb 4, 2015

Uh oh!

aturon commented Feb 4, 2015

Uh oh!

bors commented Feb 5, 2015

Uh oh!

bors commented Feb 5, 2015

Uh oh!

mzabaluev commented Feb 5, 2015

Uh oh!

alexcrichton commented Feb 5, 2015

Uh oh!

bors commented Feb 6, 2015

Uh oh!

bors commented Feb 6, 2015

Uh oh!

alexcrichton commented Feb 6, 2015

Uh oh!

bors commented Feb 6, 2015

Uh oh!

bors commented Feb 6, 2015

Uh oh!

alexcrichton commented Feb 6, 2015

Uh oh!

bors commented Feb 6, 2015

Uh oh!

bors commented Feb 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants