Give float some examples by mdinger · Pull Request #22030 · rust-lang/rust

mdinger · 2015-02-07T00:34:55Z

Some examples for std::num::Float

This is WIP for making examples for f32. This probably won't pass make tidy and I'm not sure which f32 needs documentation. #22025 shows 2 sets of f32 which seems split between core and std. I'm not sure which should be documented but I started doing a couple from std. Easy to move if that's where they go...

~~Gotta build it eventually to actually see if the docs actually appear where I think they will or if I'm just disillusioned.~~

cc @steveklabnik

rust-highfive · 2015-02-07T00:35:09Z

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

mdinger · 2015-02-07T00:35:25Z

r? @steveklabnik

ftxqxd · 2015-02-07T01:56:43Z

I think this should be Returns NaN. (with an s and a ‘.’)—the indicative style is recommended over the imperative.
(Same thing for the others below.)

mdinger · 2015-02-07T05:30:19Z

Previously didn't specify exponents base (2? 10? 7? e?). I had to figure out which one worked to recover the original number.

nagisa · 2015-02-07T12:33:33Z

You could document the trait itself rather than this specific implementation of it, no?

mdinger · 2015-02-07T15:14:35Z

I don't mind documenting the trait. I was thinking there weren't any examples of traits being documented directly: Iterator and AsSlice for example though I guess IteratorExt is a trait. I can shift.

mdinger · 2015-02-09T02:51:47Z

Examples shouldn't break if you add a sign somewhere so prefer assigning to variables before using them:

// Should preferlet f = 2.0f64;
f.powi(2);// over2.0f64.powi(2);// because
-2.0f64.powi(2);// gets parsed as
-(2.0f64.powi(2));// when the desired is(-2.0f64).powi(2);// but this works properlylet f = -2.0f64;
f.powi(2);

Note: #22105 ran into this.

steveklabnik · 2015-02-10T03:33:25Z

Yes, we usually document the trait, not the specific implementation. This seems good though, thanks! would you mind squashing? r=me after

mdinger · 2015-02-10T03:35:01Z

Got a few left but sure.

steveklabnik · 2015-02-10T03:38:15Z

Do you want me to just wait until you've got more? I assumed this was ready, if not, I'm happy to hold off.

mdinger · 2015-02-10T03:40:40Z

Yeah. I've got another commit incoming. I'll squash after. I got most everything, maybe skipping deprecated and possibly a few unstable.

I'll change the title from WIP when it's ready.

steveklabnik · 2015-02-10T03:41:33Z

Cool, thank you

mdinger · 2015-02-10T06:35:28Z

@steveklabnik This depends on #22076 merging. It won't pass make check until then.

mdinger · 2015-02-10T06:50:31Z

How a float is encoded needs a good reference. This link is probably wrong and is mainly so I remember. Reposting so it's not hidden.

Deferred to #22152 . Just referred to the float section of the reference for now.

mdinger · 2015-02-10T18:43:57Z

@steveklabnik Seems pretty good. Needs #22076 though so gotta wait until that lands. I'll do r= after that merges and make check passes. Ready to commit besides all that though.

steveklabnik · 2015-02-16T21:49:19Z

@bors: r+ 1a133f3

steveklabnik · 2015-02-16T21:49:23Z

no rollup as this is a big diff

bors · 2015-02-17T12:00:22Z

⌛ Testing commit 1a133f3 with merge b603823...

@steveklabnik

Some examples for `std::num::Float` ~~This is WIP for making examples for `f32`. This probably won't pass `make tidy` and I'm not sure which `f32` needs documentation. rust-lang#22025 shows 2 sets of `f32` which seems split between `core` and `std`. I'm not sure which should be documented but I started doing a couple from `std`. Easy to move if that's where they go...~~ ~~Gotta build it eventually to actually see if the docs actually appear where I think they will or if I'm just disillusioned.~~ cc @steveklabnik

bors · 2015-02-17T13:29:48Z

💔 Test failed - auto-win-32-nopt-t

alexcrichton · 2015-02-17T16:16:48Z

@bors: retry

bors · 2015-02-18T00:43:50Z

⌛ Testing commit 1a133f3 with merge 4087e5b...

bors · 2015-02-18T00:47:33Z

💔 Test failed - auto-win-32-nopt-t

alexcrichton · 2015-02-18T01:29:05Z

@bors: retry

bors · 2015-02-18T02:17:34Z

⌛ Testing commit 1a133f3 with merge 886aca4...

bors · 2015-02-18T02:20:50Z

💔 Test failed - auto-win-64-nopt-t

alexcrichton · 2015-02-18T02:55:30Z

@bors: retry

bors · 2015-02-18T03:58:10Z

⌛ Testing commit 1a133f3 with merge c34229c...

bors · 2015-02-18T04:02:03Z

💔 Test failed - auto-linux-64-nopt-t

alexcrichton · 2015-02-18T04:03:36Z

@bors: retry

bors · 2015-02-18T06:00:13Z

⌛ Testing commit 1a133f3 with merge 4b92061...

bors · 2015-02-18T06:07:04Z

💔 Test failed - auto-linux-64-x-android-t

alexcrichton · 2015-02-18T06:08:30Z

@bors: retry

bors · 2015-02-18T08:38:32Z

⌛ Testing commit 1a133f3 with merge 77988b5...

bors · 2015-02-18T09:53:08Z

💔 Test failed - auto-linux-64-opt

fix: MIR evaluation of sized &T with recursive const fn

rust-highfive assigned huonw Feb 7, 2015

rust-highfive assigned steveklabnik and unassigned huonw Feb 7, 2015

ftxqxd reviewed Feb 7, 2015
View reviewed changes

mdinger force-pushed the f32_examples branch from 3349930 to b1aeb2bCompare February 7, 2015 05:28

mdinger reviewed Feb 7, 2015
View reviewed changes

mdinger force-pushed the f32_examples branch 3 times, most recently from 11cf2bc to cd2c941Compare February 8, 2015 07:05

mdinger changed the title ~~WIP: Give f32 some examples~~WIP: Give float some examplesFeb 8, 2015

mdinger mentioned this pull request Feb 8, 2015
Correct fns exp2 that were calling exp #22076
Merged

mdinger force-pushed the f32_examples branch from c8aac6c to 396244dCompare February 10, 2015 03:48

mdinger force-pushed the f32_examples branch from 396244d to fb5d9daCompare February 10, 2015 06:45

mdinger reviewed Feb 10, 2015
View reviewed changes

mdinger force-pushed the f32_examples branch from fb5d9da to 208e9bcCompare February 10, 2015 18:36

mdinger changed the title ~~WIP: Give float some examples~~Give float some examplesFeb 10, 2015

Manishearth mentioned this pull request Feb 17, 2015
Rollup of 20 pull requests #22439
Closed

huonw merged commit 1a133f3 into rust-lang:masterFeb 18, 2015

lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2026
Merge pull requestrust-lang#22030from Wilfred/pre-mir-relocation-test
5b573d8
fix: MIR evaluation of sized &T with recursive const fn

Uh oh!

Uh oh!

Conversation

mdinger commented Feb 7, 2015

Uh oh!

rust-highfive commented Feb 7, 2015

Uh oh!

mdinger commented Feb 7, 2015

Uh oh!

ftxqxdFeb 7, 2015

Choose a reason for hiding this comment

Uh oh!

mdingerFeb 7, 2015

Choose a reason for hiding this comment

Uh oh!

mdingerFeb 7, 2015

Choose a reason for hiding this comment

Uh oh!

nagisa commented Feb 7, 2015

Uh oh!

mdinger commented Feb 7, 2015

Uh oh!

mdinger commented Feb 9, 2015

Uh oh!

steveklabnik commented Feb 10, 2015

Uh oh!

mdinger commented Feb 10, 2015

Uh oh!

steveklabnik commented Feb 10, 2015

Uh oh!

mdinger commented Feb 10, 2015

Uh oh!

steveklabnik commented Feb 10, 2015

Uh oh!

mdinger commented Feb 10, 2015

Uh oh!

mdingerFeb 10, 2015

Choose a reason for hiding this comment

Uh oh!

mdingerFeb 10, 2015

Choose a reason for hiding this comment

Uh oh!

mdinger commented Feb 10, 2015

Uh oh!

steveklabnik commented Feb 16, 2015

Uh oh!

steveklabnik commented Feb 16, 2015

Uh oh!

bors commented Feb 17, 2015

Uh oh!

bors commented Feb 17, 2015

Uh oh!

alexcrichton commented Feb 17, 2015

Uh oh!

bors commented Feb 18, 2015

Uh oh!

bors commented Feb 18, 2015

Uh oh!

alexcrichton commented Feb 18, 2015

Uh oh!

bors commented Feb 18, 2015

Uh oh!

bors commented Feb 18, 2015

Uh oh!

alexcrichton commented Feb 18, 2015

Uh oh!

bors commented Feb 18, 2015

Uh oh!

bors commented Feb 18, 2015

Uh oh!

alexcrichton commented Feb 18, 2015

Uh oh!

bors commented Feb 18, 2015

Uh oh!

bors commented Feb 18, 2015

Uh oh!

alexcrichton commented Feb 18, 2015

Uh oh!

bors commented Feb 18, 2015

Uh oh!