Uh oh!
There was an error while loading. Please reload this page.
Add std::process - #22119
Merged
Merged
Conversation
aturon
commented
Feb 9, 2015
ContributorAuthor
rust-highfive
commented
Feb 9, 2015
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
aturon
commented
Feb 9, 2015
ContributorAuthor
This is WIP for two reasons:
|
aturonforce-pushed
the
new-process
branch
2 times, most recently
from
February 10, 2015 01:13
30d9074 to
2ffc70fCompareaturonforce-pushed
the
new-process
branch
3 times, most recently
from
February 10, 2015 04:48
b96a50b to
f994b8fCompareMember
There was a problem hiding this comment.
I think that in general we've had pretty good success with trying to have as few #[cfg] directives as possible, could this logic be pushed into each respective sys module?
Contributor
There was a problem hiding this comment.
This should probably not be an int.
aturon
commented
Feb 13, 2015
ContributorAuthor
@bors: retry |
bors
commented
Feb 13, 2015
Collaborator
⌛ Testing commit 1a72dac with merge d05755d... |
bors
commented
Feb 13, 2015
Collaborator
💔 Test failed - auto-win-32-opt |
aturonforce-pushed
the
new-process
branch
3 times, most recently
from
February 14, 2015 00:00
9c50a35 to
0f697c2Compareaturon
commented
Feb 14, 2015
ContributorAuthor
@bors: r=alexcrichton 0f697c2 p=1 |
bors
commented
Feb 14, 2015
Collaborator
⌛ Testing commit 0f697c2 with merge 1ac4113... |
bors
commented
Feb 14, 2015
Collaborator
💔 Test failed - auto-win-32-nopt-t |
aturon
commented
Feb 14, 2015
ContributorAuthor
@bors: r=alexcrichton bec4af2 p=1 |
bors
commented
Feb 14, 2015
Collaborator
⌛ Testing commit bec4af2 with merge 972bafc... |
bors
commented
Feb 14, 2015
Collaborator
💔 Test failed - auto-linux-64-x-android-t |
Per [RFC 579](rust-lang/rfcs#579), this commit adds a new `std::process` module. This module is largely based on the existing `std::old_io::process` module, but refactors the API to use `OsStr` and other new standards set out by IO reform. The existing module is not yet deprecated, to allow for the new API to get a bit of testing before a mass migration to it.
aturon
commented
Feb 14, 2015
ContributorAuthor
bors
commented
Feb 14, 2015
Collaborator
bors added a commit
that referenced
this pull request
Feb 14, 2015
Per [RFC 579](rust-lang/rfcs#579), this commit adds a new `std::process` module. This module is largely based on the existing `std::old_io::process` module, but refactors the API to use `OsStr` and other new standards set out by IO reform. The existing module is not yet deprecated, to allow for the new API to get a bit of testing before a mass migration to it.
This was referenced Feb 14, 2015
bors
commented
Feb 14, 2015
Collaborator
lnicola pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 1, 2026
…yumu Less conjuration magic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 579, this commit
adds a new
std::processmodule. This module is largely based on theexisting
std::old_io::processmodule, but refactors the API to useOsStrand other new standards set out by IO reform.The existing module is not yet deprecated, to allow for the new API to
get a bit of testing before a mass migration to it.