Skip to content

Link from literals to their encoding - #22270

Merged
alexcrichton merged 1 commit into
rust-lang:masterfrom
steveklabnik:gh22152
Feb 23, 2015
Merged

Link from literals to their encoding#22270
alexcrichton merged 1 commit into
rust-lang:masterfrom
steveklabnik:gh22152

Conversation

@steveklabnik

Copy link
Copy Markdown
Contributor

Fixes#22152

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@huonw

Copy link
Copy Markdown
Contributor

I don't quite understand what is meant by "encoding" here.

@steveklabnik

Copy link
Copy Markdown
ContributorAuthor

That they are IEEE 754-2008 floats, specifically. As opposed to some other representation.

@steveklabnik

Copy link
Copy Markdown
ContributorAuthor

@huonw ping? does that make sense?

@huonw

Copy link
Copy Markdown
Contributor

That they are IEEE 754-2008 floats, specifically. As opposed to some other representation.

Hm, I think I prefer that as a word; "encoding" feels a bit too much like e.g. encoding to/from json. Thoughts? (If you agree, r=me with "representation" instead.)

@steveklabnik

Copy link
Copy Markdown
ContributorAuthor

@bors: r=huonw d7c02c3

@steveklabnik

Copy link
Copy Markdown
ContributorAuthor

@huonw agreed, and done. Thanks!

@steveklabnik

Copy link
Copy Markdown
ContributorAuthor

@bors: rollup

bombless added a commit to bombless/rust that referenced this pull request Feb 23, 2015
@bomblessbombless mentioned this pull request Feb 23, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 23, 2015
@alexcrichton
alexcrichton merged commit d7c02c3 into rust-lang:masterFeb 23, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document float encoding in reference

4 participants

@steveklabnik@rust-highfive@huonw@alexcrichton