Skip to content

Mention try macro in error chapter - #22458

Merged
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:try_in_error_chapter
Feb 25, 2015
Merged

Mention try macro in error chapter#22458
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:try_in_error_chapter

Conversation

@steveklabnik

@steveklabniksteveklabnik commented Feb 17, 2015

Copy link
Copy Markdown
Contributor

Fixes#22342

@rust-highfive

rust-highfive commented Feb 17, 2015

Copy link
Copy Markdown
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton
alexcrichton reviewed Feb 18, 2015
View reviewed changes
Comment threadsrc/doc/trpl/error-handling.md Outdated

@alexcrichtonalexcrichtonFeb 18, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the more idiomatic usage today would be file.write_line(&format!(...))

@steveklabniksteveklabnikFeb 23, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexcrichton

alexcrichton commented Feb 18, 2015

Copy link
Copy Markdown
Member

It may be worth also mentioning the FromError behavior (or at least that it exists). I'm fine referring to other documentation about that part of the try! macro.

@steveklabnik

steveklabnik commented Feb 23, 2015

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton , I took care of everything but the FromError stuff. Where do you think we should link? I'm not sure what docs we even have on this at the moment.

@alexcrichton

alexcrichton commented Feb 24, 2015

Copy link
Copy Markdown
Member

The FromError documentation may be good enough for now.

alexcrichton
alexcrichton reviewed Feb 24, 2015
View reviewed changes
Comment threadsrc/doc/trpl/error-handling.md Outdated

@alexcrichtonalexcrichtonFeb 24, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this import std::io instead of referencing std::io::Result? (I think the former is more common)

@steveklabniksteveklabnikFeb 24, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@steveklabnik

steveklabnik commented Feb 24, 2015

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton updated!

@alexcrichton

alexcrichton commented Feb 24, 2015

Copy link
Copy Markdown
Member

@bors: r+ f31ea22

@bors

bors commented Feb 24, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f31ea22 with merge 8fd791e...

@bors

bors commented Feb 24, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f31ea22 with merge fcb6467...

@bors

bors commented Feb 24, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-32-opt

@Manishearth

Manishearth commented Feb 24, 2015

Copy link
Copy Markdown
Member

(Manually canceled since this will go into a rollup)

@steveklabnik

steveklabnik commented Feb 24, 2015

Copy link
Copy Markdown
ContributorAuthor

Ahh

@Manishearth

Manishearth commented Feb 24, 2015

Copy link
Copy Markdown
Member

@bors: retry rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 24, 2015
@Manishearth
Rollup merge ofrust-lang#22458- steveklabnik:try_in_error_chapter, …
a429bf6
…r=alexcrichton
Fixesrust-lang#22342
@bors
bors merged commit f31ea22 into rust-lang:masterFeb 25, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error handling chapter should mention the try! macro

6 participants

@steveklabnik@rust-highfive@alexcrichton@bors@Manishearth@pcwalton