Skip to content

Remove int/uint in libcore/lib.rs - #22504

Merged
bors merged 3 commits into
rust-lang:masterfrom
GuillaumeGomez:audit-integer-libcore
Mar 2, 2015
Merged

Remove int/uint in libcore/lib.rs#22504
bors merged 3 commits into
rust-lang:masterfrom
GuillaumeGomez:audit-integer-libcore

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Feb 18, 2015

Copy link
Copy Markdown
Member

Part of #22240.

@rust-highfive

rust-highfive commented Feb 18, 2015

Copy link
Copy Markdown
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomezGuillaumeGomez changed the title Remove int/uintRemove int/uint in libcore/lib.rsFeb 18, 2015
@aturon

aturon commented Feb 18, 2015

Copy link
Copy Markdown
Contributor

The actual file defining the module should be removed as well.

@GuillaumeGomez

GuillaumeGomez commented Feb 19, 2015

Copy link
Copy Markdown
MemberAuthor

Since the last commit does the exact same thing as #22503, I think we can close #22503.

GuillaumeGomez
GuillaumeGomez reviewed Feb 19, 2015
View reviewed changes
Comment threadsrc/librand/rand_impls.rs

@GuillaumeGomezGuillaumeGomezFeb 19, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aturon: I kept the same logic, but I'm not sure it's correct. What's your opinion on this ?

@GuillaumeGomezGuillaumeGomez mentioned this pull request Feb 19, 2015
Closed
@GuillaumeGomez

GuillaumeGomez commented Feb 26, 2015

Copy link
Copy Markdown
MemberAuthor

@aturon ? Your opinion here please ?

@alexcrichton

alexcrichton commented Feb 27, 2015

Copy link
Copy Markdown
Member

@bors: r+ 6a9db02

@alexcrichton

alexcrichton commented Feb 27, 2015

Copy link
Copy Markdown
Member

@bors: r-

Er actually the pub use isize as int; annotations in libstd/lib.rs also need to be removed I believe.

@GuillaumeGomez

GuillaumeGomez commented Feb 27, 2015

Copy link
Copy Markdown
MemberAuthor

Done !

@alexcrichton

alexcrichton commented Feb 27, 2015

Copy link
Copy Markdown
Member

(forgot a push?)

@GuillaumeGomez

GuillaumeGomez commented Feb 27, 2015

Copy link
Copy Markdown
MemberAuthor

My last commit did or maybe I misunderstood you... What line where you talking about ?

@dotdash

dotdash commented Feb 27, 2015

Copy link
Copy Markdown
Contributor

@alexcrichton for some reason github displays the new commit above your r+ comment, although it is newer than that

@alexcrichton

alexcrichton commented Feb 27, 2015

Copy link
Copy Markdown
Member

@bors: r+ 1e71f51a675c39e8d233b104d6cd344c277f4af0

@bors

bors commented Feb 27, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1e71f51 with merge 222e372...

@bors

bors commented Feb 27, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-x-android-t

@alexcrichton

alexcrichton commented Feb 27, 2015

Copy link
Copy Markdown
Member

@bors: retry

@bors

bors commented Feb 27, 2015

Copy link
Copy Markdown
Collaborator

⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

@bors

bors commented Feb 27, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-32-opt

@bors

bors commented Feb 27, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-64-nopt-t

@alexcrichton

alexcrichton commented Feb 27, 2015

Copy link
Copy Markdown
Member

@bors: retry clean

@bors

bors commented Feb 27, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1e71f51 with merge 19c294a...

@bors

bors commented Feb 27, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-nopt-t

@alexcrichton

alexcrichton commented Feb 27, 2015

Copy link
Copy Markdown
Member

@bors: retry clean

@alexcrichton

alexcrichton commented Feb 28, 2015

Copy link
Copy Markdown
Member

@bors: rollup

@Manishearth

Manishearth commented Feb 28, 2015

Copy link
Copy Markdown
Member

This one fails tests from libcoretest :/

Please run a make check-stage1, at least make check-stage1-crates. It's hard to fix up pull requests that break unit tests since they trigger a full rebuild.

@Manishearth

Manishearth commented Feb 28, 2015

Copy link
Copy Markdown
Member

@bors: r-

@huonwhuonw assigned alexcrichton and unassigned huonwMar 1, 2015
@GuillaumeGomez

GuillaumeGomez commented Mar 1, 2015

Copy link
Copy Markdown
MemberAuthor

I fixed tests. @alexcrichton@Manishearth

@Manishearth

Manishearth commented Mar 1, 2015

Copy link
Copy Markdown
Member

@bors: rollup r=alexcrichton

@bors

bors commented Mar 1, 2015

Copy link
Copy Markdown
Collaborator

@bors r=Manishearth df12658

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 1, 2015
@Manishearth
Rollup merge ofrust-lang#22504- GuillaumeGomez:audit-integer-libcor…
fb19cd7
…e, r=Manishearth
Part of rust-lang#22240.
@bors
bors merged commit df12658 into rust-lang:masterMar 2, 2015
lnicola pushed a commit to lnicola/rust that referenced this pull request Jun 1, 2026
@Veykril
Merge pull requestrust-lang#22504from Veykril/veykril/push-yuuqyxyt…
1582b39
…kkno
Enable salsa feature for syntax-bridge
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@GuillaumeGomez@rust-highfive@aturon@alexcrichton@dotdash@bors@Manishearth@huonw