style nitpicks in rustc and libcollections

[oli-obk]

I tried to follow the style guide as much as possible. This is just from some random readings of the code, so no guarantees on completeness, even in the edited files.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[alexcrichton]

I think that this may wish to retain the outer block because it can be confusing if you expect the indented code below to be the body of the arm but it's in fact a closure.

[alexcrichton]

A few small nits here and there, but overall looks great, thanks! (also needs a rebase)

[oli-obk]

this could allow for future code to be missed, should i create a manual fallback with all possible cases instead?

[alexcrichton]

Yes keeping an explicit exhaustive match should be done wherever possible .

[alexcrichton]

Sorry for being a little slow, but needs a rebase now.

[oli-obk]

nits addressed and rebased

[alexcrichton]

@bors: r+ 1ae4bbffc668ba25d9e482d7b17a8378c4d71708 rollup

[Manishearth]

(Needs rebase; removed from rollup)

[oli-obk]

rebased, compilation ok, checks running

[oli-obk]

checks are also ok

[Manishearth]

Broke again, rollup just landed. So sorry!

Ping me when you get it rebased again.

[oli-obk]

np, trivial rebase, checks running

[oli-obk]

[] caused warnings

[oli-obk]

building found two warnings

[Manishearth]

Okay, you can fix them and just quickly test if they don't fail. Or I can r+ this now, either works.

[oli-obk]

they are fixed

[oli-obk]

and make check ran through

[Manishearth]

@bors: r+ 0bea550 rollup