Uh oh!
There was an error while loading. Please reload this page.
Remove 'static bound from sync::mpsc, Mutex and RwLock. - #22574
Conversation
rust-highfive
commented
Feb 20, 2015
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
9eaf9a0 to
299cdc9CompareThis commit removes many unnecessary `unsafe impl` blocks as well as pushing the needed implementations to the lowest level possible. I noticed that the bounds for `RwLock` are a little off when reviewing rust-lang#22574 and wanted to ensure that we had our story straight on these implementations.
There was a problem hiding this comment.
I'm... a little shocked by this!
There was a problem hiding this comment.
I was also surprised that RwLock previously had such loose bounds, however, I think it was impossible to construct one that didn't satisfy them, so it has probably not mattered (fortunately).
alexcrichton
commented
Feb 20, 2015
The changes to |
299cdc9 to
1fd17f7Comparealexcrichton
commented
Feb 21, 2015
Ok I talked with @aturon tonight and he agreed that this should be ok. r=me with the new test case to trigger an error in the |
Adds some basic tests to check that the types still catch the most glaring errors that could occur. cc rust-lang#22444.
1fd17f7 to
380d23bComparehuonw
commented
Feb 21, 2015
@bors r=alexcirchton 380d |
bors
commented
Feb 22, 2015
⌛ Testing commit 380d23b with merge dcc6ce2... |
Add a basic test that checks that the types catch the most glaring errors that could occur. cc #22444
bors
commented
Feb 22, 2015
This commit removes many unnecessary `unsafe impl` blocks as well as pushing the needed implementations to the lowest level possible. I noticed that the bounds for `RwLock` are a little off when reviewing rust-lang#22574 and wanted to ensure that we had our story straight on these implementations.
fix: use package id as argument to `--package` if package is not unique
Add a basic test that checks that the types catch the most glaring
errors that could occur.
cc #22444