Skip to content

Fix up build warnings about use of [] - #22824

Closed
bossmc wants to merge 1 commit into
rust-lang:masterfrom
bossmc:build-warnings
Closed

Fix up build warnings about use of []#22824
bossmc wants to merge 1 commit into
rust-lang:masterfrom
bossmc:build-warnings

Conversation

@bossmc

Copy link
Copy Markdown
Contributor

Simple PR to fix some build warnings on a clean clone of master.

/home/ubuntu/src/rust/src/librustc/middle/astconv_util.rs:71:51: 71:53 warning: obsolete syntax: []
/home/ubuntu/src/rust/src/librustc/middle/astconv_util.rs:71 Some(prim_ty_to_ty(tcx, &path.segments[], nty))
^~
note: write `[..]` instead
...
/home/ubuntu/src/rust/src/librustc_resolve/lib.rs:2988:53: 2988:55 warning: obsolete syntax: []
/home/ubuntu/src/rust/src/librustc_resolve/lib.rs:2988 self.resolve_error(trait_path.span, &msg[]);
^~
note: write `[..]` instead

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ d9bdc43 rollup

@alexcrichton

Copy link
Copy Markdown
Member

Thanks!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 26, 2015
Simple PR to fix some build warnings on a clean clone of master.
```
/home/ubuntu/src/rust/src/librustc/middle/astconv_util.rs:71:51: 71:53 warning: obsolete syntax: []
/home/ubuntu/src/rust/src/librustc/middle/astconv_util.rs:71 Some(prim_ty_to_ty(tcx, &path.segments[], nty))
^~
note: write `[..]` instead
...
/home/ubuntu/src/rust/src/librustc_resolve/lib.rs:2988:53: 2988:55 warning: obsolete syntax: []
/home/ubuntu/src/rust/src/librustc_resolve/lib.rs:2988 self.resolve_error(trait_path.span, &msg[]);
^~
note: write `[..]` instead
```
@Manishearth

Copy link
Copy Markdown
Member

This is superseded by #22835, I think.

@bossmc

Copy link
Copy Markdown
ContributorAuthor

@Manishearth Agreed (though that PR's changes are slightly different in a few places). I'm happy for this to be closed if that change is merged.

@bors

bors commented Feb 28, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #22860) made this pull request unmergeable. Please resolve the merge conflicts.

@bossmc
bossmc deleted the build-warnings branch June 16, 2021 19:04
lnicola pushed a commit to lnicola/rust that referenced this pull request Jul 20, 2026
…cache
minor: Do not store `Option` in the interner cache's thread local
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@bossmc@rust-highfive@alexcrichton@Manishearth@bors@emberian@huonw