Uh oh!
There was an error while loading. Please reload this page.
Drop alloca_zeroed - #22969
Merged
Merged
Conversation
Its only user was lvalue_scratch_datum which is called with zero=true anymore, so it's effectively unused.
rust-highfive
commented
Mar 2, 2015
Contributor
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
nagisa
commented
Mar 2, 2015
Member
LGTM. |
huonw
commented
Mar 2, 2015
Contributor
@bors r+ f580 |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Mar 3, 2015
Its only user was lvalue_scratch_datum which is called with zero=true anymore, so it's effectively unused.
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Jan 14, 2016
…r-issue-30530, r=dotdash Put back alloca zeroing for issues rust-lang#29092, rust-lang#30018, rust-lang#30530; inject zeroing for rust-lang#30822. ---- Background context: `fn alloca_zeroed` was removed in PR rust-lang#22969, so we haven't been "zero'ing" (\*) the alloca's since at least that point, but the logic behind that PR seems sound, so its not entirely obvious how *long* the underlying bug has actually been present. In other words, I have not yet done a survey to see when the new `alloc_ty` and `lvalue_scratch_datum` calls were introduced that should have had "zero'ing" the alloca's. ---- I first fixedrust-lang#30018, then decided to do a survey of `alloc_ty` calls to see if they needed similar treatment, which quickly led to a rediscovery of rust-lang#30530. While making the regression test for the latter, I discovered rust-lang#30822, which is a slightly different bug (in terms of where the "zero'ing" needs to go), but still relevant. I haven't finished the aforementioned survey of `fn alloc_ty` calls, but I decided I wanted to get this up for review in its current state (namely to see if my attempt to force developers to include a justification for passing `Uninit` can possibly fly, or if I should abandon that path of action). ---- (*): I am putting quotation marks around "zero'ing" because we no longer use zero as our "dropped" marker value. Fixrust-lang#29092Fixrust-lang#30018Fixrust-lang#30530Fixrust-lang#30822
lnicola pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 3, 2026
…source-change Simplify source change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its only user was lvalue_scratch_datum which is called with zero=true
anymore, so it's effectively unused.