Skip to content

Tests for f32/f64 float methods - #22984

Merged
bors merged 3 commits into
rust-lang:masterfrom
carols10cents:tests-for-float
Mar 8, 2015
Merged

Tests for f32/f64 float methods#22984
bors merged 3 commits into
rust-lang:masterfrom
carols10cents:tests-for-float

Conversation

@carols10cents

@carols10centscarols10cents commented Mar 3, 2015

Copy link
Copy Markdown
Member

Building on #22076, I've added some tests for stable methods in f32 and f64 that didn't have any before.

Please let me know if there are any improvements I can make, and I am happy to make them! 📬

@rust-highfive

rust-highfive commented Mar 3, 2015

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@huonw

huonw commented Mar 3, 2015

Copy link
Copy Markdown
Contributor

Wow!

@carols10cents

carols10cents commented Mar 3, 2015

Copy link
Copy Markdown
MemberAuthor

Is that a good wow or a bad wow? :)

@huonw

huonw commented Mar 3, 2015

Copy link
Copy Markdown
Contributor

Definitely a good one! The patch is very comprehensive.

@carols10cents

carols10cents commented Mar 3, 2015

Copy link
Copy Markdown
MemberAuthor

Yay!!!! Thank you :)

huonw
huonw reviewed Mar 3, 2015
View reviewed changes
Comment threadsrc/libstd/num/f32.rs

@huonwhuonwMar 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... not a problem with this patch at all, since this behaviour is documented, but I'm unsure if considering zero to be positive is a great idea. (I filed #22985.)

Maybe you ensure that all the f32/f64 tests of this nature test both is_positive and is_negative, though. I.e. check they're false when they should be, as well as checking that they're true when they should be. (Including the NaN/one ones.)

@huonw

huonw commented Mar 3, 2015

Copy link
Copy Markdown
Contributor

A few minor comments (I've only put them on f32 but they apply to f64 as well) and it should be good to go.

@huonwhuonw assigned huonw and unassigned aturonMar 3, 2015
@carols10cents

carols10cents commented Mar 4, 2015

Copy link
Copy Markdown
MemberAuthor

@huonw Thank you so much for the thorough review! 😻

I added new commits to address your comments; please let me know if you'd like me to squash them down into 902309a :)

@huonw

huonw commented Mar 4, 2015

Copy link
Copy Markdown
Contributor

Looks good; squashing would be great.

@carols10cents

carols10cents commented Mar 4, 2015

Copy link
Copy Markdown
MemberAuthor

Done!! :)

@bors

bors commented Mar 6, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #23031) made this pull request unmergeable. Please resolve the merge conflicts.

@carols10cents
Rearrange tests to be in the same order as implementation
33d8a4e
I was having trouble figuring out which functions had tests and which
didn't. This commit is just moving tests around and does not change
anything.
@carols10cents
Add tests to stable f32 and f64 methods that didn't have any
8f091ef
@carols10cents
Removing unnecessary pub from a test function
1bda1ff
@carols10cents

carols10cents commented Mar 6, 2015

Copy link
Copy Markdown
MemberAuthor

@bors thanks for letting me know! ❤️ good bot.

@steveklabnik

steveklabnik commented Mar 8, 2015

Copy link
Copy Markdown
Contributor

@bors: r=huonw 1bda1ff

@bors

bors commented Mar 8, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1bda1ff with merge b775541...

bors added a commit that referenced this pull request Mar 8, 2015
@bors
Auto merge of#22984- carols10cents:tests-for-float, r=huonw
b775541
Building on #22076, I've added some tests for stable methods in f32 and f64 that didn't have any before.
Please let me know if there are any improvements I can make, and I am happy to make them! 📬
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 8, 2015
@Manishearth
Rollup merge ofrust-lang#22984- carols10cents:tests-for-float, r=huonw
509c6fc
 Building on rust-lang#22076, I've added some tests for stable methods in f32 and f64 that didn't have any before.
Please let me know if there are any improvements I can make, and I am happy to make them! 📬
@bors

bors commented Mar 8, 2015

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors
bors merged commit 1bda1ff into rust-lang:masterMar 8, 2015
@borsbors mentioned this pull request Mar 8, 2015
Merged
@carols10cents
carols10cents deleted the tests-for-float branch March 9, 2015 01:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@huonwhuonw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@carols10cents@rust-highfive@huonw@bors@steveklabnik@aturon