In panicking.rs, change to usize from uint

[strega-nil]

No description provided.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

[rprichard]

We really should change that parameter to u32.

Edit: of course, usize is still an improvement.

[strega-nil]

@rprichard Yeah, you're right. Let me fix that.

[rprichard]

... but to change it to u32, you need to update all the other places that are using usize. Grep for panic_fmt -- for example, the libstd/rt/unwind.rs code uses usize for the line number. I'm pretty sure panic_fmt also shows up in the docs. The compiler knows about the panic_fmt lang item, but I don't know whether it expects a particular type signature; I'm guessing not?

The line as u32 cast isn't necessary.

I think it'll be necessary to use the #[cfg(stage0)] / #[cfg(not(stage0))] tags, so we can keep using usize for the stage0 libraries while using u32 for the stage1 and stage2 libraries. For example, see this commit: 647e54d

[rprichard]

The panic! macro in libstd/macros.rs needs updating.

I think it'll be necessary to use the #[cfg(stage0)] / #[cfg(not(stage0))] tags, so we can keep using usize for the stage0 libraries while using u32 for the stage1 and stage2 libraries.

Or maybe not. If the stage0 compiler doesn't care about the type signature of panic_fmt, then maybe the usize->u32 change is completely contained inside the libraries.

[strega-nil]

Fine, I need to actually do work on this. Just let the PR be for now, or
close it, and I'll fix it later.
On Mar 8, 2015 10:28 AM, "Ryan Prichard" notifications@github.com wrote:

The panic! macro in libstd/macros.rs needs updating.

I think it'll be necessary to use the #[cfg(stage0)] / #[cfg(not(stage0))]
tags, so we can keep using usize for the stage0 libraries while using u32
for the stage1 and stage2 libraries.

Or maybe not. If the stage0 compiler doesn't care about the type signature
of panic_fmt, then maybe the usize->u32 change is completely contained
inside the libraries.

—
Reply to this email directly or view it on GitHub
#23170 (comment).

[bors]

☔ The latest upstream changes (presumably #23796) made this pull request unmergeable. Please resolve the merge conflicts.

[alexcrichton]

This appears to have migrated in the meantime, so closing. Thanks though!