Skip to content

Overloaded augmented assignments (a += b) - #23171

Closed
japaric wants to merge 1 commit into
rust-lang:masterfrom
japaric:op-assign
Closed

Overloaded augmented assignments (a += b)#23171
japaric wants to merge 1 commit into
rust-lang:masterfrom
japaric:op-assign

Conversation

@japaric

@japaricjaparic commented Mar 8, 2015

Copy link
Copy Markdown
Contributor

Implements overload-able augmented/compound assignments, like a += b via the AddAssign trait, as specified in RFC 953

r? @nikomatsakis

@rust-highfive

rust-highfive commented Mar 8, 2015

Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@japaricjaparic mentioned this pull request Mar 8, 2015
Merged
@japaric

japaric commented Mar 8, 2015

Copy link
Copy Markdown
ContributorAuthor

RFC at rust-lang/rfcs#953

This was referenced Mar 8, 2015
Closed
Closed
@japaric

japaric commented Mar 11, 2015

Copy link
Copy Markdown
ContributorAuthor

(If anyone is looking, I've added the op_assign feature gate)

@bors

bors commented Mar 28, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #23796) made this pull request unmergeable. Please resolve the merge conflicts.

@japaricjaparic mentioned this pull request May 16, 2015
Closed
@bors

bors commented May 24, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #25609) made this pull request unmergeable. Please resolve the merge conflicts.

@japaric
japaricforce-pushed the op-assign branch 2 times, most recently from eabc21c to 46c7202CompareJune 15, 2015 22:45
@bors

bors commented Jun 19, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #26351) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented Jun 27, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #26575) made this pull request unmergeable. Please resolve the merge conflicts.

@Gankra

Gankra commented Jul 27, 2015

Copy link
Copy Markdown
Contributor

@japaric I'm gonna go ahead and close this PR since it doesn't look like this is going to get through the RFC process anytime soon.

Your contributions, as always, are greatly appreciated!

@GankraGankra closed this Jul 27, 2015
@nikomatsakisnikomatsakis mentioned this pull request Sep 4, 2015
Closed
@japaricjaparic changed the title [RFC] Overloaded assignment operations a += bOverloaded augmented assignments (a += b)Sep 11, 2015
@japaric

japaric commented Sep 11, 2015

Copy link
Copy Markdown
ContributorAuthor

Rebased, documented the traits and updated the description of E0368.

r? @nikomatsakis

@Gankra

Gankra commented Sep 11, 2015

Copy link
Copy Markdown
Contributor

@japaric github seems to refuse to reopen this, might need a new PR?

@japaric

japaric commented Sep 11, 2015

Copy link
Copy Markdown
ContributorAuthor

@gankro just sent #28345

lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 24, 2026
@A4-Tacks
Merge pull requestrust-lang#23171from A4-Tacks/skip-iter-no-intoiter
3a7792a
minor: skip iter excludes 'into_iter' method
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brsonbrson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@japaric@rust-highfive@bors@Gankra@brson