Uh oh!
There was an error while loading. Please reload this page.
document undefined collection behavior with interior mutability - #23342
Merged
Conversation
rust-highfive
commented
Mar 13, 2015
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
apasel422
commented
Mar 13, 2015
ContributorAuthor
alexcrichton
commented
Mar 16, 2015
Member
I'm not sure how strong we really want the wording to be here, saying that it will be undefined is kinda scary and sounds like we're willing to put the burden of safety on the user, not the implementation. I think the emphasis here is that a logic error can happen if keys are modified but the key idea is that a segfault should never happen. (I also prefer to format docs to 80-char line limits where the surrounding style is that as well) |
apasel422
commented
Mar 16, 2015
ContributorAuthor
Comments addressed. |
alexcrichton
commented
Mar 16, 2015
Member
bors
commented
Mar 16, 2015
Collaborator
bors added a commit
that referenced
this pull request
Mar 16, 2015
bors
commented
Mar 16, 2015
Collaborator
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#23327