Skip to content

Add read_all to std:io::Read to parallel write_all in std::io::Write. - #23369

Closed
novalis wants to merge 1 commit into
rust-lang:masterfrom
novalis:dturner/read_all
Closed

Add read_all to std:io::Read to parallel write_all in std::io::Write.#23369
novalis wants to merge 1 commit into
rust-lang:masterfrom
novalis:dturner/read_all

Conversation

@novalis

Copy link
Copy Markdown
Contributor

Fixes#23174

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@mahkoh

Copy link
Copy Markdown
Contributor

Needs an RFC.

@novalis

Copy link
Copy Markdown
ContributorAuthor

RFC: rust-lang/rfcs#980

@bors

bors commented Mar 19, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #23430) made this pull request unmergeable. Please resolve the merge conflicts.

In the event of EOF, read_all returns a result with the new error
ShortRead(number of bytes successfully read).
Fixesrust-lang#23174
@archshift

Copy link
Copy Markdown
Contributor

What's the status of this?

@bombless

Copy link
Copy Markdown
Contributor

@archshift, seems that this will get merged once the RFC is accepted.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the size of the enum dramatically.

@alexcrichton

Copy link
Copy Markdown
Member

I'm going to close this in favor of the associated RFC, but we can certainly reopen if it's accepted!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add read_full to std::io::ReadExt

10 participants

@novalis@rust-highfive@mahkoh@bors@archshift@bombless@alexcrichton@nwin@bluss@aturon