Uh oh!
There was an error while loading. Please reload this page.
Select projections over impls in case of ambiguity. Fixes #23336. - #23424
Merged
Conversation
nikomatsakis
commented
Mar 17, 2015
Contributor
@arielb1 this looks good to me, modulo the nits in the comments. |
bors
commented
Apr 2, 2015
Collaborator
☔ The latest upstream changes (presumably #23955) made this pull request unmergeable. Please resolve the merge conflicts. |
arielb1
commented
May 7, 2015
ContributorAuthor
Rebased and updated comment to be more correct. |
nikomatsakis
commented
May 11, 2015
Contributor
@bors r+ |
bors
commented
May 11, 2015
Collaborator
📌 Commit 2a12e51 has been approved by |
bors
commented
May 11, 2015
Collaborator
⌛ Testing commit 2a12e51 with merge 8e4527e... |
tamird
commented
May 12, 2015
Contributor
does this close #20297? |
alexcrichton
commented
May 12, 2015
Member
@bors: retry force |
bors
commented
May 12, 2015
Collaborator
⌛ Testing commit 2a12e51 with merge f2e1a1b... |
bors added a commit
that referenced
this pull request
May 12, 2015
bors
commented
May 12, 2015
Collaborator
arielb1
commented
May 12, 2015
ContributorAuthor
No it doesn't |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis