Skip to content

std: Remove old_io/old_path from the prelude - #23470

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:less-prelude
Mar 21, 2015
Merged

std: Remove old_io/old_path from the prelude#23470
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:less-prelude

Conversation

@alexcrichton

@alexcrichtonalexcrichton commented Mar 18, 2015

Copy link
Copy Markdown
Member

This commit removes the reexports of old_io traits as well as old_path types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like Seek in the std::io
module (currently reexported as NewSeek in the io prelude).

Closes#23377
Closes#23378

@rust-highfive

rust-highfive commented Mar 18, 2015

Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@bors

bors commented Mar 18, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #22838) made this pull request unmergeable. Please resolve the merge conflicts.

@aturon

aturon commented Mar 18, 2015

Copy link
Copy Markdown
Contributor

Delighted that this day has come!

r=me after a rebase

@alexcrichton

alexcrichton commented Mar 18, 2015

Copy link
Copy Markdown
MemberAuthor

@bors: r=aturon

@bors

bors commented Mar 18, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 47cb40d has been approved by aturon

@bors

bors commented Mar 19, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 47cb40d with merge e4e647e...

@bors

bors commented Mar 19, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-32-opt

@alexcrichton

alexcrichton commented Mar 19, 2015

Copy link
Copy Markdown
MemberAuthor

@bors: r=aturon e4e647e

@bors

bors commented Mar 19, 2015

Copy link
Copy Markdown
Collaborator

🙀 e4e647e is not a valid commit SHA. Please try again with c3eb592.

@alexcrichton

alexcrichton commented Mar 19, 2015

Copy link
Copy Markdown
MemberAuthor

@bors: r=aturon c3eb592

@bors

bors commented Mar 20, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c3eb592 with merge 52830ab...

@bors

bors commented Mar 20, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-32-opt

@alexcrichton

alexcrichton commented Mar 20, 2015

Copy link
Copy Markdown
MemberAuthor

@bors: r=aturon b962ec0

@bors

bors commented Mar 20, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b962ec0 with merge d5c590a...

@bors

bors commented Mar 20, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-32-opt

@alexcrichton

alexcrichton commented Mar 20, 2015

Copy link
Copy Markdown
MemberAuthor

@bors: r=aturon bc09a97

@bors

bors commented Mar 20, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit bc09a97 with merge d56eb07...

@bors

bors commented Mar 20, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt

@alexcrichton

alexcrichton commented Mar 20, 2015

Copy link
Copy Markdown
MemberAuthor

@bors: r=aturon e8daec8

@bors

bors commented Mar 21, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e8daec8 with merge eaf8fe0...

@bors

bors commented Mar 21, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt

@alexcrichton
std: Remove old_io/old_path from the prelude
212e031
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).
Closesrust-lang#23377Closesrust-lang#23378
@alexcrichton

alexcrichton commented Mar 21, 2015

Copy link
Copy Markdown
MemberAuthor

@bors: r=aturon 212e031

@bors

bors commented Mar 21, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 212e031 with merge ecf8c64...

bors added a commit that referenced this pull request Mar 21, 2015
@bors
Auto merge of#23470- alexcrichton:less-prelude, r=aturon
ecf8c64
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).
Closes#23377Closes#23378
@bors

bors commented Mar 21, 2015

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors
bors merged commit 212e031 into rust-lang:masterMar 21, 2015
This was referenced Mar 21, 2015
Closed
Merged
@alexcrichton
alexcrichton deleted the less-prelude branch March 27, 2015 20:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brsonbrson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

std::io::prelude should stop renaming Seek std::prelude::v1 still references old_path and old_io

5 participants

@alexcrichton@rust-highfive@bors@aturon@brson