Uh oh!
There was an error while loading. Please reload this page.
Remove rt::default_sched_threads and RUST_THREADS. - #23534
Closed
steveklabnik wants to merge 1 commit into
Closed
Conversation
rust-highfive
commented
Mar 19, 2015
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
aturon
commented
Mar 19, 2015
Contributor
@bors: r+ c6a24e4 |
alexcrichton
commented
Mar 19, 2015
Member
/me sheds a single tear |
steveklabnik
commented
Mar 19, 2015
ContributorAuthor
|
Manishearth
commented
Mar 20, 2015
Member
Note: this has a merge conflict with #23535, so it might not make it into the rollup (though it's in the rollup for now). |
pnkfelix
commented
Mar 20, 2015
Contributor
@Manishearth did you mean to write #23525 up above? |
Manishearth
commented
Mar 20, 2015
Member
Yep, sorry |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Mar 20, 2015
…r=alexcrichton As @alexcrichton says, this was really a libgreen thing, and isn't relevant now. As this removes a technically-public function, this is a [breaking-change]
bors
commented
Mar 20, 2015
Collaborator
🔒 Merge conflict |
bors
commented
Mar 20, 2015
Collaborator
☔ The latest upstream changes (presumably #23548) made this pull request unmergeable. Please resolve the merge conflicts. |
Manishearth
commented
Mar 20, 2015
Member
This merged as 6107e4c (needed fixing of conflicts) This PR can be closed. |
As @alexcrichton says, this was really a libgreen thing, and isn't relevant now. As this removes a technically-public function, this is a [breaking-change]
steveklabnikforce-pushed
the
remove_sched_threads
branch
from
March 20, 2015 14:57
c6a24e4 to
188fe70Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @alexcrichton says, this was really a libgreen thing, and isn't
relevant now.
As this removes a technically-public function, this is a
[breaking-change]