Uh oh!
There was an error while loading. Please reload this page.
Make the width function of char return u32 - #23539
Conversation
rust-highfive
commented
Mar 20, 2015
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
I believe these files should be changed by changing src/etc/unicode.py, not by hand-editing.
There was a problem hiding this comment.
Hm, this seems like somewhat of an edge case: the width of a string will typically be fairly similar (at least, proportional) to its size in memory.
There was a problem hiding this comment.
Maybe that calls for u64, for integers that do not clearly fall in the range of u32?
petrochenkov
commented
Mar 20, 2015
IMO, it's a mistake. |
tbu-
commented
Mar 20, 2015
@petrochenkov I believe that this is different from things like |
bors
commented
Mar 28, 2015
☔ The latest upstream changes (presumably #23796) made this pull request unmergeable. Please resolve the merge conflicts. |
huonw
commented
Apr 6, 2015
r? @aturon (transferring reviewership, don't have the bandwidth right now.) |
The width of a Unicode codepoint is not related to some in-memory buffer.
tbu-
commented
Apr 6, 2015
@aturon Rebased. |
aturon
commented
Apr 8, 2015
@tbu- I feel like this is definitely an edge case, and probably ergonomic concerns (about the integer contexts in which you might be using this) apply. Can you think of any way to gather data on this? It's very difficult to make this decision in isolation. |
bors
commented
Apr 18, 2015
☔ The latest upstream changes (presumably #24428) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
commented
May 1, 2015
This function is now deprecated in favor of an external crate, so I'm going to close this for now. Feel free to open a PR against that crate though! |
The width of a Unicode codepoint is not related to some in-memory buffer.