Uh oh!
There was an error while loading. Please reload this page.
Implement RFC 909: move thread_local into thread - #23557
Conversation
aturon
commented
Mar 20, 2015
cc @carllerche |
rust-highfive
commented
Mar 20, 2015
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Due to pub use not actually issuing deprecation warnings, and the fact that this is such a relatively rarely imported module, I'd be fine just deleting this module.
aturon
commented
Mar 20, 2015
Comments addressed. Thanks! |
alexcrichton
commented
Mar 20, 2015
@bors: r+ 218b5abf5f703555d50833af6bd3fd966c8901f6 |
aturon
commented
Mar 20, 2015
@bors: r=alexcrichton 6143776 |
bors
commented
Mar 21, 2015
☔ The latest upstream changes (presumably #23512) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
commented
Mar 21, 2015
🔒 Merge conflict |
There was a problem hiding this comment.
I don’t like these comments as they usually suggest the file is getting too big and should be split into more, instead of adding such comments.
This commit implements [RFC 909](rust-lang/rfcs#909): The `std::thread_local` module is now deprecated, and its contents are available directly in `std::thread` as `LocalKey`, `LocalKeyState`, and `ScopedKey`. The macros remain exactly as they were, which means little if any code should break. Nevertheless, this is technically a: [breaking-change] Closesrust-lang#23547
aturon
commented
Mar 23, 2015
This commit implements [RFC 909](rust-lang/rfcs#909): The `std::thread_local` module is now deprecated, and its contents are available directly in `std::thread` as `LocalKey`, `LocalKeyState`, and `ScopedKey`. The macros remain exactly as they were, which means little if any code should break. Nevertheless, this is technically a: [breaking-change] Closesrust-lang#23547
This commit implements RFC 909:
The
std::thread_localmodule is now deprecated, and its contents areavailable directly in
std::threadasLocalKey,LocalKeyState, andScopedKey.The macros remain exactly as they were, which means little if any code
should break. Nevertheless, this is technically a:
[breaking-change]
Closes#23547