Uh oh!
There was an error while loading. Please reload this page.
Beef up BufRead::consume docs - #23622
Merged
Merged
Conversation
rust-highfive
commented
Mar 22, 2015
Contributor
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
oli-obk
commented
Mar 23, 2015
Contributor
also there's no mention that the number of bytes passed to |
steveklabnik
commented
Mar 23, 2015
ContributorAuthor
@oli-obk thanks! fixed. That naming convention is something I have yet to internalize, ugh. |
Member
There was a problem hiding this comment.
Can this follow the surrounding style of wrapping to 80 characters? Other than that r=me
steveklabnik
commented
Mar 23, 2015
ContributorAuthor
@bors: r=alexcrichton rollup |
bors
commented
Mar 23, 2015
Collaborator
📌 Commit a5e1cbe has been approved by |
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Mar 23, 2015
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2015
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2015
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Mar 24, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#23196