Uh oh!
There was an error while loading. Please reload this page.
Dedupe typeorigin - #23691
Merged
Merged
Conversation
richoforce-pushed
the
dedup-typeorigin-mergable
branch
from
March 25, 2015 05:39
6fac3a1 to
00a0fceCompareContributor
There was a problem hiding this comment.
Isn't this exported through std::fmt as well?
eddyb
commented
Mar 26, 2015
Contributor
LGTM, modulo nits. |
richoforce-pushed
the
dedup-typeorigin-mergable
branch
from
March 26, 2015 04:43
00a0fce to
f5d2ebaCompareThis doesn't actually solve the issue that prompted this, at: https://github.com/rust-lang/rust/blob/master/src/librustc/session/mod.rs#L262-271 But skimming the cfg it appears that all type information has been discarded long before that point.
richoforce-pushed
the
dedup-typeorigin-mergable
branch
from
March 26, 2015 04:44
f5d2eba to
c193fe4Comparericho
commented
Mar 26, 2015
ContributorAuthor
Nits addressed! Thanks for that. r? @eddyb |
eddyb
commented
Mar 26, 2015
Contributor
Thanks! @bors r+ |
bors
commented
Mar 26, 2015
Collaborator
📌 Commit c193fe4 has been approved by |
bors
commented
Mar 26, 2015
Collaborator
bors added a commit
that referenced
this pull request
Mar 26, 2015
I've started on refactoring the error handling code to avoid the need to reparse generated errors in `span_*`, but would rather land this incrementally as one monolithic PR (and have un-fond memories of merge conflicts from various other monoliths) r? @eddyb
bors
commented
Mar 26, 2015
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've started on refactoring the error handling code to avoid the need to reparse generated errors in
span_*, but would rather land this incrementally as one monolithic PR (and have un-fond memories of merge conflicts from various other monoliths)r? @eddyb